target/hppa: Fix FP exception handling

[PATCH 0/3] target/hppa: Fix FP exception handling

Posted by deller@kernel.org 7 months ago

From: Helge Deller <deller@gmx.de>

This series fixes and improves the floating point exception
handling in the hppa system and user emulation.
A testcase is included in patch #3.

Please review.

Thanks!
Helge

Helge Deller (3):
  target/hppa: Copy instruction code into fr1 on FPU assist fault
  linux-user/hppa: Send proper si_code on SIGFPE exception
  target/hppa: Fix FPE exceptions

 linux-user/hppa/cpu_loop.c | 12 ++++++++++--
 target/hppa/fpu_helper.c   | 20 +++++++++++++++++---
 target/hppa/int_helper.c   |  4 ++++
 3 files changed, 31 insertions(+), 5 deletions(-)

-- 
2.47.0

Re: [PATCH 0/3] target/hppa: Fix FP exception handling

Posted by Michael Tokarev 6 months, 3 weeks ago

On 17.05.2025 15:00, deller@kernel.org wrote:
> From: Helge Deller <deller@gmx.de>
> 
> This series fixes and improves the floating point exception
> handling in the hppa system and user emulation.
> A testcase is included in patch #3.
> 
> Please review.
> 
> Thanks!
> Helge
> 
> Helge Deller (3):
>    target/hppa: Copy instruction code into fr1 on FPU assist fault
>    linux-user/hppa: Send proper si_code on SIGFPE exception
>    target/hppa: Fix FPE exceptions

Is there anything relevant for qemu-stable?

At least patch #1 seems to be relevant, at least for the recent
qemu-stable series.

Thanks,

/mjt

Re: [PATCH 0/3] target/hppa: Fix FP exception handling

Posted by Helge Deller 6 months, 3 weeks ago

On 5/24/25 12:26, Michael Tokarev wrote:
> On 17.05.2025 15:00, deller@kernel.org wrote:
>> From: Helge Deller <deller@gmx.de>
>>
>> This series fixes and improves the floating point exception
>> handling in the hppa system and user emulation.
>> A testcase is included in patch #3.
>>
>> Please review.
>>
>> Thanks!
>> Helge
>>
>> Helge Deller (3):
>>    target/hppa: Copy instruction code into fr1 on FPU assist fault
>>    linux-user/hppa: Send proper si_code on SIGFPE exception
>>    target/hppa: Fix FPE exceptions
> 
> Is there anything relevant for qemu-stable?

Basically all are relevant, but I think they don't apply cleanly.
  
> At least patch #1 seems to be relevant, at least for the recent
> qemu-stable series.

Patch #1 alone won't help, as the OS will only recognize it if
the bits are set as done in patch #3.
So, backporting all or none of the patches is the right way.

Helg

Re: [PATCH 0/3] target/hppa: Fix FP exception handling

Posted by Michael Tokarev 6 months, 3 weeks ago

On 25.05.2025 03:42, Helge Deller wrote:
> On 5/24/25 12:26, Michael Tokarev wrote:
>> On 17.05.2025 15:00, deller@kernel.org wrote:
>>> From: Helge Deller <deller@gmx.de>
>>>
>>> This series fixes and improves the floating point exception
>>> handling in the hppa system and user emulation.
>>> A testcase is included in patch #3.
>>>
>>> Please review.
>>>
>>> Thanks!
>>> Helge
>>>
>>> Helge Deller (3):
>>>    target/hppa: Copy instruction code into fr1 on FPU assist fault
>>>    linux-user/hppa: Send proper si_code on SIGFPE exception
>>>    target/hppa: Fix FPE exceptions
>>
>> Is there anything relevant for qemu-stable?
> 
> Basically all are relevant, but I think they don't apply cleanly.

They do.

>> At least patch #1 seems to be relevant, at least for the recent
>> qemu-stable series.
> 
> Patch #1 alone won't help, as the OS will only recognize it if
> the bits are set as done in patch #3.
> So, backporting all or none of the patches is the right way.

Ok, this makes sense.  I've applied all 3 to 9.2 and 10.0 series.

Thanks,

/mjt