rust: pl011: bug fixes

[PATCH 0/7] rust: pl011: bug fixes

Posted by Paolo Bonzini 3 months, 3 weeks ago

While preparing the comparison at
https://lists.nongnu.org/archive/html/qemu-rust/2024-12/msg00006.html,
I noticed some bugs in the code.  These are the corresponding fixes.

CCing Philippe because he expressed interest in bringing the Rust
version on par with the C version of the pl011 device.

Thanks,

Paolo

Paolo Bonzini (7):
  rust: pl011: fix declaration of LineControl bits
  rust: pl011: match break logic of C version
  rust: pl011: always use reset() method on registers
  rust: pl011: fix break errors and definition of Data struct
  rust: pl011: extend registers to 32 bits
  rust: pl011: fix migration stream
  rust: pl011: simplify handling of the FIFO enabled bit in LCR

 rust/hw/char/pl011/src/device.rs       | 119 +++++++++++-------
 rust/hw/char/pl011/src/device_class.rs |   8 +-
 rust/hw/char/pl011/src/lib.rs          | 161 +++++++++++++------------
 rust/qemu-api/src/vmstate.rs           |  22 ----
 4 files changed, 160 insertions(+), 150 deletions(-)

-- 
2.47.1

Re: [PATCH 0/7] rust: pl011: bug fixes

Posted by Philippe Mathieu-Daudé 3 months, 3 weeks ago

On 12/12/24 18:21, Paolo Bonzini wrote:
> While preparing the comparison at
> https://lists.nongnu.org/archive/html/qemu-rust/2024-12/msg00006.html,
> I noticed some bugs in the code.  These are the corresponding fixes.
> 
> CCing Philippe because he expressed interest in bringing the Rust
> version on par with the C version of the pl011 device.

Also cc'ing Zhao.

> Paolo Bonzini (7):
>    rust: pl011: fix declaration of LineControl bits
>    rust: pl011: match break logic of C version
>    rust: pl011: always use reset() method on registers
>    rust: pl011: fix break errors and definition of Data struct
>    rust: pl011: extend registers to 32 bits
>    rust: pl011: fix migration stream
>    rust: pl011: simplify handling of the FIFO enabled bit in LCR
> 
>   rust/hw/char/pl011/src/device.rs       | 119 +++++++++++-------
>   rust/hw/char/pl011/src/device_class.rs |   8 +-
>   rust/hw/char/pl011/src/lib.rs          | 161 +++++++++++++------------
>   rust/qemu-api/src/vmstate.rs           |  22 ----
>   4 files changed, 160 insertions(+), 150 deletions(-)
>