1. Patchew
  2. QEMU
  3. View series

[PATCH] ppc/pnv: I2C controller is not user creatable

Cédric Le Goater posted 1 patch 1 year, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240318154420.220734-1-clg@redhat.com
Maintainers: "Cédric Le Goater" <clg@kaod.org>, Nicholas Piggin <npiggin@gmail.com>, "Frédéric Barrat" <fbarrat@linux.ibm.com>
There is a newer version of this series
hw/ppc/pnv_i2c.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] ppc/pnv: I2C controller is not user creatable
Posted by Cédric Le Goater 1 year, 10 months ago 
The I2C controller is a subunit of the processor. Make it so and avoid
QEMU crashes.

  $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
  qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i2c->chip' failed.
  Aborted (core dumped)

Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/ppc/pnv_i2c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c
index 4581cc5e5d4645ab3e358d983a633e33a214c425..37d7b3d68a98d88f201b9a297dbb18678ffdcec2 100644
--- a/hw/ppc/pnv_i2c.c
+++ b/hw/ppc/pnv_i2c.c
@@ -559,6 +559,7 @@ static void pnv_i2c_class_init(ObjectClass *klass, void *data)
 
     dc->desc = "PowerNV I2C";
     dc->realize = pnv_i2c_realize;
+    dc->user_creatable = false;
     device_class_set_props(dc, pnv_i2c_properties);
 }
 
-- 
2.44.0
Re: [PATCH] ppc/pnv: I2C controller is not user creatable
Posted by Thomas Huth 1 year, 10 months ago 
On 18/03/2024 16.44, Cédric Le Goater wrote:
> The I2C controller is a subunit of the processor. Make it so and avoid
> QEMU crashes.
> 
>    $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
>    qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i2c->chip' failed.
>    Aborted (core dumped)
> 
> Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/ppc/pnv_i2c.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c
> index 4581cc5e5d4645ab3e358d983a633e33a214c425..37d7b3d68a98d88f201b9a297dbb18678ffdcec2 100644
> --- a/hw/ppc/pnv_i2c.c
> +++ b/hw/ppc/pnv_i2c.c
> @@ -559,6 +559,7 @@ static void pnv_i2c_class_init(ObjectClass *klass, void *data)
>   
>       dc->desc = "PowerNV I2C";
>       dc->realize = pnv_i2c_realize;
> +    dc->user_creatable = false;

Maybe add a comment in front of it (which is good style for setting 
user_creatable = false):

         /* This device is part of the CPU and cannot be used separately */

or so.

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>

>       device_class_set_props(dc, pnv_i2c_properties);
>   }
>
Re: [PATCH] ppc/pnv: I2C controller is not user creatable
Posted by Cédric Le Goater 1 year, 10 months ago 
On 3/18/24 16:53, Thomas Huth wrote:
> On 18/03/2024 16.44, Cédric Le Goater wrote:
>> The I2C controller is a subunit of the processor. Make it so and avoid
>> QEMU crashes.
>>
>>    $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
>>    qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i2c->chip' failed.
>>    Aborted (core dumped)
>>
>> Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>>   hw/ppc/pnv_i2c.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c
>> index 4581cc5e5d4645ab3e358d983a633e33a214c425..37d7b3d68a98d88f201b9a297dbb18678ffdcec2 100644
>> --- a/hw/ppc/pnv_i2c.c
>> +++ b/hw/ppc/pnv_i2c.c
>> @@ -559,6 +559,7 @@ static void pnv_i2c_class_init(ObjectClass *klass, void *data)
>>       dc->desc = "PowerNV I2C";
>>       dc->realize = pnv_i2c_realize;
>> +    dc->user_creatable = false;
> 
> Maybe add a comment in front of it (which is good style for setting user_creatable = false):
> 
>          /* This device is part of the CPU and cannot be used separately */
> 
> or so.

ok. will resend.


Thanks,

C.




> 
> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
>>       device_class_set_props(dc, pnv_i2c_properties);
>>   }
>
Re: [PATCH] ppc/pnv: I2C controller is not user creatable
Posted by Cédric Le Goater 1 year, 10 months ago 
On 3/18/24 16:44, Cédric Le Goater wrote:
> The I2C controller is a subunit of the processor. Make it so and avoid
> QEMU crashes.
> 
>    $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
>    qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i2c->chip' failed.
>    Aborted (core dumped)


and

Fixes: 263b81ee15af ("ppc/pnv: Add an I2C controller model")

Sorry for the noise,

C.

> Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/ppc/pnv_i2c.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c
> index 4581cc5e5d4645ab3e358d983a633e33a214c425..37d7b3d68a98d88f201b9a297dbb18678ffdcec2 100644
> --- a/hw/ppc/pnv_i2c.c
> +++ b/hw/ppc/pnv_i2c.c
> @@ -559,6 +559,7 @@ static void pnv_i2c_class_init(ObjectClass *klass, void *data)
>   
>       dc->desc = "PowerNV I2C";
>       dc->realize = pnv_i2c_realize;
> +    dc->user_creatable = false;
>       device_class_set_props(dc, pnv_i2c_properties);
>   }
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.