[v2] ppc/pnv: I2C controller is not user creatable

[PATCH v2] ppc/pnv: I2C controller is not user creatable

Posted by Cédric Le Goater 1 month, 1 week ago

The I2C controller is a subunit of the processor. Make it so and avoid
QEMU crashes.

  $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
  qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i2c->chip' failed.
  Aborted (core dumped)

Fixes: 263b81ee15af ("ppc/pnv: Add an I2C controller model")
Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
Reported-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/ppc/pnv_i2c.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c
index 4581cc5e5d4645ab3e358d983a633e33a214c425..eec5047ce83f842108b53a6e2bd9869a81f14ac1 100644
--- a/hw/ppc/pnv_i2c.c
+++ b/hw/ppc/pnv_i2c.c
@@ -557,6 +557,9 @@ static void pnv_i2c_class_init(ObjectClass *klass, void *data)
 
     xscomc->dt_xscom = pnv_i2c_dt_xscom;
 
+    /* Reason: This device is part of the CPU and cannot be used separately */
+    dc->user_creatable = false;
+
     dc->desc = "PowerNV I2C";
     dc->realize = pnv_i2c_realize;
     device_class_set_props(dc, pnv_i2c_properties);
-- 
2.44.0

Re: [PATCH v2] ppc/pnv: I2C controller is not user creatable

Posted by Miles Glenn 1 month, 1 week ago

On Mon, 2024-03-18 at 16:58 +0100, Cédric Le Goater wrote:

Thanks for fixing that!

-Glenn

Reviewed-by: Glenn Miles <milesg@linux.vnet.ibm.com>

> The I2C controller is a subunit of the processor. Make it so and
> avoid
> QEMU crashes.
> 
>   $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
>   qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize:
> Assertion `i2c->chip' failed.
>   Aborted (core dumped)
> 
> Fixes: 263b81ee15af ("ppc/pnv: Add an I2C controller model")
> Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>  hw/ppc/pnv_i2c.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c
> index
> 4581cc5e5d4645ab3e358d983a633e33a214c425..eec5047ce83f842108b53a6e2bd
> 9869a81f14ac1 100644
> --- a/hw/ppc/pnv_i2c.c
> +++ b/hw/ppc/pnv_i2c.c
> @@ -557,6 +557,9 @@ static void pnv_i2c_class_init(ObjectClass
> *klass, void *data)
> 
>      xscomc->dt_xscom = pnv_i2c_dt_xscom;
> 
> +    /* Reason: This device is part of the CPU and cannot be used
> separately */
> +    dc->user_creatable = false;
> +
>      dc->desc = "PowerNV I2C";
>      dc->realize = pnv_i2c_realize;
>      device_class_set_props(dc, pnv_i2c_properties);

Re: [PATCH v2] ppc/pnv: I2C controller is not user creatable

Posted by Philippe Mathieu-Daudé 1 month, 1 week ago

On 18/3/24 16:58, Cédric Le Goater wrote:
> The I2C controller is a subunit of the processor. Make it so and avoid
> QEMU crashes.
> 
>    $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
>    qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i2c->chip' failed.
>    Aborted (core dumped)
> 
> Fixes: 263b81ee15af ("ppc/pnv: Add an I2C controller model")
> Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/ppc/pnv_i2c.c | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>