[v2] qga/commands-posix: replace code duplicating commands with a helper

[PATCH v2 0/7] qga/commands-posix: replace code duplicating commands with a helper

Posted by Andrey Drobyshev 8 months, 4 weeks ago

v1 --> v2:
 * Replace commit for guest-get-fsinfo: instead of reporting statvfs(3)
   values directly, keep the old ones but add an additional optional
   field 'total-bytes-root', only reported in POSIX.  Also tweak the
   fields description in qga/qapi-schema.json to document where the
   values come from.

v1: https://lists.nongnu.org/archive/html/qemu-devel/2024-02/msg05766.html

Andrey Drobyshev (7):
  qga: guest-get-fsinfo: add optional 'total-bytes-root' field
  qga: introduce ga_run_command() helper for guest cmd execution
  qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper
  qga/commands-posix: qmp_guest_set_time: use ga_run_command helper
  qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper
  qga/commands-posix: use ga_run_command helper when suspending via
    sysfs
  qga/commands-posix: qmp_guest_set_user_password: use ga_run_command
    helper

 qga/commands-posix.c | 389 +++++++++++++++++++------------------------
 qga/commands-win32.c |   1 +
 qga/qapi-schema.json |  12 +-
 3 files changed, 182 insertions(+), 220 deletions(-)

-- 
2.39.3

Re: [PATCH v2 0/7] qga/commands-posix: replace code duplicating commands with a helper

Posted by Konstantin Kostiuk 8 months, 3 weeks ago

For series
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Fri, Mar 1, 2024 at 7:29 PM Andrey Drobyshev <
andrey.drobyshev@virtuozzo.com> wrote:

> v1 --> v2:
>  * Replace commit for guest-get-fsinfo: instead of reporting statvfs(3)
>    values directly, keep the old ones but add an additional optional
>    field 'total-bytes-root', only reported in POSIX.  Also tweak the
>    fields description in qga/qapi-schema.json to document where the
>    values come from.
>
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2024-02/msg05766.html
>
> Andrey Drobyshev (7):
>   qga: guest-get-fsinfo: add optional 'total-bytes-root' field
>   qga: introduce ga_run_command() helper for guest cmd execution
>   qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper
>   qga/commands-posix: qmp_guest_set_time: use ga_run_command helper
>   qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper
>   qga/commands-posix: use ga_run_command helper when suspending via
>     sysfs
>   qga/commands-posix: qmp_guest_set_user_password: use ga_run_command
>     helper
>
>  qga/commands-posix.c | 389 +++++++++++++++++++------------------------
>  qga/commands-win32.c |   1 +
>  qga/qapi-schema.json |  12 +-
>  3 files changed, 182 insertions(+), 220 deletions(-)
>
> --
> 2.39.3
>
>

Re: [PATCH v2 0/7] qga/commands-posix: replace code duplicating commands with a helper

Posted by Dehan Meng 8 months, 3 weeks ago

QE tested this series's patches. qga-related commands worked successfully.

Tested-by: Dehan Meng <demeng@redhat.com>


On Mon, Mar 4, 2024 at 8:00 PM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:

> For series
> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
>
> On Fri, Mar 1, 2024 at 7:29 PM Andrey Drobyshev <
> andrey.drobyshev@virtuozzo.com> wrote:
>
>> v1 --> v2:
>>  * Replace commit for guest-get-fsinfo: instead of reporting statvfs(3)
>>    values directly, keep the old ones but add an additional optional
>>    field 'total-bytes-root', only reported in POSIX.  Also tweak the
>>    fields description in qga/qapi-schema.json to document where the
>>    values come from.
>>
>> v1:
>> https://lists.nongnu.org/archive/html/qemu-devel/2024-02/msg05766.html
>>
>> Andrey Drobyshev (7):
>>   qga: guest-get-fsinfo: add optional 'total-bytes-root' field
>>   qga: introduce ga_run_command() helper for guest cmd execution
>>   qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper
>>   qga/commands-posix: qmp_guest_set_time: use ga_run_command helper
>>   qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper
>>   qga/commands-posix: use ga_run_command helper when suspending via
>>     sysfs
>>   qga/commands-posix: qmp_guest_set_user_password: use ga_run_command
>>     helper
>>
>>  qga/commands-posix.c | 389 +++++++++++++++++++------------------------
>>  qga/commands-win32.c |   1 +
>>  qga/qapi-schema.json |  12 +-
>>  3 files changed, 182 insertions(+), 220 deletions(-)
>>
>> --
>> 2.39.3
>>
>>