[v4] qga/commands-posix: replace code duplicating commands with a helper

[PATCH v4 0/7] qga/commands-posix: replace code duplicating commands with a helper

Andrey Drobyshev posted 7 patches 1 month, 1 week ago

Diff against v1 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240320161648.158226-1-andrey.drobyshev@virtuozzo.com

Maintainers: Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>

qga/commands-posix.c | 404 +++++++++++++++++++------------------------
qga/commands-win32.c |   1 +
qga/qapi-schema.json |   7 +-
3 files changed, 187 insertions(+), 225 deletions(-)

Expand all Fold all

[PATCH v4 0/7] qga/commands-posix: replace code duplicating commands with a helper

Posted by Andrey Drobyshev 1 month, 1 week ago

v3 -> v4:
  * Patch 1/7:
    - Replaced "since 8.3" with "since 9.0" as we're now at v9.0.0-rc0;
    - Renamed the field to 'total-bytes-privileged';
    - Got rid of the implementation details in the docs;
  * Patch 6/7: added g_autoptr macro to local error declaration.

v3: https://lists.nongnu.org/archive/html/qemu-devel/2024-03/msg04068.html

Andrey Drobyshev (7):
  qga: guest-get-fsinfo: add optional 'total-bytes-privileged' field
  qga: introduce ga_run_command() helper for guest cmd execution
  qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper
  qga/commands-posix: qmp_guest_set_time: use ga_run_command helper
  qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper
  qga/commands-posix: don't do fork()/exec() when suspending via sysfs
  qga/commands-posix: qmp_guest_set_user_password: use ga_run_command
    helper

 qga/commands-posix.c | 404 +++++++++++++++++++------------------------
 qga/commands-win32.c |   1 +
 qga/qapi-schema.json |   7 +-
 3 files changed, 187 insertions(+), 225 deletions(-)

-- 
2.39.3

Re: [PATCH v4 0/7] qga/commands-posix: replace code duplicating commands with a helper

Posted by Konstantin Kostiuk 5 days ago

To series:

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>


On Wed, Mar 20, 2024 at 6:17 PM Andrey Drobyshev <
andrey.drobyshev@virtuozzo.com> wrote:

> v3 -> v4:
>   * Patch 1/7:
>     - Replaced "since 8.3" with "since 9.0" as we're now at v9.0.0-rc0;
>     - Renamed the field to 'total-bytes-privileged';
>     - Got rid of the implementation details in the docs;
>   * Patch 6/7: added g_autoptr macro to local error declaration.
>
> v3: https://lists.nongnu.org/archive/html/qemu-devel/2024-03/msg04068.html
>
> Andrey Drobyshev (7):
>   qga: guest-get-fsinfo: add optional 'total-bytes-privileged' field
>   qga: introduce ga_run_command() helper for guest cmd execution
>   qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper
>   qga/commands-posix: qmp_guest_set_time: use ga_run_command helper
>   qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper
>   qga/commands-posix: don't do fork()/exec() when suspending via sysfs
>   qga/commands-posix: qmp_guest_set_user_password: use ga_run_command
>     helper
>
>  qga/commands-posix.c | 404 +++++++++++++++++++------------------------
>  qga/commands-win32.c |   1 +
>  qga/qapi-schema.json |   7 +-
>  3 files changed, 187 insertions(+), 225 deletions(-)
>
> --
> 2.39.3
>
>