[v5] Add support for I2C in BCM2835 boards

[PATCH v5 0/3] Add support for I2C in BCM2835 boards

Rayhan Faizel posted 3 patches 8 months, 3 weeks ago

Diff against v1 v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240224191038.2409945-1-rayhan.faizel@gmail.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>

docs/system/arm/raspi.rst            |   1 +
hw/arm/Kconfig                       |   1 +
hw/arm/bcm2835_peripherals.c         |  45 ++++-
hw/i2c/Kconfig                       |   4 +
hw/i2c/bcm2835_i2c.c                 | 282 +++++++++++++++++++++++++++
hw/i2c/meson.build                   |   1 +
include/hw/arm/bcm2835_peripherals.h |   4 +-
include/hw/i2c/bcm2835_i2c.h         |  80 ++++++++
tests/qtest/bcm2835-i2c-test.c       | 115 +++++++++++
tests/qtest/meson.build              |   2 +-
10 files changed, 530 insertions(+), 5 deletions(-)
create mode 100644 hw/i2c/bcm2835_i2c.c
create mode 100644 include/hw/i2c/bcm2835_i2c.h
create mode 100644 tests/qtest/bcm2835-i2c-test.c

Expand all Fold all

[PATCH v5 0/3] Add support for I2C in BCM2835 boards

Posted by Rayhan Faizel 8 months, 3 weeks ago

This patch series implements support for the Broadcom Serial Controller used
by BCM2835 based boards for I2C.

[Changes in v5]

- Improper whitespace again.

[Changes in v4]

- Added IRQ or-gate for common BSC IRQ.
- Added valid sizes to MemoryRegionOps.
- Use version tag instead of master

[Changes in v3]

- Add SPDX license identifiers.
- Fix a few minor whitespace issues.

[Changes in v2]

- Fixed and simplified writing to status register

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/481
Signed-off-by: Rayhan Faizel <rayhan.faizel@gmail.com>

Rayhan Faizel (3):
  hw/i2c: Implement Broadcom Serial Controller (BSC)
  hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
  tests/qtest: Add testcase for BCM2835 BSC

 docs/system/arm/raspi.rst            |   1 +
 hw/arm/Kconfig                       |   1 +
 hw/arm/bcm2835_peripherals.c         |  45 ++++-
 hw/i2c/Kconfig                       |   4 +
 hw/i2c/bcm2835_i2c.c                 | 282 +++++++++++++++++++++++++++
 hw/i2c/meson.build                   |   1 +
 include/hw/arm/bcm2835_peripherals.h |   4 +-
 include/hw/i2c/bcm2835_i2c.h         |  80 ++++++++
 tests/qtest/bcm2835-i2c-test.c       | 115 +++++++++++
 tests/qtest/meson.build              |   2 +-
 10 files changed, 530 insertions(+), 5 deletions(-)
 create mode 100644 hw/i2c/bcm2835_i2c.c
 create mode 100644 include/hw/i2c/bcm2835_i2c.h
 create mode 100644 tests/qtest/bcm2835-i2c-test.c

-- 
2.34.1

Re: [PATCH v5 0/3] Add support for I2C in BCM2835 boards

Posted by Peter Maydell 8 months, 1 week ago

On Sat, 24 Feb 2024 at 20:31, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
>
> This patch series implements support for the Broadcom Serial Controller used
> by BCM2835 based boards for I2C.
>
> [Changes in v5]
>
> - Improper whitespace again.
>
> [Changes in v4]
>
> - Added IRQ or-gate for common BSC IRQ.
> - Added valid sizes to MemoryRegionOps.
> - Use version tag instead of master
>
> [Changes in v3]
>
> - Add SPDX license identifiers.
> - Fix a few minor whitespace issues.
>
> [Changes in v2]
>
> - Fixed and simplified writing to status register
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/481
> Signed-off-by: Rayhan Faizel <rayhan.faizel@gmail.com>
>
> Rayhan Faizel (3):
>   hw/i2c: Implement Broadcom Serial Controller (BSC)
>   hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
>   tests/qtest: Add testcase for BCM2835 BSC



Applied to target-arm.next, thanks.

-- PMM