[RFC PATCH 00/11] target/mips: Remove I6500 CPU definition

Philippe Mathieu-Daudé posted 11 patches 2 weeks, 1 day ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240209090513.9401-1-philmd@linaro.org
Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Huacai Chen <chenhuacai@kernel.org>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
docs/about/removed-features.rst     |  5 +++
include/hw/misc/mips_itu.h          |  6 ---
target/mips/cpu.h                   |  4 --
target/mips/tcg/translate.h         |  1 -
target/mips/tcg/sysemu_helper.h.inc |  6 ---
hw/mips/cps.c                       |  3 --
hw/misc/mips_itu.c                  | 35 ++--------------
target/mips/sysemu/machine.c        |  4 +-
target/mips/tcg/sysemu/cp0_helper.c | 63 -----------------------------
target/mips/tcg/translate.c         | 62 ----------------------------
tests/qtest/machine-none-test.c     |  2 +-
target/mips/cpu-defs.c.inc          | 40 ------------------
12 files changed, 12 insertions(+), 219 deletions(-)
[RFC PATCH 00/11] target/mips: Remove I6500 CPU definition
Posted by Philippe Mathieu-Daudé 2 weeks, 1 day ago
Alternative to:
https://lore.kernel.org/qemu-devel/20240209085347.8446-1-philmd@linaro.org/
If the I6500 can not be tested or its support is incomplete,
there is no point in wasting energy maintaining it.

Philippe Mathieu-Daudé (11):
  target/mips: Remove helpers accessing SAAR registers
  hw/misc/mips: Reduce itc_reconfigure() scope
  target/mips: Remove MIPSITUState::itu field
  target/mips: Remove CPUMIPSState::saarp field
  hw/misc/mips_itu: Remove MIPSITUState::cpu0 field
  hw/misc/mips_itu: Remove MIPSITUState::saar field
  target/mips: Remove CPUMIPSState::CP0_SAAR[2] field
  target/mips: Remove helpers accessing SAARI register
  target/mips: Remove CPUMIPSState::CP0_SAARI field
  target/mips: Remove the unused DisasContext::saar field
  target/mips: Remove I6500 CPU definition

 docs/about/removed-features.rst     |  5 +++
 include/hw/misc/mips_itu.h          |  6 ---
 target/mips/cpu.h                   |  4 --
 target/mips/tcg/translate.h         |  1 -
 target/mips/tcg/sysemu_helper.h.inc |  6 ---
 hw/mips/cps.c                       |  3 --
 hw/misc/mips_itu.c                  | 35 ++--------------
 target/mips/sysemu/machine.c        |  4 +-
 target/mips/tcg/sysemu/cp0_helper.c | 63 -----------------------------
 target/mips/tcg/translate.c         | 62 ----------------------------
 tests/qtest/machine-none-test.c     |  2 +-
 target/mips/cpu-defs.c.inc          | 40 ------------------
 12 files changed, 12 insertions(+), 219 deletions(-)

-- 
2.41.0


Re: [RFC PATCH 00/11] target/mips: Remove I6500 CPU definition
Posted by Richard Henderson 1 week, 6 days ago
On 2/8/24 23:05, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (11):
>    target/mips: Remove helpers accessing SAAR registers
>    hw/misc/mips: Reduce itc_reconfigure() scope
>    target/mips: Remove MIPSITUState::itu field
>    target/mips: Remove CPUMIPSState::saarp field
>    hw/misc/mips_itu: Remove MIPSITUState::cpu0 field
>    hw/misc/mips_itu: Remove MIPSITUState::saar field
>    target/mips: Remove CPUMIPSState::CP0_SAAR[2] field
>    target/mips: Remove helpers accessing SAARI register
>    target/mips: Remove CPUMIPSState::CP0_SAARI field
>    target/mips: Remove the unused DisasContext::saar field
>    target/mips: Remove I6500 CPU definition

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [RFC PATCH 00/11] target/mips: Remove I6500 CPU definition
Posted by Jiaxun Yang 2 weeks, 1 day ago

在 2024/2/9 09:05, Philippe Mathieu-Daudé 写道:
> Alternative to:
> https://lore.kernel.org/qemu-devel/20240209085347.8446-1-philmd@linaro.org/
> If the I6500 can not be tested or its support is incomplete,
> there is no point in wasting energy maintaining it.

Actually all SAAR and ITU stuff are optional for I6500 in real world so 
it's fine
to just leave I6500 defined without SAAR support.

The main difference between I6400 and I6500 is multi-cluster support, I do
have some patch for bringing proper multi-cluster support to QEMU, but
it can't work with boston due to address space limitations.

Should I give mips-virt stuff another go?

Thanks
- Jiaxun

>
> Philippe Mathieu-Daudé (11):
>    target/mips: Remove helpers accessing SAAR registers
>    hw/misc/mips: Reduce itc_reconfigure() scope
>    target/mips: Remove MIPSITUState::itu field
>    target/mips: Remove CPUMIPSState::saarp field
>    hw/misc/mips_itu: Remove MIPSITUState::cpu0 field
>    hw/misc/mips_itu: Remove MIPSITUState::saar field
>    target/mips: Remove CPUMIPSState::CP0_SAAR[2] field
>    target/mips: Remove helpers accessing SAARI register
>    target/mips: Remove CPUMIPSState::CP0_SAARI field
>    target/mips: Remove the unused DisasContext::saar field
>    target/mips: Remove I6500 CPU definition
>
>   docs/about/removed-features.rst     |  5 +++
>   include/hw/misc/mips_itu.h          |  6 ---
>   target/mips/cpu.h                   |  4 --
>   target/mips/tcg/translate.h         |  1 -
>   target/mips/tcg/sysemu_helper.h.inc |  6 ---
>   hw/mips/cps.c                       |  3 --
>   hw/misc/mips_itu.c                  | 35 ++--------------
>   target/mips/sysemu/machine.c        |  4 +-
>   target/mips/tcg/sysemu/cp0_helper.c | 63 -----------------------------
>   target/mips/tcg/translate.c         | 62 ----------------------------
>   tests/qtest/machine-none-test.c     |  2 +-
>   target/mips/cpu-defs.c.inc          | 40 ------------------
>   12 files changed, 12 insertions(+), 219 deletions(-)
>

-- 
---
Jiaxun Yang


Re: [RFC PATCH 00/11] target/mips: Remove I6500 CPU definition
Posted by Philippe Mathieu-Daudé 1 week, 4 days ago
On 9/2/24 10:05, Philippe Mathieu-Daudé wrote:
> Alternative to:
> https://lore.kernel.org/qemu-devel/20240209085347.8446-1-philmd@linaro.org/
> If the I6500 can not be tested or its support is incomplete,
> there is no point in wasting energy maintaining it.
> 
> Philippe Mathieu-Daudé (11):
>    target/mips: Remove helpers accessing SAAR registers
>    hw/misc/mips: Reduce itc_reconfigure() scope
>    target/mips: Remove MIPSITUState::itu field
>    target/mips: Remove CPUMIPSState::saarp field
>    hw/misc/mips_itu: Remove MIPSITUState::cpu0 field
>    hw/misc/mips_itu: Remove MIPSITUState::saar field
>    target/mips: Remove CPUMIPSState::CP0_SAAR[2] field
>    target/mips: Remove helpers accessing SAARI register
>    target/mips: Remove CPUMIPSState::CP0_SAARI field
>    target/mips: Remove the unused DisasContext::saar field

Patches 1-10 queued (without removing the I6500 CPU).