On 08/02/2024 18:12, Philippe Mathieu-Daudé wrote:
> We should not wire IRQs on unrealized device.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/sparc/leon3.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
> index 2dfb742566..0df5fc949d 100644
> --- a/hw/sparc/leon3.c
> +++ b/hw/sparc/leon3.c
> @@ -263,10 +263,10 @@ static void leon3_generic_hw_init(MachineState *machine)
> irqmpdev = qdev_new(TYPE_GRLIB_IRQMP);
> qdev_init_gpio_in_named_with_opaque(DEVICE(cpu), leon3_set_pil_in,
> env, "pil", 1);
> - qdev_connect_gpio_out_named(irqmpdev, "grlib-irq", 0,
> - qdev_get_gpio_in_named(DEVICE(cpu), "pil", 0));
> sysbus_realize_and_unref(SYS_BUS_DEVICE(irqmpdev), &error_fatal);
> sysbus_mmio_map(SYS_BUS_DEVICE(irqmpdev), 0, LEON3_IRQMP_OFFSET);
> + qdev_connect_gpio_out_named(irqmpdev, "grlib-irq", 0,
> + qdev_get_gpio_in_named(DEVICE(cpu), "pil", 0));
> env->irq_manager = irqmpdev;
> env->qemu_irq_ack = leon3_irq_manager;
> grlib_apb_pnp_add_entry(apb_pnp, LEON3_IRQMP_OFFSET, 0xFFF,
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.