[v1] qemu-options.hx: document that tftp=dir is readonly

[PATCH trivial] qemu-options.hx: document that tftp=dir is readonly

Posted by Michael Tokarev 9 months, 3 weeks ago

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 qemu-options.hx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qemu-options.hx b/qemu-options.hx
index 5adbed1101..05f70231c9 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3100,6 +3100,8 @@ SRST
         server. The files in dir will be exposed as the root of a TFTP
         server. The TFTP client on the guest must be configured in
         binary mode (use the command ``bin`` of the Unix TFTP client).
+        The built-in TFTP server is read-only, qemu will not write to
+        this directory.
 
     ``tftp-server-name=name``
         In BOOTP reply, broadcast name as the "TFTP server name"
-- 
2.39.2

Re: [PATCH trivial] qemu-options.hx: document that tftp=dir is readonly

Posted by Peter Maydell 9 months, 3 weeks ago

On Thu, 8 Feb 2024 at 06:02, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  qemu-options.hx | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5adbed1101..05f70231c9 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -3100,6 +3100,8 @@ SRST
>          server. The files in dir will be exposed as the root of a TFTP
>          server. The TFTP client on the guest must be configured in
>          binary mode (use the command ``bin`` of the Unix TFTP client).
> +        The built-in TFTP server is read-only, qemu will not write to
> +        this directory.

We could expand this a little:
  The built-in TFTP server is read-only and does not implement
  any of the commands for writing files. QEMU will not write to
  this directory.

>
>      ``tftp-server-name=name``
>          In BOOTP reply, broadcast name as the "TFTP server name"
> --
> 2.39.2

thanks
-- PMM

Re: [PATCH trivial] qemu-options.hx: document that tftp=dir is readonly

Posted by Daniel P. Berrangé 9 months, 3 weeks ago

On Thu, Feb 08, 2024 at 09:02:28AM +0300, Michael Tokarev wrote:
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  qemu-options.hx | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|