[v2] qemu-options.hx: document that tftp=dir is readonly

[PATCH trivial v2] qemu-options.hx: document that tftp=dir is readonly

Michael Tokarev posted 1 patch 5 months, 2 weeks ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240208154038.553385-1-mjt@tls.msk.ru

Maintainers: Michael Tokarev <mjt@tls.msk.ru>, Laurent Vivier <laurent@vivier.eu>

qemu-options.hx | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH trivial v2] qemu-options.hx: document that tftp=dir is readonly

Posted by Michael Tokarev 5 months, 2 weeks ago


Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
v2: include suggestion by Peter.
   Not keeping Reviewed-by tags.

 qemu-options.hx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qemu-options.hx b/qemu-options.hx
index 5adbed1101..e7f07d8ccf 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3100,6 +3100,8 @@ SRST
         server. The files in dir will be exposed as the root of a TFTP
         server. The TFTP client on the guest must be configured in
         binary mode (use the command ``bin`` of the Unix TFTP client).
+        The built-in TFTP server is read-only, it does not implement any
+        command for writing files. QEMU will not write to this directory.
 
     ``tftp-server-name=name``
         In BOOTP reply, broadcast name as the "TFTP server name"
-- 
2.39.2

Re: [PATCH trivial v2] qemu-options.hx: document that tftp=dir is readonly

Posted by Peter Maydell 5 months, 2 weeks ago

On Thu, 8 Feb 2024 at 15:40, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1286
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> v2: include suggestion by Peter.
>    Not keeping Reviewed-by tags.
>
>  qemu-options.hx | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5adbed1101..e7f07d8ccf 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -3100,6 +3100,8 @@ SRST
>          server. The files in dir will be exposed as the root of a TFTP
>          server. The TFTP client on the guest must be configured in
>          binary mode (use the command ``bin`` of the Unix TFTP client).
> +        The built-in TFTP server is read-only, it does not implement any

semicolon, not comma.

> +        command for writing files. QEMU will not write to this directory.

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM