[v1] dump: Fix issues flagged by Coverity

[PATCH 0/2] dump: Fix issues flagged by Coverity

Markus Armbruster posted 2 patches 1 year ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231108053731.112043-1-armbru@redhat.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>

There is a newer version of this series

dump/dump-hmp-cmds.c | 2 +-
dump/dump.c          | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH 0/2] dump: Fix issues flagged by Coverity

Posted by Markus Armbruster 1 year ago

Markus Armbruster (2):
  dump: Plug file descriptor leak on non-seekable file
  dump: Fix HMP dump-guest-memory -z without -R

 dump/dump-hmp-cmds.c | 2 +-
 dump/dump.c          | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.41.0

Re: [PATCH 0/2] dump: Fix issues flagged by Coverity

Posted by Stephen Brennan 1 year ago

Markus Armbruster <armbru@redhat.com> writes:
> Markus Armbruster (2):
>   dump: Plug file descriptor leak on non-seekable file
>   dump: Fix HMP dump-guest-memory -z without -R

Hi Markus,

I'm a bit late on the uptake here as these are already queued, but thank
you so much for finding and fixing my issues. Sorry for the extra work.

Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>

Re: [PATCH 0/2] dump: Fix issues flagged by Coverity

Posted by Markus Armbruster 1 year ago

Stephen Brennan <stephen.s.brennan@oracle.com> writes:

> Markus Armbruster <armbru@redhat.com> writes:
>> Markus Armbruster (2):
>>   dump: Plug file descriptor leak on non-seekable file
>>   dump: Fix HMP dump-guest-memory -z without -R
>
> Hi Markus,
>
> I'm a bit late on the uptake here as these are already queued, but thank
> you so much for finding and fixing my issues. Sorry for the extra work.

Happens :)

> Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>

Thanks!