From nobody Wed Nov 27 09:45:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699421928; cv=none; d=zohomail.com; s=zohoarc; b=GxfkqTfoteotKlzOELc0KOjLYm5N6bbyuaM6p+7x62soyByi9PH3Ov2scTJWJIgZ76RIvMOV5TTQuTZKcdebKF0bVrFq70qDQxjcGdYCOga7DemQIbkL3Kv/AB9LaoICN7a9/2FtTo4IYdSDfakcXW2iW7vpkNdgk3zcp0Kfs3A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699421928; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ma7sJgMajcUHrBURFDSFfTUzDQODc8FTm2dLMKIT5nM=; b=V5lScor/wRQ/hxer3pWeKR0FCjNNc3oggxP65Bu2w5bLsYsoEhdFpguAI35Vdokh2B1wuyv6F459A6D0l/2tQsvqY8jOSUSC88N7G+b7LqEe3+j179N44FPpAt6HABWGHMGP8hybP+WP2bHA3JixKatzhlpLvpjx0zHGtGc0gH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699421928734449.7174601898581; Tue, 7 Nov 2023 21:38:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0bG2-0003eQ-7c; Wed, 08 Nov 2023 00:37:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0bG0-0003eE-KZ for qemu-devel@nongnu.org; Wed, 08 Nov 2023 00:37:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0bFy-0004J2-01 for qemu-devel@nongnu.org; Wed, 08 Nov 2023 00:37:40 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-KiKnbdnCM2KMqMTODK-s0g-1; Wed, 08 Nov 2023 00:37:32 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E21C1C294A3; Wed, 8 Nov 2023 05:37:32 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DAD9502A; Wed, 8 Nov 2023 05:37:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 161B421E6A26; Wed, 8 Nov 2023 06:37:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699421856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ma7sJgMajcUHrBURFDSFfTUzDQODc8FTm2dLMKIT5nM=; b=D5HY47wt2djmy32UdolzMayt9xx98/XLOmpD3S0JEQ9ye5CFNxbWG9D1kNL0KicS2XICwc 94kM1GxnBu0dQBed3pO0yszdSE3EpW0fmhH985J/4Ov4Kc4BaeCIA/sSgnS9dB7uhr9gf0 mWYfHIzZt/2O83kCnmz2HDVQgp4h+7I= X-MC-Unique: KiKnbdnCM2KMqMTODK-s0g-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stephen.s.brennan@oracle.com, marcandre.lureau@redhat.com, berrange@redhat.com Subject: [PATCH 1/2] dump: Plug file descriptor leak on non-seekable file Date: Wed, 8 Nov 2023 06:37:30 +0100 Message-ID: <20231108053731.112043-2-armbru@redhat.com> In-Reply-To: <20231108053731.112043-1-armbru@redhat.com> References: <20231108053731.112043-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699421929642100002 Content-Type: text/plain; charset="utf-8" Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats) Fixes: CID 1523842 Signed-off-by: Markus Armbruster Reviewed-by: Stephen Brennan --- dump/dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dump/dump.c b/dump/dump.c index 1c304cadfd..ad5294e853 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -2160,6 +2160,7 @@ void qmp_dump_guest_memory(bool paging, const char *p= rotocol, return; } if (kdump_raw && lseek(fd, 0, SEEK_CUR) =3D=3D (off_t) -1) { + close(fd); error_setg(errp, "kdump-raw formats require a seekable file"); return; } --=20 2.41.0 From nobody Wed Nov 27 09:45:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699421909; cv=none; d=zohomail.com; s=zohoarc; b=hickKq1xbSwdul6pVYd20nt6nORKrzP2BBmC0nDfVKwvBDbSNnT10DprSMlLytpX0T33i/9dZkPEqR4vSeU/kE8JUV/Nn9SYerSW3GudnucNQnHsPCzIMapKLgftyb2p1XZuPZWbgaJFK+1A/KcWRmx0DxILmVV5OOh085YeZlY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699421909; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/vMzrrk6DjAH++GRcwkybchFQgT9uHeR63ZD5WMLvEc=; b=EPduyli1z5HtHLQOKR+FGJ7xoaE4aGrzQnBgZj2Z3R5FCcclGPBAcol1W/CsAw047ep/6adnthdRam4AJf/dqXxAIan5bN5woyvxJHwHAWuiRumY2MgIGPpUpOMW5CE1p3AoIpZmirGYOIBBgc+W+x+WJY0XTNieEqD2yEpKaFw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699421909167124.06992484978275; Tue, 7 Nov 2023 21:38:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0bG1-0003eN-LG; Wed, 08 Nov 2023 00:37:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0bFz-0003dx-DN for qemu-devel@nongnu.org; Wed, 08 Nov 2023 00:37:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0bFw-0004Iy-SG for qemu-devel@nongnu.org; Wed, 08 Nov 2023 00:37:39 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-85-hv87ejKzNaGmTQU0FMsjhQ-1; Wed, 08 Nov 2023 00:37:32 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E056185A784; Wed, 8 Nov 2023 05:37:32 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3AD6D492BFA; Wed, 8 Nov 2023 05:37:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1A14E21E6A28; Wed, 8 Nov 2023 06:37:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699421855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/vMzrrk6DjAH++GRcwkybchFQgT9uHeR63ZD5WMLvEc=; b=NmfTyGQEGBWrZPWevnrk9vARK4Rl0umEvStppzS4Bgef8ntwAxIddGoe7A7BxTyFXFxvO7 EE+TIlgCDa5W7NR+lLt4Hh2SYvnnSQiMhdwsDUXc/0iQaWiRDJ7TX1uUNI0Z0c06mfBwQd u9ofj8NtUbnGkUIgWRhufK6NGcgHxOQ= X-MC-Unique: hv87ejKzNaGmTQU0FMsjhQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stephen.s.brennan@oracle.com, marcandre.lureau@redhat.com, berrange@redhat.com Subject: [PATCH 2/2] dump: Fix HMP dump-guest-memory -z without -R Date: Wed, 8 Nov 2023 06:37:31 +0100 Message-ID: <20231108053731.112043-3-armbru@redhat.com> In-Reply-To: <20231108053731.112043-1-armbru@redhat.com> References: <20231108053731.112043-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699421911632100006 Content-Type: text/plain; charset="utf-8" -z without -R has no effect: the dump format remains @elf. Fix the logic error so it becomes @kdump-zlib. Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats) Fixes: CID 1523841 Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stephen Brennan --- dump/dump-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cmds.c index b428ec33df..d9340427c3 100644 --- a/dump/dump-hmp-cmds.c +++ b/dump/dump-hmp-cmds.c @@ -41,7 +41,7 @@ void hmp_dump_guest_memory(Monitor *mon, const QDict *qdi= ct) dump_format =3D DUMP_GUEST_MEMORY_FORMAT_WIN_DMP; } =20 - if (zlib && raw) { + if (zlib) { if (raw) { dump_format =3D DUMP_GUEST_MEMORY_FORMAT_KDUMP_RAW_ZLIB; } else { --=20 2.41.0