[v2] Follow VirtIO initialization properly at vdpa net cvq isolation probing

[PATCH v2 0/3] Follow VirtIO initialization properly at vdpa net cvq isolation probing

Eugenio Pérez posted 3 patches 1 year, 2 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230915170836.3078172-1-eperezma@redhat.com

Maintainers: Jason Wang <jasowang@redhat.com>

net/vhost-vdpa.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH v2 0/3] Follow VirtIO initialization properly at vdpa net cvq isolation probing

Posted by Eugenio Pérez 1 year, 2 months ago

This series solves a few issues.  The most obvious is that the feature set was
done previous to ACKNOWLEDGE | DRIVER status bit set.  Current vdpa devices are
permissive with this, but it is better to follow the standard.

Apart from that it fixes two issues reported by Peter Maydell:
* Stop probing CVQ isolation if cannot set features (goto missed).
* Fix incorrect error message statis "error setting features", while it should
say status.

v2: add forgotten Fixes tag

Eugenio Pérez (3):
  vdpa net: fix error message setting virtio status
  vdpa net: stop probing if cannot set features
  vdpa net: follow VirtIO initialization properly at cvq isolation
    probing

 net/vhost-vdpa.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

-- 
2.39.3

Re: [PATCH v2 0/3] Follow VirtIO initialization properly at vdpa net cvq isolation probing

Posted by Lei Yang 1 year, 2 months ago

QE tested this series with regression testing, everything works fine.

Tested-by: Lei Yang <leiyang@redhat.com>

On Sat, Sep 16, 2023 at 1:08 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> This series solves a few issues.  The most obvious is that the feature set was
> done previous to ACKNOWLEDGE | DRIVER status bit set.  Current vdpa devices are
> permissive with this, but it is better to follow the standard.
>
> Apart from that it fixes two issues reported by Peter Maydell:
> * Stop probing CVQ isolation if cannot set features (goto missed).
> * Fix incorrect error message statis "error setting features", while it should
> say status.
>
> v2: add forgotten Fixes tag
>
> Eugenio Pérez (3):
>   vdpa net: fix error message setting virtio status
>   vdpa net: stop probing if cannot set features
>   vdpa net: follow VirtIO initialization properly at cvq isolation
>     probing
>
>  net/vhost-vdpa.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>
> --
> 2.39.3
>
>