[PATCH v2 2/3] vdpa net: stop probing if cannot set features

Eugenio Pérez posted 3 patches 10 months, 1 week ago
Maintainers: Jason Wang <jasowang@redhat.com>
[PATCH v2 2/3] vdpa net: stop probing if cannot set features
Posted by Eugenio Pérez 10 months, 1 week ago
Otherwise it continues the CVQ isolation probing.

Fixes: 152128d646 ("vdpa: move CVQ isolation check to net_init_vhost_vdpa")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 net/vhost-vdpa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 9845e2db9c..51d8144070 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -1289,6 +1289,7 @@ static int vhost_vdpa_probe_cvq_isolation(int device_fd, uint64_t features,
     r = ioctl(device_fd, VHOST_SET_FEATURES, &features);
     if (unlikely(r)) {
         error_setg_errno(errp, errno, "Cannot set features");
+        goto out;
     }
 
     r = ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status);
-- 
2.39.3


Re: [PATCH v2 2/3] vdpa net: stop probing if cannot set features
Posted by Philippe Mathieu-Daudé 10 months, 1 week ago
On 15/9/23 19:08, Eugenio Pérez wrote:
> Otherwise it continues the CVQ isolation probing.
> 
> Fixes: 152128d646 ("vdpa: move CVQ isolation check to net_init_vhost_vdpa")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
>   net/vhost-vdpa.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>