[v1] Refactor PPI logic/definitions for virt/sbsa-ref

[PATCH v1 0/3] Refactor PPI logic/definitions for virt/sbsa-ref

Leif Lindholm posted 3 patches 7 months, 3 weeks ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230915115535.129834-1-quic._5Fllindhol@quicinc.com

Maintainers: Radoslaw Biernacki <rad@semihalf.com>, Peter Maydell <peter.maydell@linaro.org>, Leif Lindholm <quic_llindhol@quicinc.com>, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>, Shannon Zhao <shannon.zhaosl@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>

There is a newer version of this series

hw/arm/sbsa-ref.c        | 23 +++++++++++------------
hw/arm/virt-acpi-build.c |  4 ++--
hw/arm/virt.c            |  9 +++++----
include/hw/arm/bsa.h     | 35 +++++++++++++++++++++++++++++++++++
include/hw/arm/virt.h    | 12 +-----------
5 files changed, 54 insertions(+), 29 deletions(-)
create mode 100644 include/hw/arm/bsa.h

Expand all Fold all

[PATCH v1 0/3] Refactor PPI logic/definitions for virt/sbsa-ref

Posted by Leif Lindholm 7 months, 3 weeks ago

This set reworks the handling of private peripheral interrupts in virt
to use INTIDs instead of PPI IDs, to make it easier to cross reference
against Arm's Base System Architecture specification.

It then breaks those definitions out into a separate header and switches
sbsa-ref to use the same header instead of defining its own values
locally.

Changes since RFC:
- Compilation tested
- Reordered patches 1-2 as suggested by Philippe.

Leif Lindholm (3):
  {include/}hw/arm: refactor virt PPI logic
  include/hw/arm: move BSA definitions to bsa.h
  hw/arm/sbsa-ref: use bsa.h for PPI definitions

 hw/arm/sbsa-ref.c        | 23 +++++++++++------------
 hw/arm/virt-acpi-build.c |  4 ++--
 hw/arm/virt.c            |  9 +++++----
 include/hw/arm/bsa.h     | 35 +++++++++++++++++++++++++++++++++++
 include/hw/arm/virt.h    | 12 +-----------
 5 files changed, 54 insertions(+), 29 deletions(-)
 create mode 100644 include/hw/arm/bsa.h

-- 
2.30.2

Re: [PATCH v1 0/3] Refactor PPI logic/definitions for virt/sbsa-ref

Posted by Marcin Juszkiewicz 7 months, 3 weeks ago

W dniu 15.09.2023 o 13:55, Leif Lindholm pisze:
> This set reworks the handling of private peripheral interrupts in virt
> to use INTIDs instead of PPI IDs, to make it easier to cross reference
> against Arm's Base System Architecture specification.
> 
> It then breaks those definitions out into a separate header and switches
> sbsa-ref to use the same header instead of defining its own values
> locally.
> 
> Changes since RFC:
> - Compilation tested
> - Reordered patches 1-2 as suggested by Philippe.
> 
> Leif Lindholm (3):
>    {include/}hw/arm: refactor virt PPI logic
>    include/hw/arm: move BSA definitions to bsa.h
>    hw/arm/sbsa-ref: use bsa.h for PPI definitions
> 
>   hw/arm/sbsa-ref.c        | 23 +++++++++++------------
>   hw/arm/virt-acpi-build.c |  4 ++--
>   hw/arm/virt.c            |  9 +++++----
>   include/hw/arm/bsa.h     | 35 +++++++++++++++++++++++++++++++++++
>   include/hw/arm/virt.h    | 12 +-----------
>   5 files changed, 54 insertions(+), 29 deletions(-)
>   create mode 100644 include/hw/arm/bsa.h
> 

Tested-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>