[v1] dbus: Properly dispose touch/mouse dbus objects

[PATCH] dbus: Properly dispose touch/mouse dbus objects

Posted by Bilal Elmoussaoui 8 months ago

---
 ui/dbus-console.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ui/dbus-console.c b/ui/dbus-console.c
index e19774f985..36f7349585 100644
--- a/ui/dbus-console.c
+++ b/ui/dbus-console.c
@@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
     DBusDisplayConsole *ddc = DBUS_DISPLAY_CONSOLE(object);
 
     unregister_displaychangelistener(&ddc->dcl);
+    g_clear_object(&ddc->iface_touch);
+    g_clear_object(&ddc->iface_mouse);
     g_clear_object(&ddc->iface_kbd);
     g_clear_object(&ddc->iface);
     g_clear_pointer(&ddc->listeners, g_hash_table_unref);
-- 
2.41.0

Re: [PATCH] dbus: Properly dispose touch/mouse dbus objects

Posted by Philippe Mathieu-Daudé 8 months ago

Hi Bilal,

Fixes: 142ca628a7 ("ui: add a D-Bus display backend")
Fixes: de9f844ce2 ("ui/dbus: Expose a touch device interface")

See 
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line

   Your patches must include a Signed-off-by: line. This is a
   hard requirement because it’s how you say “I’m legally okay
   to contribute this and happy for it to go into QEMU”.

On 1/9/23 12:30, Bilal Elmoussaoui wrote:
> ---
>   ui/dbus-console.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ui/dbus-console.c b/ui/dbus-console.c
> index e19774f985..36f7349585 100644
> --- a/ui/dbus-console.c
> +++ b/ui/dbus-console.c
> @@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
>       DBusDisplayConsole *ddc = DBUS_DISPLAY_CONSOLE(object);
>   
>       unregister_displaychangelistener(&ddc->dcl);
> +    g_clear_object(&ddc->iface_touch);
> +    g_clear_object(&ddc->iface_mouse);
>       g_clear_object(&ddc->iface_kbd);
>       g_clear_object(&ddc->iface);
>       g_clear_pointer(&ddc->listeners, g_hash_table_unref);

Re: [PATCH] dbus: Properly dispose touch/mouse dbus objects

Posted by Bilal Elmoussaoui 8 months ago

Hi Philippe,

Sorry, I forgot that again. Sent a v2

On Fri, Sep 1, 2023 at 12:48 PM Philippe Mathieu-Daudé <philmd@linaro.org>
wrote:

> Hi Bilal,
>
> Fixes: 142ca628a7 ("ui: add a D-Bus display backend")
> Fixes: de9f844ce2 ("ui/dbus: Expose a touch device interface")
>
> See
>
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line
>
>    Your patches must include a Signed-off-by: line. This is a
>    hard requirement because it’s how you say “I’m legally okay
>    to contribute this and happy for it to go into QEMU”.
>
> On 1/9/23 12:30, Bilal Elmoussaoui wrote:
> > ---
> >   ui/dbus-console.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/ui/dbus-console.c b/ui/dbus-console.c
> > index e19774f985..36f7349585 100644
> > --- a/ui/dbus-console.c
> > +++ b/ui/dbus-console.c
> > @@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
> >       DBusDisplayConsole *ddc = DBUS_DISPLAY_CONSOLE(object);
> >
> >       unregister_displaychangelistener(&ddc->dcl);
> > +    g_clear_object(&ddc->iface_touch);
> > +    g_clear_object(&ddc->iface_mouse);
> >       g_clear_object(&ddc->iface_kbd);
> >       g_clear_object(&ddc->iface);
> >       g_clear_pointer(&ddc->listeners, g_hash_table_unref);
>
>