[v2] dbus: Properly dispose touch/mouse dbus objects

[PATCH v2] dbus: Properly dispose touch/mouse dbus objects

Bilal Elmoussaoui posted 1 patch 8 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230901124507.94087-1-belmouss@redhat.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

ui/dbus-console.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH v2] dbus: Properly dispose touch/mouse dbus objects

Posted by Bilal Elmoussaoui 8 months ago

Signed-off-by: Bilal Elmoussaoui <belmouss@redhat.com>
---
 ui/dbus-console.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ui/dbus-console.c b/ui/dbus-console.c
index e19774f985..36f7349585 100644
--- a/ui/dbus-console.c
+++ b/ui/dbus-console.c
@@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
     DBusDisplayConsole *ddc = DBUS_DISPLAY_CONSOLE(object);
 
     unregister_displaychangelistener(&ddc->dcl);
+    g_clear_object(&ddc->iface_touch);
+    g_clear_object(&ddc->iface_mouse);
     g_clear_object(&ddc->iface_kbd);
     g_clear_object(&ddc->iface);
     g_clear_pointer(&ddc->listeners, g_hash_table_unref);
-- 
2.41.0

Re: [PATCH v2] dbus: Properly dispose touch/mouse dbus objects

Posted by Philippe Mathieu-Daudé 8 months ago

On 1/9/23 14:45, Bilal Elmoussaoui wrote:

Fixes: 142ca628a7 ("ui: add a D-Bus display backend")
Fixes: de9f844ce2 ("ui/dbus: Expose a touch device interface")

> Signed-off-by: Bilal Elmoussaoui <belmouss@redhat.com>
> ---
>   ui/dbus-console.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ui/dbus-console.c b/ui/dbus-console.c
> index e19774f985..36f7349585 100644
> --- a/ui/dbus-console.c
> +++ b/ui/dbus-console.c
> @@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
>       DBusDisplayConsole *ddc = DBUS_DISPLAY_CONSOLE(object);
>   
>       unregister_displaychangelistener(&ddc->dcl);
> +    g_clear_object(&ddc->iface_touch);
> +    g_clear_object(&ddc->iface_mouse);
>       g_clear_object(&ddc->iface_kbd);
>       g_clear_object(&ddc->iface);
>       g_clear_pointer(&ddc->listeners, g_hash_table_unref);