[v2] ppc/pnv: Set P10 core xscom region size to match hardware

[PATCH v2 0/2] ppc/pnv: Set P10 core xscom region size to match hardware

Posted by Nicholas Piggin 9 months, 3 weeks ago

Sorry about the paper bag bug in the first version of the patch -
I broke powernv8 and 9.

This adds a xsom_size core class field to change the P10 size without
changing the others.

Also added a P10 xscom test, and passes make check.

Thanks,
Nick

Nicholas Piggin (2):
  ppc/pnv: Set P10 core xscom region size to match hardware
  tests/qtest: Add xscom tests for powernv10 machine

 hw/ppc/pnv_core.c            |  6 +++--
 include/hw/ppc/pnv_core.h    |  1 +
 include/hw/ppc/pnv_xscom.h   |  2 +-
 tests/qtest/pnv-xscom-test.c | 44 ++++++++++++++++++++++++++++--------
 4 files changed, 41 insertions(+), 12 deletions(-)

-- 
2.40.1

Re: [PATCH v2 0/2] ppc/pnv: Set P10 core xscom region size to match hardware

Posted by Daniel Henrique Barboza 9 months, 3 weeks ago

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,


Daniel

On 7/6/23 02:39, Nicholas Piggin wrote:
> Sorry about the paper bag bug in the first version of the patch -
> I broke powernv8 and 9.
> 
> This adds a xsom_size core class field to change the P10 size without
> changing the others.
> 
> Also added a P10 xscom test, and passes make check.
> 
> Thanks,
> Nick
> 
> Nicholas Piggin (2):
>    ppc/pnv: Set P10 core xscom region size to match hardware
>    tests/qtest: Add xscom tests for powernv10 machine
> 
>   hw/ppc/pnv_core.c            |  6 +++--
>   include/hw/ppc/pnv_core.h    |  1 +
>   include/hw/ppc/pnv_xscom.h   |  2 +-
>   tests/qtest/pnv-xscom-test.c | 44 ++++++++++++++++++++++++++++--------
>   4 files changed, 41 insertions(+), 12 deletions(-)
>

Re: [PATCH v2 0/2] ppc/pnv: Set P10 core xscom region size to match hardware

Posted by Cédric Le Goater 9 months, 3 weeks ago

On 7/6/23 07:39, Nicholas Piggin wrote:
> Sorry about the paper bag bug in the first version of the patch -
> I broke powernv8 and 9.
> 
> This adds a xsom_size core class field to change the P10 size without
> changing the others.
> 
> Also added a P10 xscom test, and passes make check.


Reviewed-by: Cédric Le Goater <clg@kaod.org>
Tested-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> 
> Thanks,
> Nick
> 
> Nicholas Piggin (2):
>    ppc/pnv: Set P10 core xscom region size to match hardware
>    tests/qtest: Add xscom tests for powernv10 machine
> 
>   hw/ppc/pnv_core.c            |  6 +++--
>   include/hw/ppc/pnv_core.h    |  1 +
>   include/hw/ppc/pnv_xscom.h   |  2 +-
>   tests/qtest/pnv-xscom-test.c | 44 ++++++++++++++++++++++++++++--------
>   4 files changed, 41 insertions(+), 12 deletions(-)
>

Re: [PATCH v2 0/2] ppc/pnv: Set P10 core xscom region size to match hardware

Posted by Cédric Le Goater 9 months, 3 weeks ago

On 7/6/23 07:39, Nicholas Piggin wrote:
> Sorry about the paper bag bug in the first version of the patch -
> I broke powernv8 and 9.
> 
> This adds a xsom_size core class field to change the P10 size without
> changing the others.
> 
> Also added a P10 xscom test, and passes make check.

Now, you know there is check-qtest-ppc64 :) XSCOM is important for
the machine to boot and I wish there were a few more low level tests.
XIVE for instance, to test IPIs.

Thanks,

C.


> Thanks,
> Nick
> 
> Nicholas Piggin (2):
>    ppc/pnv: Set P10 core xscom region size to match hardware
>    tests/qtest: Add xscom tests for powernv10 machine
> 
>   hw/ppc/pnv_core.c            |  6 +++--
>   include/hw/ppc/pnv_core.h    |  1 +
>   include/hw/ppc/pnv_xscom.h   |  2 +-
>   tests/qtest/pnv-xscom-test.c | 44 ++++++++++++++++++++++++++++--------
>   4 files changed, 41 insertions(+), 12 deletions(-)
>