hw/i386/amd_iommu: Orphanize & QDev cleanups

[PATCH 0/6] hw/i386/amd_iommu: Orphanize & QDev cleanups

Philippe Mathieu-Daudé posted 6 patches 1 year, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230313153031.86107-1-philmd@linaro.org

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

MAINTAINERS          |  4 +++
hw/i386/acpi-build.c |  6 ++--
hw/i386/amd_iommu.c  | 74 +++++++++++++++++++++++++-------------------
hw/i386/amd_iommu.h  |  9 +++---
4 files changed, 54 insertions(+), 39 deletions(-)

Expand all Fold all

[PATCH 0/6] hw/i386/amd_iommu: Orphanize & QDev cleanups

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

Following [*]:

  "Last time I tried AMD vIOMMU it didn't even boot."

mark amd_iommu as orphan in preparation of deprecating it
(or should we do that directly?).

Extract the PCI realize() code from sysbus one in order to
remove the single case of calling pci_add_capability() and
msi_init() on a *realized* QDev instance (in order to
strengthen the PCI/MSI APIs in a follow up series).

[*] https://lore.kernel.org/qemu-devel/CACGkMEtjmpX8G9HYZ0r3n5ErhAENKhQ81f4ocfCYrh=XoF=5hw@mail.gmail.com/

Philippe Mathieu-Daudé (6):
  MAINTAINERS: Mark AMD-Vi emulation as orphan
  hw/i386/amd_iommu: Explicit use of AMDVI_BASE_ADDR in amdvi_init
  hw/i386/amd_iommu: Remove intermediate AMDVIState::devid field
  hw/i386/amd_iommu: Move capab_offset from AMDVIState to AMDVIPCIState
  hw/i386/amd_iommu: Set PCI static/const fields via PCIDeviceClass
  hw/i386/amd_iommu: Factor amdvi_pci_realize out of
    amdvi_sysbus_realize

 MAINTAINERS          |  4 +++
 hw/i386/acpi-build.c |  6 ++--
 hw/i386/amd_iommu.c  | 74 +++++++++++++++++++++++++-------------------
 hw/i386/amd_iommu.h  |  9 +++---
 4 files changed, 54 insertions(+), 39 deletions(-)

-- 
2.38.1

Re: [PATCH 0/6] hw/i386/amd_iommu: Orphanize & QDev cleanups

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

I forgot to Cc Jason!

On 13/3/23 16:30, Philippe Mathieu-Daudé wrote:
> Following [*]:
> 
>    "Last time I tried AMD vIOMMU it didn't even boot."
> 
> mark amd_iommu as orphan in preparation of deprecating it
> (or should we do that directly?).
> 
> Extract the PCI realize() code from sysbus one in order to
> remove the single case of calling pci_add_capability() and
> msi_init() on a *realized* QDev instance (in order to
> strengthen the PCI/MSI APIs in a follow up series).
> 
> [*] https://lore.kernel.org/qemu-devel/CACGkMEtjmpX8G9HYZ0r3n5ErhAENKhQ81f4ocfCYrh=XoF=5hw@mail.gmail.com/
> 
> Philippe Mathieu-Daudé (6):
>    MAINTAINERS: Mark AMD-Vi emulation as orphan
>    hw/i386/amd_iommu: Explicit use of AMDVI_BASE_ADDR in amdvi_init
>    hw/i386/amd_iommu: Remove intermediate AMDVIState::devid field
>    hw/i386/amd_iommu: Move capab_offset from AMDVIState to AMDVIPCIState
>    hw/i386/amd_iommu: Set PCI static/const fields via PCIDeviceClass
>    hw/i386/amd_iommu: Factor amdvi_pci_realize out of
>      amdvi_sysbus_realize