[v6] dump: Add arch section and s390x PV dump

[PATCH v6 04/10] dump: Reintroduce memory_offset and section_offset

Posted by Janosch Frank 3 years, 3 months ago

section_offset will later be used to store the offset to the section
data which will be stored last. For now memory_offset is only needed
to make section_offset look nicer.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 dump/dump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dump/dump.c b/dump/dump.c
index b168a25321..626f7b2fd0 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -1876,6 +1876,8 @@ static void dump_init(DumpState *s, int fd, bool has_format,
         s->phdr_offset = s->shdr_offset + sizeof(Elf32_Shdr) * s->shdr_num;
         s->note_offset = s->phdr_offset + sizeof(Elf32_Phdr) * s->phdr_num;
     }
+    s->memory_offset = s->note_offset + s->note_size;
+    s->section_offset = s->memory_offset + s->total_size;
 
     return;
 
-- 
2.34.1

Re: [PATCH v6 04/10] dump: Reintroduce memory_offset and section_offset

Posted by Marc-André Lureau 3 years, 3 months ago

On Mon, Oct 17, 2022 at 12:39 PM Janosch Frank <frankja@linux.ibm.com>
wrote:

> section_offset will later be used to store the offset to the section
> data which will be stored last. For now memory_offset is only needed
> to make section_offset look nicer.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>



> ---
>  dump/dump.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/dump/dump.c b/dump/dump.c
> index b168a25321..626f7b2fd0 100644
> --- a/dump/dump.c
> +++ b/dump/dump.c
> @@ -1876,6 +1876,8 @@ static void dump_init(DumpState *s, int fd, bool
> has_format,
>          s->phdr_offset = s->shdr_offset + sizeof(Elf32_Shdr) *
> s->shdr_num;
>          s->note_offset = s->phdr_offset + sizeof(Elf32_Phdr) *
> s->phdr_num;
>      }
> +    s->memory_offset = s->note_offset + s->note_size;
> +    s->section_offset = s->memory_offset + s->total_size;
>
>      return;
>
> --
> 2.34.1
>
>