[PATCH v6 00/10] dump: Add arch section and s390x PV dump

Janosch Frank posted 10 patches 1 year, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221017083822.43118-1-frankja@linux.ibm.com
Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>
dump/dump.c                  | 290 +++++++++++++++++++++++++++--------
hw/s390x/pv.c                | 112 ++++++++++++++
hw/s390x/s390-virtio-ccw.c   |   6 +
include/elf.h                |   2 +
include/hw/s390x/pv.h        |  19 +++
include/sysemu/dump-arch.h   |   3 +
include/sysemu/dump.h        |  26 +++-
target/s390x/arch_dump.c     | 262 +++++++++++++++++++++++++++----
target/s390x/kvm/kvm.c       |   7 +
target/s390x/kvm/kvm_s390x.h |   1 +
10 files changed, 629 insertions(+), 99 deletions(-)
[PATCH v6 00/10] dump: Add arch section and s390x PV dump
Posted by Janosch Frank 1 year, 6 months ago
Previously this series was two separate series:
 * Arch section support
   Adds the possibility for arch code to add custom section data.

 * s390 PV dump support
   Adds PV dump data to the custom arch sections.

I've chosen to merge them so it's easier to understand why the arch
section support has been implement the way it is.

Additionally I've added cleanup patches beforehand which clean up the
GuestPhysBlock usage.

v6:
	* Rebase after parts of the series have been pulled
	* Put the section header move into its own patch
	* Added freeing of s->elf_section_hdrs
	* Added missing false fields in the note arrays in arch_dump.c

v5:
	* Added a patch that moves the DumpState typedef and replaces
          the opaque pointers with properly typed ones
	* Removed the ELF header allocation since the codes has
          changed in a way that it's not needed anymore
	* Changed naming of dump_get_memblock_*() to dump_filter_memblock_*()
	* Removed various inline functions
	* Added a re-work of the filter variables


Janosch Frank (10):
  dump: Use a buffer for ELF section data and headers
  dump: Write ELF section headers right after ELF header
  dump: Reorder struct DumpState
  dump: Reintroduce memory_offset and section_offset
  dump: Add architecture section and section string table support
  s390x: Add protected dump cap
  s390x: Introduce PV query interface
  RFC: elf.h changes
  s390x: Add KVM PV dump interface
  s390x: pv: Add dump support

 dump/dump.c                  | 290 +++++++++++++++++++++++++++--------
 hw/s390x/pv.c                | 112 ++++++++++++++
 hw/s390x/s390-virtio-ccw.c   |   6 +
 include/elf.h                |   2 +
 include/hw/s390x/pv.h        |  19 +++
 include/sysemu/dump-arch.h   |   3 +
 include/sysemu/dump.h        |  26 +++-
 target/s390x/arch_dump.c     | 262 +++++++++++++++++++++++++++----
 target/s390x/kvm/kvm.c       |   7 +
 target/s390x/kvm/kvm_s390x.h |   1 +
 10 files changed, 629 insertions(+), 99 deletions(-)

-- 
2.34.1
Re: [PATCH v6 00/10] dump: Add arch section and s390x PV dump
Posted by Thomas Huth 1 year, 6 months ago
On 17/10/2022 10.38, Janosch Frank wrote:
> Previously this series was two separate series:
>   * Arch section support
>     Adds the possibility for arch code to add custom section data.
> 
>   * s390 PV dump support
>     Adds PV dump data to the custom arch sections.
> 
> I've chosen to merge them so it's easier to understand why the arch
> section support has been implement the way it is.
> 
> Additionally I've added cleanup patches beforehand which clean up the
> GuestPhysBlock usage.

As far as I can see, all patches have been reviewed now ... Marc-André, do 
you want to pick this up for your "dump" branch, or shall I take it through 
the s390x tree?

  Thomas


Re: [PATCH v6 00/10] dump: Add arch section and s390x PV dump
Posted by Marc-André Lureau 1 year, 6 months ago
Hi

On Fri, Oct 21, 2022 at 4:38 PM Thomas Huth <thuth@redhat.com> wrote:

> On 17/10/2022 10.38, Janosch Frank wrote:
> > Previously this series was two separate series:
> >   * Arch section support
> >     Adds the possibility for arch code to add custom section data.
> >
> >   * s390 PV dump support
> >     Adds PV dump data to the custom arch sections.
> >
> > I've chosen to merge them so it's easier to understand why the arch
> > section support has been implement the way it is.
> >
> > Additionally I've added cleanup patches beforehand which clean up the
> > GuestPhysBlock usage.
>
> As far as I can see, all patches have been reviewed now ... Marc-André, do
> you want to pick this up for your "dump" branch, or shall I take it
> through
> the s390x tree?
>
>
ack, I'll take them

thanks

-- 
Marc-André Lureau