Hi
On Thu, Aug 25, 2022 at 7:09 PM Peter Maydell <peter.maydell@linaro.org>
wrote:
> Currently if you run shellcheck on our configure script it
> generates a ton of warnings. This patchset fixes some of the
> easier ones. I wasn't aiming for completeness or consistency;
> I just wanted to zap some of the ones where the fix is clear
> and didn't take long to write and is hopefully easy to review.
> We can always come back and take another swing at it later.
>
> thanks
> -- PMM
>
> Peter Maydell (7):
> configure: Remove unused python_version variable
> configure: Remove unused meson_args variable
> configure: Add missing quoting for some easy cases
> configure: Add './' on front of glob of */config-devices.mak.d
> configure: Remove use of backtick `...` syntax
> configure: Check mkdir result directly, not via $?
> configure: Avoid use of 'local' as it is non-POSIX
>
> configure | 82 ++++++++++++++++++++++++++-----------------------------
> 1 file changed, 38 insertions(+), 44 deletions(-)
>
> --
> 2.25.1
>
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--
Marc-André Lureau