From nobody Mon May 20 06:45:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661440191; cv=none; d=zohomail.com; s=zohoarc; b=OzE9LVuPm/1mt9OitAHwhyhzbeRW/nMbL3tAUr9/4BSOjUitliMerekUdNMOdrtNOFnhcVo1aMDci0jwVU0j7gUqOgPenXuvmatGI55jknAyXphx9GWFPV1DMoa/FZJ9fuJ7zJ9L3Fwekf41pD2U4RgUvC2xYyyr1v0qAaOPyCU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661440191; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+xZTakyk5u2TBFgliT7wIbbLXV3Gbp3ddv6mrgYQohs=; b=FZbW8/yb1viGNntaHWq6SEiitDx5kxId2syX1MxwEYqMgBANFObLsxOamamdtO32ilkYsJzRbV56faRU7YrYVMN8YLvcxy8HIj9meil92xSjYWX5A/GYGJGcnF4fFWGU1tcaoEVeNNu6AA8VHt0KJInI/3Vq3OSbwWUz7aTqqqQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16614401910751012.6879379491783; Thu, 25 Aug 2022 08:09:51 -0700 (PDT) Received: from localhost ([::1]:41072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREUO-0006fN-3I for importer@patchew.org; Thu, 25 Aug 2022 11:09:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERq-0003uL-1k for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:10 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:40600) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERo-0002Ln-Bs for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:09 -0400 Received: by mail-wr1-x42c.google.com with SMTP id h5so24198134wru.7 for ; Thu, 25 Aug 2022 08:07:07 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=+xZTakyk5u2TBFgliT7wIbbLXV3Gbp3ddv6mrgYQohs=; b=ZYSk01CxiLczD40wouVLJecG1AXCSnlnXRuxq56S2aqpt0Z9D2Vai4fbTZAQjfkc4m Ikeog7nuHmb2V+ffoZZlcsFMHgEBfRqZmW9QsAoyH0WE8ANy+I4EYWKQrVgB7vr+MiZU W5VRgrMUEWxzAfZAXLmzlax0FNpM/lqoVjdvWNuNHTUbedp3EgAMCs9IKnh87Zi16/Ba x0LTjHJJlZbYD286cct//l3eYRKGUQiIqhYGdXImFGqNl3O79sOCIrM/ceCLL2gpt5+/ +nqHlMp+K4reBvPsd11KAoAX3zLVONYSwo9JkhMN4bnnI/v8LCbWHD8oSEhXg0kt7IWo fNLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=+xZTakyk5u2TBFgliT7wIbbLXV3Gbp3ddv6mrgYQohs=; b=e2ZE1/JsAnp6uwsGr//788NZnPWW1aMyzifiosM463RD2qAn2V0C1niLiJkiak3ucV dR7xKzaqFhXj1mlG9i5ojNmZOJ5LP75s7UY6DVL2cyY9uzOufaolRY7qQP8Xi9wGa1o+ wZBhf+xDRCnFyE+t4mjuUKFVyuCejwMsvtne53eVOFunYuWIoZ+EWKxASC3v34KnXnK3 bxyGcLEgdcPLyopFgvUd93mZCyyuQ7N0f2jDXPsV7aVh5E+2nImCvGq/ClRiOApqX9HU 5Xstp3ecMHOTEUb0Kqmxpu+WWZYnjTxX7QVvfikwFGr9EFakCQ0Pg3L2m50l0PeY63GG zAzA== X-Gm-Message-State: ACgBeo1HD0V6PkyYicHtBsnlek02WRZRxpKOOZPUGc2zCNOpJvNrxqcG 2xsDufFCJAByCwUcOIjsqopDIiiBXiN3cw== X-Google-Smtp-Source: AA6agR7hPgLBSPl0sRglyQyWg60jUhB2k+LtN7ngDRsHA/dE4jqxX5UN67KapAyReHhtSkjPQj+FYg== X-Received: by 2002:a5d:6881:0:b0:225:28cb:332f with SMTP id h1-20020a5d6881000000b0022528cb332fmr2582713wru.405.1661440026902; Thu, 25 Aug 2022 08:07:06 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 1/7] configure: Remove unused python_version variable Date: Thu, 25 Aug 2022 16:06:57 +0100 Message-Id: <20220825150703.4074125-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661440192985100003 Content-Type: text/plain; charset="utf-8" Shellcheck correctly reports that we set python_version and never use it. This is a leftover from commit f9332757898a7: we used to use python_version purely to as part of the summary information printed at the end of a configure run, and that commit changed to printing the information from meson (which looks up the python version itself). Remove the unused variable. Signed-off-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 3 --- 1 file changed, 3 deletions(-) diff --git a/configure b/configure index 72ab03f11aa..efe28050234 100755 --- a/configure +++ b/configure @@ -1112,9 +1112,6 @@ if ! $python -c 'import sys; sys.exit(sys.version_inf= o < (3,6))'; then "Use --python=3D/path/to/python to specify a supported Python." fi =20 -# Preserve python version since some functionality is dependent on it -python_version=3D$($python -c 'import sys; print("%d.%d.%d" % (sys.version= _info[0], sys.version_info[1], sys.version_info[2]))' 2>/dev/null) - # Suppress writing compiled files python=3D"$python -B" =20 --=20 2.25.1 From nobody Mon May 20 06:45:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661440388; cv=none; d=zohomail.com; s=zohoarc; b=HGGMbuG2VVLcgA63ERKB2z14kr6oGOxu3ae3BCv5IQ5tcUFlw8/PrBVTDKAKXh4XsGSOOovdhYi6r9ZZ7bu90fYpqeCYqk73wGS3kMrk8Te0E0EOBPZO2JwHyEHcrqdG4ck/m0M3XQ7wj5ihGfZpWP+zUle90f1re5n5YhRBI+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661440388; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2OVPYJQv5NBuPCjLGLGoSfyQ6B6HYDsVYY1WswEVFEg=; b=Pmel0BlrcenXU1CNcXI551LIH2LAbbtjScFkJZEZNfgRvsz7CdrcijOGMGSFWxZp36Hn4DwDA0QEX0iRLsqk4KmE2JByi6jgSi1sZSTKVpe4TDdIhhaonwvDUWeNFsfnpcspUJOV7s6PrZ9j2D8Z2axW8zxKIbVfPw6Tfs1hhSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661440388488474.6429717970302; Thu, 25 Aug 2022 08:13:08 -0700 (PDT) Received: from localhost ([::1]:48114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREXa-0003Sg-DI for importer@patchew.org; Thu, 25 Aug 2022 11:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERr-0003ua-2c for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:11 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:46074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERp-0002Ly-GO for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:10 -0400 Received: by mail-wr1-x436.google.com with SMTP id bq11so18427069wrb.12 for ; Thu, 25 Aug 2022 08:07:09 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=2OVPYJQv5NBuPCjLGLGoSfyQ6B6HYDsVYY1WswEVFEg=; b=HlW3WjZfUrij5ZrefSQmkNWjpuUn/wy8J/6Od+GtGWrh9SkHt8f8snsFVBYr61MQ9K ddgT/4rZeoDQjeTSCA/iWWMxiJdi9rafGIqYlKtGPR7qfx3RLwmVc6STjXj+01UC0NsX ymk5IqqE8lw16lKQMQ7x/EJvjSGUCuB1TvEyvpHqEsjzazFyASpJr9k4Lgm+XBVspBuk Y/Sj5U6maWJ3cakbahYnqMLMHzpGI1u9GmplQG3FXlSducTWD1bbGddnpnJKtBSU4Sgt BqKMjsA9JCo8KVl7MIp9sAJgMGJ+G01vqS0hcfeAtAcEej4hbtLpz7UWNfGJ6L9Mrt8D 4hAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=2OVPYJQv5NBuPCjLGLGoSfyQ6B6HYDsVYY1WswEVFEg=; b=OFLAaTHFg4VvRF1ErbX3X1obpFJx3fIlo6ubQFhvMQRJx5g+ra1+saFZST5qWCPYnX LNx4uTFPKhL5qKnpgnqtsG+Gz1/BOBMjhxhZGHZ7pLHh1NJEWWxSOXedrYJx5aU6AeK2 blSgbNmblHc/zgk4vQVoQEcTLFCdngsvSHcchpd/CM6v+nyOCNf/DyqkySIfAxdg/LUd 2UbuI85Wq993C0s8z5sVSJHCvn7YYefVCsfzq9rj29Eq44OWk3ExPesX0+FzLdCjB6v+ gAPRtS/qDKKVtIGFUXreWFiRR7IXLZbNb065Q8KdY4b4ARk4pXlgQjWIyapVrJqoJ0Oc HsOQ== X-Gm-Message-State: ACgBeo38aXMjs+yaNrMkfurwKawe4gLoIIe08GX+u2jycFUTyx1+x/5S aEPq8mwWu0FMHNnaGdc6I4+iqPE6mHI0/g== X-Google-Smtp-Source: AA6agR4kOX7LFGrNkfb1o9mGi7NK9eXNUofmdBLOR1/YK/bWdGPnahHqYM4UXykS9rWNh6jmlqfgBA== X-Received: by 2002:a5d:6e8e:0:b0:21d:ea5:710f with SMTP id k14-20020a5d6e8e000000b0021d0ea5710fmr2622835wrz.48.1661440027724; Thu, 25 Aug 2022 08:07:07 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 2/7] configure: Remove unused meson_args variable Date: Thu, 25 Aug 2022 16:06:58 +0100 Message-Id: <20220825150703.4074125-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661440389926100003 Content-Type: text/plain; charset="utf-8" The meson_args variable was added in commit 3b4da13293482134b, but was not used in that commit and isn't used today. Delete the unnecessary assignment. Signed-off-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index efe28050234..b1acaca6dd2 100755 --- a/configure +++ b/configure @@ -311,7 +311,6 @@ pie=3D"" coroutine=3D"" plugins=3D"$default_feature" meson=3D"" -meson_args=3D"" ninja=3D"" bindir=3D"bin" skip_meson=3Dno --=20 2.25.1 From nobody Mon May 20 06:45:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661440394; cv=none; d=zohomail.com; s=zohoarc; b=MUU+ZwRM1DkUOv+7sa9JYhbkn7PJ3L5uQJRjNKJFV6k5/9w0Gfgxxss+mHQB2bQth/hepOU0kllpSLMXU2PC76GPfNmHZI9cHM+7lNCJnyg09+rvmILQhXkmefS79PUwDnhPRNkRINmN8RKBBj8kVCIKPK+3eJZeilseQE6/oFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661440394; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DWNuvqbFBvUjcGdjxo+MqgXtO5vi7v0ejT71g3xQKIg=; b=EE5jWEwtah2N+2aCo0MZU6dwg0MwwjqX5LMRw8ZKycNXYbAuQ9mjoX8xB7+jGcuau8Z1SJA/g1AfswVm7S8EBEmQvisX0GsI0T2PV6qfofK1ErbI0kx5LNgcsq2fzWwd6QEHkyUGDf3yY/XIwpSGnKWL/467w3rENRPCyCyfIVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661440394457663.1305836824498; Thu, 25 Aug 2022 08:13:14 -0700 (PDT) Received: from localhost ([::1]:56920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREXh-0003fQ-FD for importer@patchew.org; Thu, 25 Aug 2022 11:13:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERs-0003yB-LP for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:13 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:37834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERq-0002M4-IO for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:12 -0400 Received: by mail-wr1-x42f.google.com with SMTP id n17so392038wrm.4 for ; Thu, 25 Aug 2022 08:07:10 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=DWNuvqbFBvUjcGdjxo+MqgXtO5vi7v0ejT71g3xQKIg=; b=qi9mXkoH3wrwJjibelE3Xeo9GegiFCuONmK4CnVZzcBg7iM9+rq6hKJYoRMB9Soy30 fzrp4a2401scBjSFf8qfcbIxy3LYJv9E86a4rLoyqHNm0q2XrVBpm4Ychc/Jy/xN3k+F CyapDHLwsVOXSAop+1K2Bi/QRbsagk0hCdiQ1MIo10GU8zV4Tdx6CeOhcwBCpzLkYXD5 389tRNAeAJiKyJZPHrxEeAux4NxwMuCnG18/JoxVHfyTYYtm8CLb0yXLvLZ6y8JQWgvn 39rEpDzi58zSRyw5FTNoMen7cwF4nS8tRCy5Oqhvp591N4cDuGPP9fO83zqwNL/cImSf jqMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=DWNuvqbFBvUjcGdjxo+MqgXtO5vi7v0ejT71g3xQKIg=; b=FRSkl3Xw88B3rq9wzYHjTsJw/gGTKe8zrbV80f9duhJSISulX+YvbhkCEmWt67fzwY axLcbE1bOGrS4EH194OVdKS4cHb8vtIH9+gm6BpzzNSlnvuU+6JmTbQ9CGvdjzP32kPq TzZHMDHQIN767TLnKbHLl7rI1l/EF718f7KHLlFzDO6r3OhqE7tcFTkp6x6xWWFWZaL2 LnZLDUlR41NVms6NZ+PxAGCPbwHZcIpU+0PWZGzr7qoS+lkWUvXZHKNkWkbVFy1iJaHG puBgueDpa+Npi7oAspGmG4/f1BKK0F+pZiY/fvdWAvLiGr6irT3W9v2KB0ZV9DGSxI3+ 1apQ== X-Gm-Message-State: ACgBeo2SE4yptFDLsFeRvxGAKDRv4hxYe1WHJkWbFLubgJly2efCYYUV eF14FnloB3JzJsd1j83DE4NzAx/OwssBRg== X-Google-Smtp-Source: AA6agR78G9mpUf/QfHUMc1eqKN7+GNNlpPiIzxBXsa8kzcTsZbuhFCduRtCfcTYdGY6eoAaIPUSMUQ== X-Received: by 2002:a5d:6485:0:b0:225:5caf:2e44 with SMTP id o5-20020a5d6485000000b002255caf2e44mr2556391wri.365.1661440028722; Thu, 25 Aug 2022 08:07:08 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 3/7] configure: Add missing quoting for some easy cases Date: Thu, 25 Aug 2022 16:06:59 +0100 Message-Id: <20220825150703.4074125-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661440395999100001 Content-Type: text/plain; charset="utf-8" This commit adds quotes in some places which: * are spotted by shellcheck * are obviously incorrect * are easy to fix just by adding the quotes It doesn't attempt fix all of the places shellcheck finds errors, or even all the ones which are easy to fix. It's just a random sampling which is hopefully easy to review and which cuts down the size of the problem for next time somebody wants to try to look at shellcheck errors. Signed-off-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 64 +++++++++++++++++++++++++++---------------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/configure b/configure index b1acaca6dd2..894642554c3 100755 --- a/configure +++ b/configure @@ -57,7 +57,7 @@ GNUmakefile: ; =20 EOF cd build - exec $source_path/configure "$@" + exec "$source_path/configure" "$@" fi =20 # Temporary directory used for files created while @@ -691,7 +691,7 @@ meson_option_build_array() { printf ']\n' } =20 -. $source_path/scripts/meson-buildoptions.sh +. "$source_path/scripts/meson-buildoptions.sh" =20 meson_options=3D meson_option_add() { @@ -711,7 +711,7 @@ for opt do case "$opt" in --help|-h) show_help=3Dyes ;; - --version|-V) exec cat $source_path/VERSION + --version|-V) exec cat "$source_path/VERSION" ;; --prefix=3D*) prefix=3D"$optarg" ;; @@ -985,7 +985,7 @@ default_target_list=3D"" mak_wilds=3D"" =20 if [ "$linux_user" !=3D no ]; then - if [ "$targetos" =3D linux ] && [ -d $source_path/linux-user/include/h= ost/$cpu ]; then + if [ "$targetos" =3D linux ] && [ -d "$source_path/linux-user/include/= host/$cpu" ]; then linux_user=3Dyes elif [ "$linux_user" =3D yes ]; then error_exit "linux-user not supported on this architecture" @@ -995,7 +995,7 @@ if [ "$bsd_user" !=3D no ]; then if [ "$bsd_user" =3D "" ]; then test $targetos =3D freebsd && bsd_user=3Dyes fi - if [ "$bsd_user" =3D yes ] && ! [ -d $source_path/bsd-user/$targetos ]= ; then + if [ "$bsd_user" =3D yes ] && ! [ -d "$source_path/bsd-user/$targetos"= ]; then error_exit "bsd-user not supported on this host OS" fi fi @@ -1117,7 +1117,7 @@ python=3D"$python -B" if test -z "$meson"; then if test "$explicit_python" =3D no && has meson && version_ge "$(meson = --version)" 0.59.3; then meson=3Dmeson - elif test $git_submodules_action !=3D 'ignore' ; then + elif test "$git_submodules_action" !=3D 'ignore' ; then meson=3Dgit elif test -e "${source_path}/meson/meson.py" ; then meson=3Dinternal @@ -1840,7 +1840,7 @@ esac container=3D"no" if test $use_containers =3D "yes"; then if has "docker" || has "podman"; then - container=3D$($python $source_path/tests/docker/docker.py probe) + container=3D$($python "$source_path"/tests/docker/docker.py probe) fi fi =20 @@ -2290,7 +2290,7 @@ if test "$QEMU_GA_DISTRO" =3D ""; then QEMU_GA_DISTRO=3DLinux fi if test "$QEMU_GA_VERSION" =3D ""; then - QEMU_GA_VERSION=3D$(cat $source_path/VERSION) + QEMU_GA_VERSION=3D$(cat "$source_path"/VERSION) fi =20 =20 @@ -2539,7 +2539,7 @@ fi for target in $target_list; do target_dir=3D"$target" target_name=3D$(echo $target | cut -d '-' -f 1)$EXESUF - mkdir -p $target_dir + mkdir -p "$target_dir" case $target in *-user) symlink "../qemu-$target_name" "$target_dir/qemu-$target_n= ame" ;; *) symlink "../qemu-system-$target_name" "$target_dir/qemu-system-= $target_name" ;; @@ -2574,14 +2574,14 @@ for target in $target_list; do config_target_mak=3Dtests/tcg/config-$target.mak =20 echo "# Automatically generated by configure - do not modify" > $config_= target_mak - echo "TARGET_NAME=3D$arch" >> $config_target_mak + echo "TARGET_NAME=3D$arch" >> "$config_target_mak" case $target in xtensa*-linux-user) # the toolchain is not complete with headers, only build softmmu tes= ts continue ;; *-softmmu) - test -f $source_path/tests/tcg/$arch/Makefile.softmmu-target || cont= inue + test -f "$source_path/tests/tcg/$arch/Makefile.softmmu-target" || co= ntinue qemu=3D"qemu-system-$arch" ;; *-linux-user|*-bsd-user) @@ -2596,73 +2596,73 @@ for target in $target_list; do # compilers is a requirememt for adding a new test that needs a # compiler feature. =20 - echo "BUILD_STATIC=3D$build_static" >> $config_target_mak - write_target_makefile >> $config_target_mak + echo "BUILD_STATIC=3D$build_static" >> "$config_target_mak" + write_target_makefile >> "$config_target_mak" case $target in aarch64-*) if do_compiler "$target_cc" $target_cflags \ -march=3Darmv8.1-a+sve -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_SVE=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_SVE=3Dy" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -march=3Darmv8.1-a+sve2 -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_SVE2=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_SVE2=3Dy" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -march=3Darmv8.3-a -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_ARMV8_3=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_ARMV8_3=3Dy" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -mbranch-protection=3Dstandard -o $TMPE $TMPC= ; then - echo "CROSS_CC_HAS_ARMV8_BTI=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_ARMV8_BTI=3Dy" >> "$config_target_mak" fi if do_compiler "$target_cc" $target_cflags \ -march=3Darmv8.5-a+memtag -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_ARMV8_MTE=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_ARMV8_MTE=3Dy" >> "$config_target_mak" fi ;; ppc*) if do_compiler "$target_cc" $target_cflags \ -mpower8-vector -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_POWER8_VECTOR=3Dy" >> $config_target_= mak + echo "CROSS_CC_HAS_POWER8_VECTOR=3Dy" >> "$config_target= _mak" fi if do_compiler "$target_cc" $target_cflags \ -mpower10 -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_POWER10=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_POWER10=3Dy" >> "$config_target_mak" fi ;; i386-linux-user) if do_compiler "$target_cc" $target_cflags \ -Werror -fno-pie -o $TMPE $TMPC; then - echo "CROSS_CC_HAS_I386_NOPIE=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_I386_NOPIE=3Dy" >> "$config_target_ma= k" fi ;; esac elif test -n "$container_image"; then echo "build-tcg-tests-$target: docker-image-$container_image" >> $ma= kefile - echo "BUILD_STATIC=3Dy" >> $config_target_mak - write_container_target_makefile >> $config_target_mak + echo "BUILD_STATIC=3Dy" >> "$config_target_mak" + write_container_target_makefile >> "$config_target_mak" case $target in aarch64-*) - echo "CROSS_CC_HAS_SVE=3Dy" >> $config_target_mak - echo "CROSS_CC_HAS_SVE2=3Dy" >> $config_target_mak - echo "CROSS_CC_HAS_ARMV8_3=3Dy" >> $config_target_mak - echo "CROSS_CC_HAS_ARMV8_BTI=3Dy" >> $config_target_mak - echo "CROSS_CC_HAS_ARMV8_MTE=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_SVE=3Dy" >> "$config_target_mak" + echo "CROSS_CC_HAS_SVE2=3Dy" >> "$config_target_mak" + echo "CROSS_CC_HAS_ARMV8_3=3Dy" >> "$config_target_mak" + echo "CROSS_CC_HAS_ARMV8_BTI=3Dy" >> "$config_target_mak" + echo "CROSS_CC_HAS_ARMV8_MTE=3Dy" >> "$config_target_mak" ;; ppc*) - echo "CROSS_CC_HAS_POWER8_VECTOR=3Dy" >> $config_target_mak - echo "CROSS_CC_HAS_POWER10=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_POWER8_VECTOR=3Dy" >> "$config_target_mak" + echo "CROSS_CC_HAS_POWER10=3Dy" >> "$config_target_mak" ;; i386-linux-user) - echo "CROSS_CC_HAS_I386_NOPIE=3Dy" >> $config_target_mak + echo "CROSS_CC_HAS_I386_NOPIE=3Dy" >> "$config_target_mak" ;; esac got_cross_cc=3Dyes fi if test $got_cross_cc =3D yes; then mkdir -p tests/tcg/$target - echo "QEMU=3D$PWD/$qemu" >> $config_target_mak + echo "QEMU=3D$PWD/$qemu" >> "$config_target_mak" echo "run-tcg-tests-$target: $qemu\$(EXESUF)" >> $makefile tcg_tests_targets=3D"$tcg_tests_targets $target" fi --=20 2.25.1 From nobody Mon May 20 06:45:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661440191; cv=none; d=zohomail.com; s=zohoarc; b=YqJtIQOzVzf81+UI7dL9A/89jKCiPYdGNAbl/Y0VaCJC5/QGYynYM878HE3t7TYpGIgTHtX4zDJiOSEcM0Rcj43YNwM6M5afSyEsRn9u+ZTr1uABfLoJvNiQb/hN/6rR3VMmLQMeHeLxBb3ezWI8gIXvZL+RYUSTqKKGB5PqREI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661440191; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JiN1luN3YeavHyuwP6WbtnNpnk7z37GeHVcVmF5DqF0=; b=AvviPPO5hKOpAInPMg/GDoMxcdoCbmGD8d+rrYyOQvC7c5HAXqouHzThoxjEbE+tP1B+L8TpPClKhaDZce2Dk+CPDFcAy1hhbdmHD/dbdfIhk+flRtgenEF/k6UVsR7f8V5qdqkLmFkW1OmBVWQLyQ1aZs3XU9jebThH22xvA8Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166144019106979.62235916778832; Thu, 25 Aug 2022 08:09:51 -0700 (PDT) Received: from localhost ([::1]:41076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREUQ-0006kS-19 for importer@patchew.org; Thu, 25 Aug 2022 11:09:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERs-0003yJ-No for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:12 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:41801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERr-0002MM-3E for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:12 -0400 Received: by mail-wr1-x434.google.com with SMTP id h24so25006954wrb.8 for ; Thu, 25 Aug 2022 08:07:10 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=JiN1luN3YeavHyuwP6WbtnNpnk7z37GeHVcVmF5DqF0=; b=nkdmCpbAI9VsDyH8tJdTk6/xarCBpEBIKW1AwuzoGz5u74jUXFoszHyG1Jy2UooExu ua+ozd2TGtEqSKWun7xNEn101t7Xe9h7rx6xzN/zhJmdRhTtF0CKlx10Sbh3tBv5DLdK DCODhfg4U+2Ro4CJ348XvJBa7PaKcMTC0lDl42I1mGFkti3a5E0u9w85+aRX5SQC0OUx uVsRzjpJVhejwCMgcYTT6kbiPTGXEuIrCICnzsV9o8WObqVKpU/PTBL0NyCvnz90Z2vm M7vY+S5iGp10XKwg+ldboM3e3jnoJaw5GXvekdVb4/Qh97iwVVipZur8Vf3O8Vk5yz4/ B77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=JiN1luN3YeavHyuwP6WbtnNpnk7z37GeHVcVmF5DqF0=; b=hDJGJYZ6lLczOM1LYBHNYH9LVFus7ive46U09/FnUWSs3P9E0Jo/bC1uP/W+yEQwoD NVCZFvRT0AlaC+n4FiC1limOq7MAXxEo74GNKnfYZKdrppOlSK+S1LsU2ZUFALOiCzFd 6oLAAUhFWoIgGe6O2gLm6USwsHBwY5tAnwL+xESs/u0tfgYyKxrT6qvh939SXfEahXIP 9Ent/ttTli1asKR21Ns8JU4WRkW2WDVizDvH4RIKzxS3MtFCjSwrZTQWImqS3CRupfjh 0kdFNY6GciSuaSd6NNgop9Qlw/BmavusBslcjoTafnLbnKG3rk/ETR3CZG+VB3+YCstj RfeA== X-Gm-Message-State: ACgBeo0NwuohlKcINYeGoTrbplyr0BVMkxvDVZNZUU3ubnld50TIA9hW 7xiUo3B3yyiU4NUHlZIGZwkajBonqDb0HA== X-Google-Smtp-Source: AA6agR7FL2g1HOlRUIs6xMAQ6YFsTbjpVVQiABtjxw2pDhsTeVhOY7xJmO6j0ogDe0HywZVCz5CFUQ== X-Received: by 2002:a05:6000:1448:b0:225:63f2:2421 with SMTP id v8-20020a056000144800b0022563f22421mr2438638wrx.527.1661440029623; Thu, 25 Aug 2022 08:07:09 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 4/7] configure: Add './' on front of glob of */config-devices.mak.d Date: Thu, 25 Aug 2022 16:07:00 +0100 Message-Id: <20220825150703.4074125-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661440192984100001 Content-Type: text/plain; charset="utf-8" Shellcheck warns that in rm -f */config-devices.mak.d the glob might expand to something with a '-' in it, which would then be misinterpreted as an option to rm. Fix this by adding './'. Signed-off-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 894642554c3..d5b6546ae81 100755 --- a/configure +++ b/configure @@ -1093,7 +1093,7 @@ exit 0 fi =20 # Remove old dependency files to make sure that they get properly regenera= ted -rm -f */config-devices.mak.d +rm -f ./*/config-devices.mak.d =20 if test -z "$python" then --=20 2.25.1 From nobody Mon May 20 06:45:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661440604; cv=none; d=zohomail.com; s=zohoarc; b=jHA+6kTT8K9Jy6BIoPITb+KivfiA/z6DZlINeMccxVO7vfb3ZVIRaZX9WAOQzWUCNGuIr5MBH5wVcgl7dKb6hIbOOwQ3NuoGxds9m6+JxZ/knjUEtt2Ib/WZ4JcWfeiQepaJF31qI/TAoqf0wQGB6kwbfPR7Vhh3m0eG++QyWCU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661440604; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xf12vm2J9pTBvB1Rs+/alRNUQSzG8ZNSmZQQA8BoXwU=; b=cVZNc8dTjQe/nvWSbN4ov6ibcaOzU8k9uu6eA4Uiu/rJJChtUPGItTswiBlKDak7sX/veDbgeRKmp+yzLqGSucnuakAuuos8UP33tx2xvAT8TdesrCvNmZXjyBVZvplXAHw2RvV2PKV+z9U0Vt5nyqSncNQ8gGjUjczciYWfoGE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661440604913218.4196767152447; Thu, 25 Aug 2022 08:16:44 -0700 (PDT) Received: from localhost ([::1]:46416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREb5-0007q1-MW for importer@patchew.org; Thu, 25 Aug 2022 11:16:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERx-00049V-1u for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:17 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:37841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERr-0002MX-Qp for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:16 -0400 Received: by mail-wr1-x436.google.com with SMTP id n17so392160wrm.4 for ; Thu, 25 Aug 2022 08:07:11 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=xf12vm2J9pTBvB1Rs+/alRNUQSzG8ZNSmZQQA8BoXwU=; b=G9IBdo6IQjSpmZ0OrgRGeMhKzlVAFsnRvNSqx0o6ZyIvAJWq/viaykAF+GpABVTRTm CkbLTV0REb8uAVFxJCmRo2XloXCuDF+FmKaDH1UZCZK5J4LBg/zsx/+c7YOqp2ynWcjg 7fJDUEeLqs9mL34c1WlGKAxz/x+KMHxz63DW/08h52+YXhi08sUAY8IkUYsKLdfwC8Zq 2ec4+mtT613507llsPBTzlK7HUi3BwPTWSPa3SPrj4TVZiNmbMPQt+pa5+B3NRTqaaKw xSvq1cqbkavYTP+l3sUp69LGoD5kyEdMFA3oLRrQUkGfQpiy7W4+59e1ENZ8TIcv6F7B NBCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=xf12vm2J9pTBvB1Rs+/alRNUQSzG8ZNSmZQQA8BoXwU=; b=tdOdQvyKIfLbVXwMx88fFMaS94SqyxXlSm/TrT3TsEY+rPie+TJmN7V9QhpEhEOekX esDzrMYHGvHjnMf7A78hlfFiftEubkl/oXunDq+dUFBRQCqI+Fq5YZ4pncZyf1RPdvIO cRJzrk/V4j/d/x/hfJYfXwXpjmPrVgCGTcTn0pt0iN/yAMR3zAW1P4QiEdSymwuRxNUL FQY7cZTf3gDCJNJ9DSgtz9CkvjpbZem/OBkKo03PUiYloR6TLSc4W61zotGfE4Q7RcBi nYZgr7q8fMvAdox6lvAhchaN6YFkeag0rMzXXux7Jdm7f/CKIqtS9w8slzICS3PlRsQq plOA== X-Gm-Message-State: ACgBeo010mZjE03F3puNpr0SbBEXWgRJyhkq073uM/dpsutVtBqcUXwc 4qBkIK4LA0RS6PmLsvOMtC9nowRjDx3d+g== X-Google-Smtp-Source: AA6agR6K4UYKghxxH+WspfKZ+evlmvg6aHh5h3xsUcdjhptCGXvsR3yqOsi/NPsuS+J6zhUCTo3Gkg== X-Received: by 2002:a05:6000:250:b0:225:624b:13 with SMTP id m16-20020a056000025000b00225624b0013mr2460816wrz.127.1661440030511; Thu, 25 Aug 2022 08:07:10 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 5/7] configure: Remove use of backtick `...` syntax Date: Thu, 25 Aug 2022 16:07:01 +0100 Message-Id: <20220825150703.4074125-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661440606118100001 Content-Type: text/plain; charset="utf-8" There's only one place in configure where we use `...` to execute a command and capture the result. Switch to $() to match the rest of the script. This silences a shellcheck warning. Signed-off-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d5b6546ae81..5c1992d5bce 100755 --- a/configure +++ b/configure @@ -2317,7 +2317,7 @@ LINKS=3D"$LINKS python" LINKS=3D"$LINKS contrib/plugins/Makefile " for f in $LINKS ; do if [ -e "$source_path/$f" ]; then - mkdir -p `dirname ./$f` + mkdir -p "$(dirname ./"$f")" symlink "$source_path/$f" "$f" fi done --=20 2.25.1 From nobody Mon May 20 06:45:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661440190; cv=none; d=zohomail.com; s=zohoarc; b=IeeTYqXaeA7e2x+imMBxn2yV0vNb4fwcRulLk2jspExbHkJgVOKmJZYAc91sc6JmCi8uXu9ivZ9D5/UosudD3OKAv7Yf3pH1Xu+9g+JUKD/efTdLGIj3isZVP9NA2/Dw8xz1HSGFdrPhC3ke1RgFMgzZNXDVF90yaIYSzgVbECo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661440190; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4boT9ZMp8UNLQGnPh1ZGB1JNd8shwOC+FWZasArxRX0=; b=Ed8op37GtrSRanwbMRBGiNUoFaqeD+c8iAABdlnJdEYw2v20u9NFlTmAPIM4ufDM+BX9alQ2rdsLn2sFv7ghgnHIzO9FtdKZruOLAFrAh3pxf/iFdkYZQ8FhMlGZD0IUPX7q/iYhyTjYl2/8Easrcc+OfW7JRjgViQibhEyY3TY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166144019097481.04778585025417; Thu, 25 Aug 2022 08:09:50 -0700 (PDT) Received: from localhost ([::1]:41074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREUO-0006j0-KQ for importer@patchew.org; Thu, 25 Aug 2022 11:09:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERu-00040V-Ey for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:44975) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERs-0002Mn-Sb for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: by mail-wm1-x336.google.com with SMTP id k18-20020a05600c0b5200b003a5dab49d0bso2683744wmr.3 for ; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=4boT9ZMp8UNLQGnPh1ZGB1JNd8shwOC+FWZasArxRX0=; b=wk5KsKhJ4H6O4nuab22EGZzNJgjJHaF5skcbPGGbpT13em+JPLha8Uj9hXj3/rcHx9 NPINAOlwIPSAzGlSB0Qi7ZxoaWOj+lxopxSTiQwsvTMZQ+gXzDJVf/UIpOcmsE0C1mMS EdtcpPwk/9Ym0Zs/OkjCG88uEGGML3MAllyNKad2noglVvj0NuRPJjlHg6+iZ6yTiYH8 pMJmpnc/5ve3LPwwKG4HMWOP3HDeG8+Mbp7RhJud6LO7LgkzivWoJmg88tqSWOdoU5RF GufZOTo1Ot6PIKjepUqxJtCAv/lNm8qIUkbVV8F9ijq/fBRUZAhqnayhMr4whRh3DESh O9oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=4boT9ZMp8UNLQGnPh1ZGB1JNd8shwOC+FWZasArxRX0=; b=SYzZusGqva/zo4thDp63haYUl4CZTfVyPcHk44mnko3Cpd7cvE2epx0FmSFncbEf+e ODTCz2oVcmh7ZLDyJjoO+fozCV0lCnQyFp7suoUKM24UGRk9HFgd8mXLWcdM9swVrvMd uHR/Sg1XL6/30aJQ+zPl3z3yFs7HhagJoNUq5VHBgugxE7z0/Ny/3t/scieDL7vPfGJW g/+a9LC+mu/pbDtmE5pTsqhE7jsQEtAdvx7XupcYD4OtQnoj76FYPxHYVHOWfLHwcAaX 0LAJZ37+0YnheVwOclFtNpZTaLiC0UXSYbIgXqg96lj1EfhAekTuUC8m2GEBnhFhqnid qb0Q== X-Gm-Message-State: ACgBeo1r0UBHnhbRRjwBzG+AfGNwZM73oMJRrk13oVmnmWm5sAJ49PbL X/a6KWK1QUrsoLSdBqVyjrSUABd58t6mEw== X-Google-Smtp-Source: AA6agR7cMuC0irGvo+jcKaWvOMmjZC+KZerO1itFi2j6SmiY7L5isI1fn5zMVNZ/PHdAqyaenFOZqg== X-Received: by 2002:a1c:7703:0:b0:3a5:aefa:68e3 with SMTP id t3-20020a1c7703000000b003a5aefa68e3mr2755344wmi.158.1661440031363; Thu, 25 Aug 2022 08:07:11 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 6/7] configure: Check mkdir result directly, not via $? Date: Thu, 25 Aug 2022 16:07:02 +0100 Message-Id: <20220825150703.4074125-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661440192985100002 Content-Type: text/plain; charset="utf-8" Shellcheck warns that we have one place where we run a command and then check if it failed using $?; this is better written to simply check the command in the 'if' statement directly. Signed-off-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 5c1992d5bce..f8d7270a60e 100755 --- a/configure +++ b/configure @@ -67,8 +67,7 @@ fi # it when configure exits.) TMPDIR1=3D"config-temp" rm -rf "${TMPDIR1}" -mkdir -p "${TMPDIR1}" -if [ $? -ne 0 ]; then +if ! mkdir -p "${TMPDIR1}"; then echo "ERROR: failed to create temporary directory" exit 1 fi --=20 2.25.1 From nobody Mon May 20 06:45:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1661440387; cv=none; d=zohomail.com; s=zohoarc; b=TJSNNOFefhokVjkdNu96G+vj6xnC/XGtFYiHhx4WBhKE/c4pvMCifdvFPgOnAa4/DM4rVTxLvKZFe8OChHvUg1w4i0eMTS902eWcS/bamUhvAG2KZdBKG1XlaOlqpCIkJZmIKDYOkJkF45ffDG4FUf//Gci8fLmutsYOt2eQick= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661440387; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=fHICBQEqKEed93xWP+Fi6AuRLgA+/WUErNs2u8TIYMZq7zx0Wxfmu27WGyb40iRv1AXSXQukJGIlI9Iacsbe0ICQXL3qyHswJvABfI0VNhPSf6JHj+s4R9Tcue/ciu/CteV6DVzm4RpMfGNhYQ1LVpn9DzuliCjpDxKfLtNS/Bk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1661440387027396.88570825329987; Thu, 25 Aug 2022 08:13:07 -0700 (PDT) Received: from localhost ([::1]:48112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oREXY-0003Rc-O5 for importer@patchew.org; Thu, 25 Aug 2022 11:13:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRERu-000410-JF for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:37834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRERs-0002M4-W7 for qemu-devel@nongnu.org; Thu, 25 Aug 2022 11:07:14 -0400 Received: by mail-wr1-x42f.google.com with SMTP id n17so392278wrm.4 for ; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bo20-20020a056000069400b0022585f6679dsm1064638wrb.106.2022.08.25.08.07.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 08:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=mlFGuZ5OjV2RVek6i01ZKdY8nX6XEU1A/hnnZkSNI/PLwUzz7F6jbGKU4VzilrjCXD ySGTTC5vnst6KrXbO6ZNsZLKQC7r7adpswLbV5JzyVZESOnX5MB/GJexe9Dk7g4BDNxy m226L6htJLAoCHCO7VTMT1kiBaZsWMMUK/T8Yp98EC6q7MqKQ2Lq/9YT842EsNGhYdVQ /DENxN7VKrKxf+e6/u4XCZ6cFW0TObBMHoBXWnmHC3V8wLwuJxSAkvyxfHDaQV7YvQ6z z13eyGueNq3TNuW0GmRuV58yXI6ksRkifGNvr+MRz9nAywtlhWYu4ExmjLbeFM13He/m e11Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=gxmhVjZ/U3QufOhpg/Sa9o1bzWISSCytFtK6UtKa9X8=; b=BdVVjW/u7nsDote/ypRJ9pYhlj6Bpev2nTnGxZ8xmjVEhrp+ZlYYPDrfhEMZ15f/aS N7N/YnBR/c8Vko5D/cCTXRsp6lo+u1OtWnIaLVMBdrGy7ZjHhlbWj9MEYMGgoa4cx8jP Ey7R6O/AqVuaciLRoYt340uqYZf/434HGI3EIHr/QLjvj8OQL6IbvXvloSLkAgpJpCYT 9c/GqMBR/gPEkVDiJNN3l7KSXq6XI5toQ/t7c5/XDS7lZJ5K9G/o0BKfomwt3ev4lcxD gImpkkCXfKBWmfww3UevAt6VGvkz+0QPUdvkZseqy6FYgkxHW2q0Vpoh7djs1KQpZpuL PSQA== X-Gm-Message-State: ACgBeo24dL0H0Pklpuv3KSx3M692IEgOoMq3mWDxruEKlc2wmAzCZ/x5 oI/R/D1TdqCgouHltmh1YUE6nkWN0eyIAg== X-Google-Smtp-Source: AA6agR7rrp+u6fvDQ/ZHYJSJa5M93A7uPHg7z5108CRnaG+Ah/AZFYR5rbTaIJwzH3lgyCpGnZZilw== X-Received: by 2002:a5d:49c6:0:b0:225:61c9:dd4e with SMTP id t6-20020a5d49c6000000b0022561c9dd4emr2480862wrs.445.1661440032138; Thu, 25 Aug 2022 08:07:12 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 7/7] configure: Avoid use of 'local' as it is non-POSIX Date: Thu, 25 Aug 2022 16:07:03 +0100 Message-Id: <20220825150703.4074125-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220825150703.4074125-1-peter.maydell@linaro.org> References: <20220825150703.4074125-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1661440387910100001 Content-Type: text/plain; charset="utf-8" We use the non-POSIX 'local' keyword in just two places in configure; rewrite to avoid it. In do_compiler(), just drop the 'local' keyword. The variable 'compiler' is only used elsewhere in the do_compiler_werror() function, which already uses the variable as a normal non-local one. In probe_target_compiler(), $try and $t are both local; make them normal variables and use a more obviously distinct variable name for $t. Signed-off-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- configure | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configure b/configure index f8d7270a60e..f2f793e3653 100755 --- a/configure +++ b/configure @@ -110,7 +110,7 @@ error_exit() { do_compiler() { # Run the compiler, capturing its output to the log. First argument # is compiler binary to execute. - local compiler=3D"$1" + compiler=3D"$1" shift if test -n "$BASH_VERSION"; then eval ' echo >>config.log " @@ -2071,7 +2071,6 @@ probe_target_compiler() { : ${container_cross_strip:=3D${container_cross_prefix}strip} done =20 - local t try try=3Dcross case "$target_arch:$cpu" in aarch64_be:aarch64 | \ @@ -2084,8 +2083,8 @@ probe_target_compiler() { try=3D'native cross' ;; esac eval "target_cflags=3D\${cross_cc_cflags_$target_arch}" - for t in $try; do - case $t in + for thistry in $try; do + case $thistry in native) target_cc=3D$cc target_ccas=3D$ccas --=20 2.25.1