accel/kvm: Avoid Coverity warning in query_stats()

[PATCH] accel/kvm: Avoid Coverity warning in query_stats()

Peter Maydell posted 1 patch 1 year, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220719134853.327059-1-peter.maydell@linaro.org

Maintainers: Paolo Bonzini <pbonzini@redhat.com>

accel/kvm/kvm-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] accel/kvm: Avoid Coverity warning in query_stats()

Posted by Peter Maydell 1 year, 9 months ago

Coverity complains that there is a codepath in the query_stats()
function where it can leak the memory pointed to by stats_list.  This
can only happen if the caller passes something other than
STATS_TARGET_VM or STATS_TARGET_VCPU as the 'target', which no
callsite does.  Enforce this assumption using g_assert_not_reached(),
so that if we have a future bug we hit the assert rather than
silently leaking memory.

Resolves: Coverity CID 1490140
Fixes: cc01a3f4cadd91e6 ("kvm: Support for querying fd-based stats")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 accel/kvm/kvm-all.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index ed8b6b896ed..eb7fceb3362 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -3980,7 +3980,7 @@ static void query_stats(StatsResultList **result, StatsTarget target,
                         stats_list);
         break;
     default:
-        break;
+        g_assert_not_reached();
     }
 }
 
-- 
2.25.1

Re: [PATCH] accel/kvm: Avoid Coverity warning in query_stats()

Posted by Paolo Bonzini 1 year, 9 months ago

Queued, thanks.

Paolo