From nobody Tue May 7 11:37:16 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1658238880; cv=none; d=zohomail.com; s=zohoarc; b=UjefBhXfb25kVWzLDqlZtxch8uyW+kaTGpB7RN7Goh7Ux80hx8wu5O44PisLmDIhh7i+MXjBjTH4Wxa1NHopQy4hm87q5Gj/iLJV8JigaEPLamSYdXFRP/zCd2OoAnrmy45fW7LXaLo4uBelOCbkcwC0V2eJ5C/jFS7/HsJiyxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658238880; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=FllSCVLoep8lA6JkfG8iV3FNWrJASTbVenINWIRkquM=; b=Xy+uBV6bzyJWsNOZoZwcH+EWymCcc8xJARzi0xGdBMjC4WsHvJhZRj1BQv/J/PQWqwlTKjdal5FlSEbyreM+HGFDCsCV0xfhJK9VlUoLNzhvtcj0bD8Pezjuw0YW6+yvtcfMSjK0Cmw2HzSC9NhRwEdcu3H/8Z/yNLCjUZ1HCWQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1658238880100626.7662590104308; Tue, 19 Jul 2022 06:54:40 -0700 (PDT) Received: from localhost ([::1]:34778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDngN-0001Ba-2c for importer@patchew.org; Tue, 19 Jul 2022 09:54:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDnav-00008p-Ft for qemu-devel@nongnu.org; Tue, 19 Jul 2022 09:49:01 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:40954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDnar-0001vy-Ng for qemu-devel@nongnu.org; Tue, 19 Jul 2022 09:49:01 -0400 Received: by mail-wr1-x434.google.com with SMTP id z12so21696554wrq.7 for ; Tue, 19 Jul 2022 06:48:57 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id q5-20020a1c4305000000b003a2d6c623f3sm21942829wma.19.2022.07.19.06.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 06:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FllSCVLoep8lA6JkfG8iV3FNWrJASTbVenINWIRkquM=; b=Q4NfbkJK/mLbW/OR/F/SPxVZ8DvS+EKCNIJ6PWDvRw2xNhOs/MRchZlaJ5OYo+gDh/ k9inR96U9VtQpQfTtZRyCRKErLV3THCdFsHo7RBVFEuPPXoMgy7MYsz7VJ5agmX3qNAY /+vXR1XxztO/h/uot7LeL7Jvyad1dckxYKq2PlUldE1fYV592Z80gb/NTKHrQR6krsGG AfJ97hdeCHADmwRceAQDINEXL0PNMeML31X1tfEEqKm4BIIfOTHqQraMOAR0cHpZU3kf CYUDJW9IuHV1nF33DzQSHJp7doNpqGlhnc9kaIMro3IEAduoru1P9jimMoPzNl3SACUS fwLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FllSCVLoep8lA6JkfG8iV3FNWrJASTbVenINWIRkquM=; b=Z02cF180SyhIKjSoge2srziml+7GpbP2Ool4vxwX7ZdQsw7BEL+GBJoDO6ivfIwLLU lebyFRWvEeKlBIH8iLawk9WOvBYnJNKevOR8Q3MthYrbTZDKPX1D7sMpklXxS05wiQQc xE1a44sHccsDUUbcBJ6l8Pj77PrF10OZXK5uQgpjI9dxyE5OvsZmgdtvmjYx/2/Vu70G 396hFXDzWd6w1/EnPXJRmD/pgINBmUAjKFoUUcEeavxIdn4m6Q91hWg+lRLcS7uGbTs8 RU5cUxJhXxSgXrhR6MJ5jUyyTdeNUgyHePCskagNzY+jL26KXDg5nWZFxgNS/stjEIN0 prGQ== X-Gm-Message-State: AJIora9tmN8tGfnCSIdekqtphwkgHmwgG8nhLvgBoexG9n2RcsiA+JOy mYHVpnrQuxocI9A638pC99BcdiiPEHHVWw== X-Google-Smtp-Source: AGRyM1vMMJucTO56qSwUAfN1x/DGf8SV1RXzVLA/D7Srt5tcRAgjYX5K3H7RIa0os0BWhZ08c8Ywhg== X-Received: by 2002:a05:6000:184c:b0:21d:beaf:c2d2 with SMTP id c12-20020a056000184c00b0021dbeafc2d2mr24896897wri.562.1658238535803; Tue, 19 Jul 2022 06:48:55 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Mark Kanda Subject: [PATCH] accel/kvm: Avoid Coverity warning in query_stats() Date: Tue, 19 Jul 2022 14:48:53 +0100 Message-Id: <20220719134853.327059-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1658238881234100001 Content-Type: text/plain; charset="utf-8" Coverity complains that there is a codepath in the query_stats() function where it can leak the memory pointed to by stats_list. This can only happen if the caller passes something other than STATS_TARGET_VM or STATS_TARGET_VCPU as the 'target', which no callsite does. Enforce this assumption using g_assert_not_reached(), so that if we have a future bug we hit the assert rather than silently leaking memory. Resolves: Coverity CID 1490140 Fixes: cc01a3f4cadd91e6 ("kvm: Support for querying fd-based stats") Signed-off-by: Peter Maydell --- accel/kvm/kvm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index ed8b6b896ed..eb7fceb3362 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3980,7 +3980,7 @@ static void query_stats(StatsResultList **result, Sta= tsTarget target, stats_list); break; default: - break; + g_assert_not_reached(); } } =20 --=20 2.25.1