[PATCH v2 0/7] Add Qualcomm BMC machines

Jae Hyun Yoo posted 7 patches 1 year, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220627154703.148943-1-quic._5Fjaehyoo@quicinc.com
Maintainers: Peter Maydell <peter.maydell@linaro.org>, "Cédric Le Goater" <clg@kaod.org>, Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>, Titus Rwantare <titusr@google.com>
hw/arm/Kconfig        |   2 +
hw/arm/aspeed.c       |  95 ++++++-
hw/i2c/pmbus_device.c |   6 +-
hw/sensor/Kconfig     |   4 +
hw/sensor/max31785.c  | 573 ++++++++++++++++++++++++++++++++++++++++++
hw/sensor/meson.build |   1 +
6 files changed, 674 insertions(+), 7 deletions(-)
create mode 100644 hw/sensor/max31785.c
[PATCH v2 0/7] Add Qualcomm BMC machines
Posted by Jae Hyun Yoo 1 year, 10 months ago
Hello,

I'm sending a series to add Qualcomm BMC machines that are equipped with
Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device
emulation. Please help to review.

Thanks,

Jae

Changes in v2:
* Fixed a typo in QCOM DC-SCM V1 HW strap value comment. (Rebecca)
* Removed a useless change which is reverted by the next patch. (Joel)
* Changed machine name to 'qcom-firework-bmc'. (Cedric)
* Dropped FRU eeprom initialization part. (Patrick)
* Fixed comment for a case of PB_ALL_PAGES. (Titus)
* Removed an error log printing when it handles PB_ALL_PAGES. (Jae)
* Fixed a typo in copyright in max31785.c. (Rebecca)
* Fixed indentation issues in max31785.c. (Titus)
* Fixed license identifier style and refined indentation of defines. (Jae)
* Added PMBUS and MAX31785 config selection under ASPEED_SOC. (Titus)
* Moved machine updating part from the previous patch. (Cedric)
* Refined code to avoid retouching by the next patch. (Joel)

Graeme Gregory (1):
  hw/arm/aspeed: add Qualcomm Firework BMC machine

Jae Hyun Yoo (2):
  hw/arm/aspeed: add support for the Qualcomm DC-SCM v1 board
  hw/arm/aspeed: firework: add I2C MUXes for VR channels

Maheswara Kurapati (4):
  hw/i2c: pmbus: Page #255 is valid page for read requests.
  hw/sensor: add Maxim MAX31785 device
  hw/arm/aspeed: Add MAX31785 Fan controllers
  hw/arm/aspeed: firework: Add Thermal Diodes

 hw/arm/Kconfig        |   2 +
 hw/arm/aspeed.c       |  95 ++++++-
 hw/i2c/pmbus_device.c |   6 +-
 hw/sensor/Kconfig     |   4 +
 hw/sensor/max31785.c  | 573 ++++++++++++++++++++++++++++++++++++++++++
 hw/sensor/meson.build |   1 +
 6 files changed, 674 insertions(+), 7 deletions(-)
 create mode 100644 hw/sensor/max31785.c

-- 
2.25.1
Re: [PATCH v2 0/7] Add Qualcomm BMC machines
Posted by Cédric Le Goater 1 year, 10 months ago
Hello Titus,

On 6/27/22 17:46, Jae Hyun Yoo wrote:
> Hello,
> 
> I'm sending a series to add Qualcomm BMC machines that are equipped with
> Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device
> emulation. Please help to review.
> 
> Thanks,
> 
> Jae
> 
> Changes in v2:
> * Fixed a typo in QCOM DC-SCM V1 HW strap value comment. (Rebecca)
> * Removed a useless change which is reverted by the next patch. (Joel)
> * Changed machine name to 'qcom-firework-bmc'. (Cedric)
> * Dropped FRU eeprom initialization part. (Patrick)
> * Fixed comment for a case of PB_ALL_PAGES. (Titus)
> * Removed an error log printing when it handles PB_ALL_PAGES. (Jae)
> * Fixed a typo in copyright in max31785.c. (Rebecca)
> * Fixed indentation issues in max31785.c. (Titus)
> * Fixed license identifier style and refined indentation of defines. (Jae)
> * Added PMBUS and MAX31785 config selection under ASPEED_SOC. (Titus)
> * Moved machine updating part from the previous patch. (Cedric)
> * Refined code to avoid retouching by the next patch. (Joel)
> 
> Graeme Gregory (1):
>    hw/arm/aspeed: add Qualcomm Firework BMC machine
> 
> Jae Hyun Yoo (2):
>    hw/arm/aspeed: add support for the Qualcomm DC-SCM v1 board
>    hw/arm/aspeed: firework: add I2C MUXes for VR channels
> 
> Maheswara Kurapati (4):
>    hw/i2c: pmbus: Page #255 is valid page for read requests.
>    hw/sensor: add Maxim MAX31785 device
>    hw/arm/aspeed: Add MAX31785 Fan controllers
>    hw/arm/aspeed: firework: Add Thermal Diodes
> 
>   hw/arm/Kconfig        |   2 +
>   hw/arm/aspeed.c       |  95 ++++++-
>   hw/i2c/pmbus_device.c |   6 +-
>   hw/sensor/Kconfig     |   4 +
>   hw/sensor/max31785.c  | 573 ++++++++++++++++++++++++++++++++++++++++++
>   hw/sensor/meson.build |   1 +
>   6 files changed, 674 insertions(+), 7 deletions(-)
>   create mode 100644 hw/sensor/max31785.c

Will you handle the pmbus/sensor patches or would you mind if I took them
through the aspeed branch ?

Thanks,

C.
Re: [PATCH v2 0/7] Add Qualcomm BMC machines
Posted by Titus Rwantare 1 year, 10 months ago
You can take them through the aspeed branch.

Thanks.

-Titus

On Mon, 27 Jun 2022 at 09:33, Cédric Le Goater <clg@kaod.org> wrote:
>
> Hello Titus,
>
> On 6/27/22 17:46, Jae Hyun Yoo wrote:
> > Hello,
> >
> > I'm sending a series to add Qualcomm BMC machines that are equipped with
> > Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device
> > emulation. Please help to review.
> >
> > Thanks,
> >
> > Jae
> >
> > Changes in v2:
> > * Fixed a typo in QCOM DC-SCM V1 HW strap value comment. (Rebecca)
> > * Removed a useless change which is reverted by the next patch. (Joel)
> > * Changed machine name to 'qcom-firework-bmc'. (Cedric)
> > * Dropped FRU eeprom initialization part. (Patrick)
> > * Fixed comment for a case of PB_ALL_PAGES. (Titus)
> > * Removed an error log printing when it handles PB_ALL_PAGES. (Jae)
> > * Fixed a typo in copyright in max31785.c. (Rebecca)
> > * Fixed indentation issues in max31785.c. (Titus)
> > * Fixed license identifier style and refined indentation of defines. (Jae)
> > * Added PMBUS and MAX31785 config selection under ASPEED_SOC. (Titus)
> > * Moved machine updating part from the previous patch. (Cedric)
> > * Refined code to avoid retouching by the next patch. (Joel)
> >
> > Graeme Gregory (1):
> >    hw/arm/aspeed: add Qualcomm Firework BMC machine
> >
> > Jae Hyun Yoo (2):
> >    hw/arm/aspeed: add support for the Qualcomm DC-SCM v1 board
> >    hw/arm/aspeed: firework: add I2C MUXes for VR channels
> >
> > Maheswara Kurapati (4):
> >    hw/i2c: pmbus: Page #255 is valid page for read requests.
> >    hw/sensor: add Maxim MAX31785 device
> >    hw/arm/aspeed: Add MAX31785 Fan controllers
> >    hw/arm/aspeed: firework: Add Thermal Diodes
> >
> >   hw/arm/Kconfig        |   2 +
> >   hw/arm/aspeed.c       |  95 ++++++-
> >   hw/i2c/pmbus_device.c |   6 +-
> >   hw/sensor/Kconfig     |   4 +
> >   hw/sensor/max31785.c  | 573 ++++++++++++++++++++++++++++++++++++++++++
> >   hw/sensor/meson.build |   1 +
> >   6 files changed, 674 insertions(+), 7 deletions(-)
> >   create mode 100644 hw/sensor/max31785.c
>
> Will you handle the pmbus/sensor patches or would you mind if I took them
> through the aspeed branch ?
>
> Thanks,
>
> C.
>
>