[v4] target/arm: Cleanups, new features, new cpus

[PATCH v4 15/45] target/arm: Use bool for is64 and ns in add_cpreg_to_hashtable

Posted by Richard Henderson 3 years, 9 months ago

Bool is a more appropriate type for these variables.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index b2887d63b6..c6d407f93b 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -8507,8 +8507,8 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
      */
     uint32_t key;
     ARMCPRegInfo *r2;
-    int is64 = (r->type & ARM_CP_64BIT) ? 1 : 0;
-    int ns = (secstate & ARM_CP_SECSTATE_NS) ? 1 : 0;
+    bool is64 = r->type & ARM_CP_64BIT;
+    bool ns = secstate & ARM_CP_SECSTATE_NS;
     int cp = r->cp;
     size_t name_len;
 
-- 
2.34.1

Re: [PATCH v4 15/45] target/arm: Use bool for is64 and ns in add_cpreg_to_hashtable

Posted by Peter Maydell 3 years, 9 months ago

On Sun, 1 May 2022 at 07:13, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Bool is a more appropriate type for these variables.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/helper.c | 4 ++--

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM