[PATCH v2 3/3] util/osdep: Remove some early cruft

Andrew Deason posted 3 patches 3 years, 11 months ago
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>
There is a newer version of this series
[PATCH v2 3/3] util/osdep: Remove some early cruft
Posted by Andrew Deason 3 years, 11 months ago
The include for statvfs.h has not been needed since all statvfs calls
were removed in commit 4a1418e07bdc ("Unbreak large mem support by
removing kqemu").

The comment mentioning CONFIG_BSD hasn't made sense since an include
for config-host.h was removed in commit aafd75841001 ("util: Clean up
includes").

Remove this cruft.

Signed-off-by: Andrew Deason <adeason@sinenomine.net>
---
 util/osdep.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/util/osdep.c b/util/osdep.c
index 560ce9111a..ed932a0c7c 100644
--- a/util/osdep.c
+++ b/util/osdep.c
@@ -17,26 +17,20 @@
  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 
-/* Needed early for CONFIG_BSD etc. */
-
-#ifdef CONFIG_SOLARIS
-#include <sys/statvfs.h>
-#endif
-
 #ifdef HAVE_MADVISE_MISSING_PROTOTYPE
 /* See MySQL bug #7156 (http://bugs.mysql.com/bug.php?id=7156) for
    discussion about Solaris header problems */
 extern int madvise(char *, size_t, int);
 #endif
 
 #include "qemu-common.h"
 #include "qemu/cutils.h"
 #include "qemu/sockets.h"
 #include "qemu/error-report.h"
-- 
2.11.0
Re: [PATCH v2 3/3] util/osdep: Remove some early cruft
Posted by Peter Maydell 3 years, 11 months ago
On Tue, 15 Mar 2022 at 02:20, Andrew Deason <adeason@sinenomine.net> wrote:
>
> The include for statvfs.h has not been needed since all statvfs calls
> were removed in commit 4a1418e07bdc ("Unbreak large mem support by
> removing kqemu").
>
> The comment mentioning CONFIG_BSD hasn't made sense since an include
> for config-host.h was removed in commit aafd75841001 ("util: Clean up
> includes").
>
> Remove this cruft.
>
> Signed-off-by: Andrew Deason <adeason@sinenomine.net>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM