With these minor fixes, I can build qemu on Solaris 11.4.42 CBE
(Oracle's new rolling release thing), using '--disable-rdma
--enable-modules --disable-dbus-display --target-list=x86_64-softmmu'.
I'm just interested in the guest agent right now, so that's all I've
tested (briefly), but the rest of the build wasn't hard to get working.
With this, the guest agent runs fine using isa-serial.

Changes since v2:
- Rename new symbol to HAVE_MADVISE_WITHOUT_PROTOTYPE
- Move madvise prototype to include/qemu/osdep.h
- More comments in meson.build

Changes since v1:
- Change the CONFIG_MADVISE checks to not be platform-specific
- Add the last commit removing util/osdep.c cruft

Andrew Deason (3):
  util/osdep: Avoid madvise proto on modern Solaris
  hw/i386/acpi-build: Avoid 'sun' identifier
  util/osdep: Remove some early cruft

 hw/i386/acpi-build.c |  4 ++--
 include/qemu/osdep.h |  8 ++++++++
 meson.build          | 23 +++++++++++++++++++++--
 util/osdep.c         | 10 ----------
 4 files changed, 31 insertions(+), 14 deletions(-)

-- 
2.11.0

On Tue, Mar 15, 2022 at 10:52:24PM -0500, Andrew Deason wrote:
> With these minor fixes, I can build qemu on Solaris 11.4.42 CBE
> (Oracle's new rolling release thing), using '--disable-rdma
> --enable-modules --disable-dbus-display --target-list=x86_64-softmmu'.
> I'm just interested in the guest agent right now, so that's all I've
> tested (briefly), but the rest of the build wasn't hard to get working.
> With this, the guest agent runs fine using isa-serial.

Who's merging this? Me?

> Changes since v2:
> - Rename new symbol to HAVE_MADVISE_WITHOUT_PROTOTYPE
> - Move madvise prototype to include/qemu/osdep.h
> - More comments in meson.build
> 
> Changes since v1:
> - Change the CONFIG_MADVISE checks to not be platform-specific
> - Add the last commit removing util/osdep.c cruft
> 
> Andrew Deason (3):
>   util/osdep: Avoid madvise proto on modern Solaris
>   hw/i386/acpi-build: Avoid 'sun' identifier
>   util/osdep: Remove some early cruft
> 
>  hw/i386/acpi-build.c |  4 ++--
>  include/qemu/osdep.h |  8 ++++++++
>  meson.build          | 23 +++++++++++++++++++++--
>  util/osdep.c         | 10 ----------
>  4 files changed, 31 insertions(+), 14 deletions(-)
> 
> -- 
> 2.11.0

On Wed, 16 Mar 2022 at 08:55, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Mar 15, 2022 at 10:52:24PM -0500, Andrew Deason wrote:
> > With these minor fixes, I can build qemu on Solaris 11.4.42 CBE
> > (Oracle's new rolling release thing), using '--disable-rdma
> > --enable-modules --disable-dbus-display --target-list=x86_64-softmmu'.
> > I'm just interested in the guest agent right now, so that's all I've
> > tested (briefly), but the rest of the build wasn't hard to get working.
> > With this, the guest agent runs fine using isa-serial.
>
> Who's merging this? Me?

I'm putting together a pullreq this morning anyway, so I can
take it through target-arm.next.

thanks
-- PMM