[v3] tcg: support 32-bit guest addresses as signed

[PATCH v3 0/9] tcg: support 32-bit guest addresses as signed

Richard Henderson posted 9 patches 2 years, 1 month ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220303191551.466631-1-richard.henderson@linaro.org

Test checkpatch passed

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, Laurent Vivier <laurent@vivier.eu>, WANG Xuerui <git@xen0n.name>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Aurelien Jarno <aurelien@aurel32.net>, Huacai Chen <chenhuacai@kernel.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <Alistair.Francis@wdc.com>, Stefan Weil <sw@weilnetz.de>

include/exec/cpu-all.h            | 20 ++++++--
include/exec/cpu_ldst.h           |  3 +-
tcg/aarch64/tcg-target-sa32.h     |  7 +++
tcg/arm/tcg-target-sa32.h         |  1 +
tcg/i386/tcg-target-sa32.h        |  1 +
tcg/loongarch64/tcg-target-sa32.h |  1 +
tcg/mips/tcg-target-sa32.h        |  9 ++++
tcg/ppc/tcg-target-sa32.h         |  1 +
tcg/riscv/tcg-target-sa32.h       |  5 ++
tcg/s390x/tcg-target-sa32.h       |  1 +
tcg/sparc/tcg-target-sa32.h       |  1 +
tcg/tci/tcg-target-sa32.h         |  1 +
accel/tcg/cputlb.c                | 36 +++++++++-----
bsd-user/main.c                   |  4 ++
linux-user/elfload.c              | 62 ++++++++++++++++++-----
linux-user/main.c                 |  3 ++
tcg/tcg.c                         |  4 ++
tcg/aarch64/tcg-target.c.inc      | 81 ++++++++++++++++++++++---------
tcg/loongarch64/tcg-target.c.inc  | 15 +++---
tcg/mips/tcg-target.c.inc         | 10 +---
tcg/riscv/tcg-target.c.inc        |  8 +--
21 files changed, 199 insertions(+), 75 deletions(-)
create mode 100644 tcg/aarch64/tcg-target-sa32.h
create mode 100644 tcg/arm/tcg-target-sa32.h
create mode 100644 tcg/i386/tcg-target-sa32.h
create mode 100644 tcg/loongarch64/tcg-target-sa32.h
create mode 100644 tcg/mips/tcg-target-sa32.h
create mode 100644 tcg/ppc/tcg-target-sa32.h
create mode 100644 tcg/riscv/tcg-target-sa32.h
create mode 100644 tcg/s390x/tcg-target-sa32.h
create mode 100644 tcg/sparc/tcg-target-sa32.h
create mode 100644 tcg/tci/tcg-target-sa32.h

Expand all Fold all

[PATCH v3 0/9] tcg: support 32-bit guest addresses as signed

Posted by Richard Henderson 2 years, 1 month ago

We have 3 hosts that naturally produce sign-extended values,
and have to work extra hard (with 1 or 2 insns) to produce
the zero-extended address that we expect today.

However, it's a simple matter of arithmetic for the middle-end
to require sign-extended addresses instead.  For user-only, we
do have to be careful not to allow a guest object to wrap around
the signed boundary, but that's fairly easily done.

Tested with aarch64, as that's the best hw currently available.

Only patch 6, for tcg/aarch64, is lacking review, which has
been revised to include a AArch64LdstExt enum, per review.
  

r~


Richard Henderson (9):
  tcg: Add TCG_TARGET_SIGNED_ADDR32
  accel/tcg: Split out g2h_tlbe
  accel/tcg: Support TCG_TARGET_SIGNED_ADDR32 for softmmu
  accel/tcg: Add guest_base_signed_addr32 for user-only
  linux-user: Support TCG_TARGET_SIGNED_ADDR32
  tcg/aarch64: Support TCG_TARGET_SIGNED_ADDR32
  tcg/mips: Support TCG_TARGET_SIGNED_ADDR32
  tcg/riscv: Support TCG_TARGET_SIGNED_ADDR32
  tcg/loongarch64: Support TCG_TARGET_SIGNED_ADDR32

 include/exec/cpu-all.h            | 20 ++++++--
 include/exec/cpu_ldst.h           |  3 +-
 tcg/aarch64/tcg-target-sa32.h     |  7 +++
 tcg/arm/tcg-target-sa32.h         |  1 +
 tcg/i386/tcg-target-sa32.h        |  1 +
 tcg/loongarch64/tcg-target-sa32.h |  1 +
 tcg/mips/tcg-target-sa32.h        |  9 ++++
 tcg/ppc/tcg-target-sa32.h         |  1 +
 tcg/riscv/tcg-target-sa32.h       |  5 ++
 tcg/s390x/tcg-target-sa32.h       |  1 +
 tcg/sparc/tcg-target-sa32.h       |  1 +
 tcg/tci/tcg-target-sa32.h         |  1 +
 accel/tcg/cputlb.c                | 36 +++++++++-----
 bsd-user/main.c                   |  4 ++
 linux-user/elfload.c              | 62 ++++++++++++++++++-----
 linux-user/main.c                 |  3 ++
 tcg/tcg.c                         |  4 ++
 tcg/aarch64/tcg-target.c.inc      | 81 ++++++++++++++++++++++---------
 tcg/loongarch64/tcg-target.c.inc  | 15 +++---
 tcg/mips/tcg-target.c.inc         | 10 +---
 tcg/riscv/tcg-target.c.inc        |  8 +--
 21 files changed, 199 insertions(+), 75 deletions(-)
 create mode 100644 tcg/aarch64/tcg-target-sa32.h
 create mode 100644 tcg/arm/tcg-target-sa32.h
 create mode 100644 tcg/i386/tcg-target-sa32.h
 create mode 100644 tcg/loongarch64/tcg-target-sa32.h
 create mode 100644 tcg/mips/tcg-target-sa32.h
 create mode 100644 tcg/ppc/tcg-target-sa32.h
 create mode 100644 tcg/riscv/tcg-target-sa32.h
 create mode 100644 tcg/s390x/tcg-target-sa32.h
 create mode 100644 tcg/sparc/tcg-target-sa32.h
 create mode 100644 tcg/tci/tcg-target-sa32.h

-- 
2.25.1