[v2] hw/arm/virt: Fix CPU's default NUMA node ID

[PATCH v2 0/3] hw/arm/virt: Fix CPU's default NUMA node ID

Gavin Shan posted 3 patches 2 years, 1 month ago

Diff against v1 v3 v4 v5 v6 v7 v8 v9
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220303031152.145960-1-gshan@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Shannon Zhao <shannon.zhaosl@gmail.com>, Peter Maydell <peter.maydell@linaro.org>

There is a newer version of this series

hw/acpi/aml-build.c      | 106 ++++++++++++++++++++++++++++++---------
hw/arm/virt-acpi-build.c |  12 +++--
hw/arm/virt.c            |  17 ++++++-
3 files changed, 107 insertions(+), 28 deletions(-)

Expand all Fold all

[PATCH v2 0/3] hw/arm/virt: Fix CPU's default NUMA node ID

Posted by Gavin Shan 2 years, 1 month ago

When the CPU-to-NUMA association isn't provided by user, the default NUMA
node ID for the specific CPU is returned from virt_get_default_cpu_node_id().
Unfortunately, the default NUMA node ID breaks socket boundary and leads to
the broken CPU topology warning message in Linux guest. This series intends
to fix the issue.

PATCH[1/3]: Fixes the broken CPU topology by considering the socket boundary
            when the default NUMA node ID is calculated.
PATCH[2/3]: Use the existing CPU topology to build PPTT table. However, the
            cluster ID has to be calculated dynamically because there is no
            corresponding information in CPU instance properties.
PATCH[3/3]: Take thread ID as the ACPI processor ID in MDAT and SRAT tables.

Changelog
=========
v2:
   * Populate the CPU topology in virt_possible_cpu_arch_ids() so that it
     can be reused in virt_get_default_cpu_node_id()                          (Igor)
   * Added PATCH[2/3] to use the existing CPU topology when PPTT table
     is built                                                                 (Igor)
   * Added PATCH[3/3] to take thread ID as ACPI processor ID in MADT and
     SRAT table                                                               (Gavin)

Gavin Shan (3):
  hw/arm/virt: Fix CPU's default NUMA node ID
  hw/acpi/aml-build: Use existing CPU topology to build PPTT table
  hw/arm/virt: Unify ACPI processor ID in MADT and SRAT table

 hw/acpi/aml-build.c      | 106 ++++++++++++++++++++++++++++++---------
 hw/arm/virt-acpi-build.c |  12 +++--
 hw/arm/virt.c            |  17 ++++++-
 3 files changed, 107 insertions(+), 28 deletions(-)

-- 
2.23.0

Re: [PATCH v2 0/3] hw/arm/virt: Fix CPU's default NUMA node ID

Posted by Gavin Shan 2 years, 1 month ago

Hi Igor,

On 3/3/22 11:11 AM, Gavin Shan wrote:
> When the CPU-to-NUMA association isn't provided by user, the default NUMA
> node ID for the specific CPU is returned from virt_get_default_cpu_node_id().
> Unfortunately, the default NUMA node ID breaks socket boundary and leads to
> the broken CPU topology warning message in Linux guest. This series intends
> to fix the issue.
> 
> PATCH[1/3]: Fixes the broken CPU topology by considering the socket boundary
>              when the default NUMA node ID is calculated.
> PATCH[2/3]: Use the existing CPU topology to build PPTT table. However, the
>              cluster ID has to be calculated dynamically because there is no
>              corresponding information in CPU instance properties.
> PATCH[3/3]: Take thread ID as the ACPI processor ID in MDAT and SRAT tables.
> 
> Changelog
> =========
> v2:
>     * Populate the CPU topology in virt_possible_cpu_arch_ids() so that it
>       can be reused in virt_get_default_cpu_node_id()                          (Igor)
>     * Added PATCH[2/3] to use the existing CPU topology when PPTT table
>       is built                                                                 (Igor)
>     * Added PATCH[3/3] to take thread ID as ACPI processor ID in MADT and
>       SRAT table                                                               (Gavin)
> 

Kindly ping. Could you help to review when you have free cycles? :)

Thanks,
Gavin