[v1] hw/nvme: enhanced protection information (64-bit guard)

[PATCH 0/6] hw/nvme: enhanced protection information (64-bit guard)

Klaus Jensen posted 6 patches 3 years, 11 months ago

Diff against v2
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220214123029.106404-1-its@irrelevant.dk

Maintainers: Hanna Reitz <hreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Klaus Jensen <its@irrelevant.dk>, Keith Busch <kbusch@kernel.org>, Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>

There is a newer version of this series

hw/nvme/ctrl.c       | 235 +++++++++++++++++++++------
hw/nvme/dif.c        | 378 +++++++++++++++++++++++++++++++++----------
hw/nvme/dif.h        | 191 ++++++++++++++++++++++
hw/nvme/ns.c         |  27 +++-
hw/nvme/nvme.h       |  58 +------
hw/nvme/trace-events |  12 +-
include/block/nvme.h |  81 ++++++++--
7 files changed, 774 insertions(+), 208 deletions(-)
create mode 100644 hw/nvme/dif.h

Expand all Fold all

[PATCH 0/6] hw/nvme: enhanced protection information (64-bit guard)

Posted by Klaus Jensen 3 years, 11 months ago

From: Klaus Jensen <k.jensen@samsung.com>

This adds support for one possible new protection information format
introduced in TP4068 (and integrated in NVMe 2.0): the 64-bit CRC guard
and 48-bit reference tag. This version does not support storage tags.

Like the CRC16 support already present, this uses a software
implementation of CRC64 (so it is naturally pretty slow). But its good
enough for verification purposes.

This goes hand-in-hand with the support that Keith submitted for the
Linux kernel[1].

[1]: https://lore.kernel.org/linux-nvme/20220201190128.3075065-1-kbusch@kernel.org/

Klaus Jensen (3):
  hw/nvme: move dif/pi prototypes into dif.h
  hw/nvme: move format parameter parsing
  hw/nvme: add pi tuple size helper

Naveen Nagar (3):
  hw/nvme: add host behavior support feature
  hw/nvme: add support for the lbafee hbs feature
  hw/nvme: 64-bit pi support

 hw/nvme/ctrl.c       | 235 +++++++++++++++++++++------
 hw/nvme/dif.c        | 378 +++++++++++++++++++++++++++++++++----------
 hw/nvme/dif.h        | 191 ++++++++++++++++++++++
 hw/nvme/ns.c         |  27 +++-
 hw/nvme/nvme.h       |  58 +------
 hw/nvme/trace-events |  12 +-
 include/block/nvme.h |  81 ++++++++--
 7 files changed, 774 insertions(+), 208 deletions(-)
 create mode 100644 hw/nvme/dif.h

-- 
2.35.1

Re: [PATCH 0/6] hw/nvme: enhanced protection information (64-bit guard)

Posted by Keith Busch 3 years, 11 months ago

On Mon, Feb 14, 2022 at 01:30:23PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> This adds support for one possible new protection information format
> introduced in TP4068 (and integrated in NVMe 2.0): the 64-bit CRC guard
> and 48-bit reference tag. This version does not support storage tags.
> 
> Like the CRC16 support already present, this uses a software
> implementation of CRC64 (so it is naturally pretty slow). But its good
> enough for verification purposes.
> 
> This goes hand-in-hand with the support that Keith submitted for the
> Linux kernel[1].
> 
> [1]: https://lore.kernel.org/linux-nvme/20220201190128.3075065-1-kbusch@kernel.org/

Other than comment on 6/6, series looks good to me.

Reviewed-by: Keith Busch <kbusch@kernel.org>