[v2] hw/nvme: enhanced protection information (64-bit guard)

[PATCH v2 0/6] hw/nvme: enhanced protection information (64-bit guard)

Klaus Jensen posted 6 patches 2 years, 2 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220301104428.160017-1-its@irrelevant.dk

Test checkpatch passed

Maintainers: Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

hw/nvme/ctrl.c       | 235 +++++++++++++++++++++------
hw/nvme/dif.c        | 378 +++++++++++++++++++++++++++++++++----------
hw/nvme/dif.h        | 191 ++++++++++++++++++++++
hw/nvme/ns.c         |  50 ++++--
hw/nvme/nvme.h       |  58 +------
hw/nvme/trace-events |  12 +-
include/block/nvme.h |  81 ++++++++--
7 files changed, 793 insertions(+), 212 deletions(-)
create mode 100644 hw/nvme/dif.h

Expand all Fold all

[PATCH v2 0/6] hw/nvme: enhanced protection information (64-bit guard)

Posted by Klaus Jensen 2 years, 2 months ago

From: Klaus Jensen <k.jensen@samsung.com>

This adds support for one possible new protection information format
introduced in TP4068 (and integrated in NVMe 2.0): the 64-bit CRC guard
and 48-bit reference tag. This version does not support storage tags.

Like the CRC16 support already present, this uses a software
implementation of CRC64 (so it is naturally pretty slow). But its good
enough for verification purposes.

This goes hand-in-hand with the support that Keith submitted for the
Linux kernel[1].

  [1]: https://lore.kernel.org/linux-nvme/20220201190128.3075065-1-kbusch@kernel.org/

Changes since v1
~~~~~~~~~~~~~~~~
- Check metadata size depending on pi guard type selected. (Keith)

Klaus Jensen (3):
  hw/nvme: move dif/pi prototypes into dif.h
  hw/nvme: move format parameter parsing
  hw/nvme: add pi tuple size helper

Naveen Nagar (3):
  hw/nvme: add host behavior support feature
  hw/nvme: add support for the lbafee hbs feature
  hw/nvme: 64-bit pi support

 hw/nvme/ctrl.c       | 235 +++++++++++++++++++++------
 hw/nvme/dif.c        | 378 +++++++++++++++++++++++++++++++++----------
 hw/nvme/dif.h        | 191 ++++++++++++++++++++++
 hw/nvme/ns.c         |  50 ++++--
 hw/nvme/nvme.h       |  58 +------
 hw/nvme/trace-events |  12 +-
 include/block/nvme.h |  81 ++++++++--
 7 files changed, 793 insertions(+), 212 deletions(-)
 create mode 100644 hw/nvme/dif.h

-- 
2.35.1

Re: [PATCH v2 0/6] hw/nvme: enhanced protection information (64-bit guard)

Posted by Keith Busch 2 years, 2 months ago

On Tue, Mar 01, 2022 at 11:44:22AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> This adds support for one possible new protection information format
> introduced in TP4068 (and integrated in NVMe 2.0): the 64-bit CRC guard
> and 48-bit reference tag. This version does not support storage tags.
> 
> Like the CRC16 support already present, this uses a software
> implementation of CRC64 (so it is naturally pretty slow). But its good
> enough for verification purposes.
> 
> This goes hand-in-hand with the support that Keith submitted for the
> Linux kernel[1].
> 
>   [1]: https://lore.kernel.org/linux-nvme/20220201190128.3075065-1-kbusch@kernel.org/

Thanks Klaus, this looks good to me.

Reviewed-by: Keith Busch <kbusch@kernel.org>