[v1] target/rx: Remove unused ENV_OFFSET definition

[PATCH] target/rx: Remove unused ENV_OFFSET definition

Posted by Philippe Mathieu-Daudé via 2 years, 2 months ago

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/rx/cpu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/rx/cpu.h b/target/rx/cpu.h
index 657db84ef0..58adf9edf6 100644
--- a/target/rx/cpu.h
+++ b/target/rx/cpu.h
@@ -116,8 +116,6 @@ struct RXCPU {
 
 typedef RXCPU ArchCPU;
 
-#define ENV_OFFSET offsetof(RXCPU, env)
-
 #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
 #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
 #define CPU_RESOLVING_TYPE TYPE_RX_CPU
-- 
2.34.1

Re: [PATCH] target/rx: Remove unused ENV_OFFSET definition

Posted by Yoshinori Sato 2 years, 2 months ago

On Sat, 22 Jan 2022 09:23:04 +0900,
Philippe Mathieu-Daudé via wrote:
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/rx/cpu.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 657db84ef0..58adf9edf6 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -116,8 +116,6 @@ struct RXCPU {
>  
>  typedef RXCPU ArchCPU;
>  
> -#define ENV_OFFSET offsetof(RXCPU, env)
> -
>  #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
>  #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
>  #define CPU_RESOLVING_TYPE TYPE_RX_CPU
> -- 
> 2.34.1
> 
> 

Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

-- 
Yosinori Sato

Re: [PATCH] target/rx: Remove unused ENV_OFFSET definition

Posted by Richard Henderson 2 years, 2 months ago

On 1/22/22 11:23 AM, Philippe Mathieu-Daudé via wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/rx/cpu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 657db84ef0..58adf9edf6 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -116,8 +116,6 @@ struct RXCPU {
>   
>   typedef RXCPU ArchCPU;
>   
> -#define ENV_OFFSET offsetof(RXCPU, env)
> -
>   #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
>   #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
>   #define CPU_RESOLVING_TYPE TYPE_RX_CPU
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

For the viewers at home, the last use of ENV_OFFSET was removed in 
5e1401969b25f676fee6b1c564441759cf967a43; the commit of target/rx came in just afterward.


r~