[v2] target/rx: Remove unused ENV_OFFSET definition

[PATCH v2] target/rx: Remove unused ENV_OFFSET definition

Philippe Mathieu-Daudé via posted 1 patch 2 years, 3 months ago

Diff against v1
Download mbox

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220203001252.37982-1-f4bug@amsat.org

target/rx/cpu.h | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH v2] target/rx: Remove unused ENV_OFFSET definition

Posted by Philippe Mathieu-Daudé via 2 years, 3 months ago

The last use of ENV_OFFSET was removed in 5e1401969b
("cpu: Move icount_decr to CPUNegativeOffsetState");
the commit of target/rx came in just afterward.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/rx/cpu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/rx/cpu.h b/target/rx/cpu.h
index 657db84ef0..58adf9edf6 100644
--- a/target/rx/cpu.h
+++ b/target/rx/cpu.h
@@ -116,8 +116,6 @@ struct RXCPU {
 
 typedef RXCPU ArchCPU;
 
-#define ENV_OFFSET offsetof(RXCPU, env)
-
 #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
 #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
 #define CPU_RESOLVING_TYPE TYPE_RX_CPU
-- 
2.34.1

Re: [PATCH v2] target/rx: Remove unused ENV_OFFSET definition

Posted by Laurent Vivier 2 years, 2 months ago

Le 03/02/2022 à 01:12, Philippe Mathieu-Daudé via a écrit :
> The last use of ENV_OFFSET was removed in 5e1401969b
> ("cpu: Move icount_decr to CPUNegativeOffsetState");
> the commit of target/rx came in just afterward.
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/rx/cpu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 657db84ef0..58adf9edf6 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -116,8 +116,6 @@ struct RXCPU {
>   
>   typedef RXCPU ArchCPU;
>   
> -#define ENV_OFFSET offsetof(RXCPU, env)
> -
>   #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
>   #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
>   #define CPU_RESOLVING_TYPE TYPE_RX_CPU

Applied to my trivial-patches branch.

Thanks,
Laurent