[PATCH 1/2] roms/edk2: Only init brotli submodule to build BaseTools

Philippe Mathieu-Daudé posted 2 patches 4 years, 3 months ago
There is a newer version of this series
[PATCH 1/2] roms/edk2: Only init brotli submodule to build BaseTools
Posted by Philippe Mathieu-Daudé 4 years, 3 months ago
Since EDK2 BaseTools only require the brotli submodule,
we don't need to initialize other submodules at to build it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 roms/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/roms/Makefile b/roms/Makefile
index eeb5970348c..b967b53bb76 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -143,7 +143,8 @@ build-efi-roms: build-pxe-roms
 #    efirom
 #
 edk2-basetools:
-	cd edk2/BaseTools && git submodule update --init --force
+	cd edk2/BaseTools && git submodule update --init --force \
+		Source/C/BrotliCompress/brotli
 	$(MAKE) -C edk2/BaseTools \
 		PYTHON_COMMAND=$${EDK2_PYTHON_COMMAND:-python3} \
 		EXTRA_OPTFLAGS='$(EDK2_BASETOOLS_OPTFLAGS)' \
-- 
2.31.1

Re: [PATCH 1/2] roms/edk2: Only init brotli submodule to build BaseTools
Posted by Thomas Huth 4 years, 3 months ago
On 18/10/2021 11.23, Philippe Mathieu-Daudé wrote:
> Since EDK2 BaseTools only require the brotli submodule,
> we don't need to initialize other submodules at to build it.

s/at to/to/

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   roms/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/roms/Makefile b/roms/Makefile
> index eeb5970348c..b967b53bb76 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -143,7 +143,8 @@ build-efi-roms: build-pxe-roms
>   #    efirom
>   #
>   edk2-basetools:
> -	cd edk2/BaseTools && git submodule update --init --force
> +	cd edk2/BaseTools && git submodule update --init --force \
> +		Source/C/BrotliCompress/brotli
>   	$(MAKE) -C edk2/BaseTools \
>   		PYTHON_COMMAND=$${EDK2_PYTHON_COMMAND:-python3} \
>   		EXTRA_OPTFLAGS='$(EDK2_BASETOOLS_OPTFLAGS)' \

Reviewed-by: Thomas Huth <thuth@redhat.com>