[PATCH v2 0/2] roms/edk2: Avoid cloning unused cmocka submodule

Philippe Mathieu-Daudé posted 2 patches 2 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211018105816.2663195-1-philmd@redhat.com
.gitlab-ci.d/edk2.yml | 6 +++++-
roms/Makefile         | 3 ++-
roms/Makefile.edk2    | 7 ++++++-
scripts/make-release  | 7 ++++++-
4 files changed, 19 insertions(+), 4 deletions(-)
[PATCH v2 0/2] roms/edk2: Avoid cloning unused cmocka submodule
Posted by Philippe Mathieu-Daudé 2 years, 6 months ago
cmocka website SSL certificate expired, making CI pipelines
fail [*]. However EDK2 images built to test QEMU don't need
cmocka, nor oniguruma. Avoid cloning them.

Note: scripts/make-release is neither covered in MAINTAINERS
      nor in our CI.

[*] https://gitlab.com/rth7680/qemu/-/jobs/1685387520
fatal: unable to access 'https://git.cryptomilk.org/projects/cmocka.git/': server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
fatal: clone of 'https://git.cryptomilk.org/projects/cmocka.git' into submodule path 'UnitTestFrameworkPkg/Library/CmockaLib/cmocka' failed

Since v1:
- Fixed typo (thuth)
- Added missing '--' shell separator

Philippe Mathieu-Daudé (2):
  roms/edk2: Only init brotli submodule to build BaseTools
  roms/edk2: Only initialize required submodules

 .gitlab-ci.d/edk2.yml | 6 +++++-
 roms/Makefile         | 3 ++-
 roms/Makefile.edk2    | 7 ++++++-
 scripts/make-release  | 7 ++++++-
 4 files changed, 19 insertions(+), 4 deletions(-)

-- 
2.31.1


Re: [PATCH v2 0/2] roms/edk2: Avoid cloning unused cmocka submodule
Posted by Gerd Hoffmann 2 years, 6 months ago
On Mon, Oct 18, 2021 at 12:58:14PM +0200, Philippe Mathieu-Daudé wrote:
> cmocka website SSL certificate expired, making CI pipelines
> fail [*]. However EDK2 images built to test QEMU don't need
> cmocka, nor oniguruma. Avoid cloning them.
> 
> Note: scripts/make-release is neither covered in MAINTAINERS
>       nor in our CI.
> 
> [*] https://gitlab.com/rth7680/qemu/-/jobs/1685387520
> fatal: unable to access 'https://git.cryptomilk.org/projects/cmocka.git/': server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
> fatal: clone of 'https://git.cryptomilk.org/projects/cmocka.git' into submodule path 'UnitTestFrameworkPkg/Library/CmockaLib/cmocka' failed
> 
> Since v1:
> - Fixed typo (thuth)
> - Added missing '--' shell separator

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>


Re: [PATCH v2 0/2] roms/edk2: Avoid cloning unused cmocka submodule
Posted by Richard Henderson 2 years, 6 months ago
On 10/18/21 3:58 AM, Philippe Mathieu-Daudé wrote:
> cmocka website SSL certificate expired, making CI pipelines
> fail [*]. However EDK2 images built to test QEMU don't need
> cmocka, nor oniguruma. Avoid cloning them.
> 
> Note: scripts/make-release is neither covered in MAINTAINERS
>        nor in our CI.
> 
> [*] https://gitlab.com/rth7680/qemu/-/jobs/1685387520
> fatal: unable to access 'https://git.cryptomilk.org/projects/cmocka.git/': server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
> fatal: clone of 'https://git.cryptomilk.org/projects/cmocka.git' into submodule path 'UnitTestFrameworkPkg/Library/CmockaLib/cmocka' failed
> 
> Since v1:
> - Fixed typo (thuth)
> - Added missing '--' shell separator
> 
> Philippe Mathieu-Daudé (2):
>    roms/edk2: Only init brotli submodule to build BaseTools
>    roms/edk2: Only initialize required submodules

Thanks a lot.

Tested-by: Richard Henderson <richard.henderson@linaro.org>

I'll queue this to target-arm.next.


r~

Re: [PATCH v2 0/2] roms/edk2: Avoid cloning unused cmocka submodule
Posted by Philippe Mathieu-Daudé 2 years, 6 months ago
On 10/18/21 20:10, Richard Henderson wrote:
> On 10/18/21 3:58 AM, Philippe Mathieu-Daudé wrote:
>> cmocka website SSL certificate expired, making CI pipelines
>> fail [*]. However EDK2 images built to test QEMU don't need
>> cmocka, nor oniguruma. Avoid cloning them.
>>
>> Note: scripts/make-release is neither covered in MAINTAINERS
>>        nor in our CI.
>>
>> [*] https://gitlab.com/rth7680/qemu/-/jobs/1685387520
>> fatal: unable to access
>> 'https://git.cryptomilk.org/projects/cmocka.git/': server certificate
>> verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt
>> CRLfile: none
>> fatal: clone of 'https://git.cryptomilk.org/projects/cmocka.git' into
>> submodule path 'UnitTestFrameworkPkg/Library/CmockaLib/cmocka' failed
>>
>> Since v1:
>> - Fixed typo (thuth)
>> - Added missing '--' shell separator
>>
>> Philippe Mathieu-Daudé (2):
>>    roms/edk2: Only init brotli submodule to build BaseTools
>>    roms/edk2: Only initialize required submodules
> 
> Thanks a lot.
> 
> Tested-by: Richard Henderson <richard.henderson@linaro.org>
> 
> I'll queue this to target-arm.next.

If you don't have anything in your queue I can send a pullreq
tomorrow, otherwise thanks for taking care of it.


Re: [PATCH v2 0/2] roms/edk2: Avoid cloning unused cmocka submodule
Posted by Richard Henderson 2 years, 6 months ago
On 10/18/21 11:53 AM, Philippe Mathieu-Daudé wrote:
> If you don't have anything in your queue I can send a pullreq
> tomorrow, otherwise thanks for taking care of it.

I do have a few other patches already in the queue.
I'll take care of it.


r~