[PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b

Eric Auger posted 3 patches 2 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211014115643.756977-1-eric.auger@redhat.com
Maintainers: Shannon Zhao <shannon.zhaosl@gmail.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, "Michael S. Tsirkin" <mst@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
hw/arm/virt-acpi-build.c          |  48 ++++++++++++++++++------------
tests/data/acpi/virt/IORT         | Bin 124 -> 128 bytes
tests/data/acpi/virt/IORT.memhp   | Bin 124 -> 128 bytes
tests/data/acpi/virt/IORT.numamem | Bin 124 -> 128 bytes
tests/data/acpi/virt/IORT.pxb     | Bin 124 -> 128 bytes
5 files changed, 29 insertions(+), 19 deletions(-)
[PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b
Posted by Eric Auger 2 years, 6 months ago
This series upgrades the ACPI IORT table up to the E.b
specification revision. One of the goal of this upgrade
is to allow the addition of RMR nodes along with the SMMUv3.

The latest IORT specification (ARM DEN 0049E.b) can be found at
IO Remapping Table - Platform Design Document
https://developer.arm.com/documentation/den0049/latest/

This series can be found at
https://github.com/eauger/qemu.git
branch: iort_Eb_v3

History:
v2 -> v3:
- comment on IORT node ID (Igor)
- single mapping disabled comment
- Added Jean and Igor's R-b
- added diff to patvch 3/3

v1 -> v2:
- fix Revision value in ITS and SMMUv3 nodes (Phil)
- Increment an identifier (Phil)

Eric Auger (3):
  tests/acpi: Get prepared for IORT E.b revision upgrade
  hw/arm/virt-acpi-build: IORT upgrade up to revision E.b
  tests/acpi: Generate reference blob for IORT rev E.b

 hw/arm/virt-acpi-build.c          |  48 ++++++++++++++++++------------
 tests/data/acpi/virt/IORT         | Bin 124 -> 128 bytes
 tests/data/acpi/virt/IORT.memhp   | Bin 124 -> 128 bytes
 tests/data/acpi/virt/IORT.numamem | Bin 124 -> 128 bytes
 tests/data/acpi/virt/IORT.pxb     | Bin 124 -> 128 bytes
 5 files changed, 29 insertions(+), 19 deletions(-)

-- 
2.26.3


Re: [PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b
Posted by Michael S. Tsirkin 2 years, 6 months ago
On Thu, Oct 14, 2021 at 01:56:40PM +0200, Eric Auger wrote:
> This series upgrades the ACPI IORT table up to the E.b
> specification revision. One of the goal of this upgrade
> is to allow the addition of RMR nodes along with the SMMUv3.
> 
> The latest IORT specification (ARM DEN 0049E.b) can be found at
> IO Remapping Table - Platform Design Document
> https://developer.arm.com/documentation/den0049/latest/
> 
> This series can be found at
> https://github.com/eauger/qemu.git
> branch: iort_Eb_v3

ACPI things look good

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

ARM only so ARM tree?

> History:
> v2 -> v3:
> - comment on IORT node ID (Igor)
> - single mapping disabled comment
> - Added Jean and Igor's R-b
> - added diff to patvch 3/3
> 
> v1 -> v2:
> - fix Revision value in ITS and SMMUv3 nodes (Phil)
> - Increment an identifier (Phil)
> 
> Eric Auger (3):
>   tests/acpi: Get prepared for IORT E.b revision upgrade
>   hw/arm/virt-acpi-build: IORT upgrade up to revision E.b
>   tests/acpi: Generate reference blob for IORT rev E.b
> 
>  hw/arm/virt-acpi-build.c          |  48 ++++++++++++++++++------------
>  tests/data/acpi/virt/IORT         | Bin 124 -> 128 bytes
>  tests/data/acpi/virt/IORT.memhp   | Bin 124 -> 128 bytes
>  tests/data/acpi/virt/IORT.numamem | Bin 124 -> 128 bytes
>  tests/data/acpi/virt/IORT.pxb     | Bin 124 -> 128 bytes
>  5 files changed, 29 insertions(+), 19 deletions(-)
> 
> -- 
> 2.26.3


Re: [PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b
Posted by Richard Henderson 2 years, 6 months ago
On 10/14/21 5:05 AM, Michael S. Tsirkin wrote:
> On Thu, Oct 14, 2021 at 01:56:40PM +0200, Eric Auger wrote:
>> This series upgrades the ACPI IORT table up to the E.b
>> specification revision. One of the goal of this upgrade
>> is to allow the addition of RMR nodes along with the SMMUv3.
>>
>> The latest IORT specification (ARM DEN 0049E.b) can be found at
>> IO Remapping Table - Platform Design Document
>> https://developer.arm.com/documentation/den0049/latest/
>>
>> This series can be found at
>> https://github.com/eauger/qemu.git
>> branch: iort_Eb_v3
> 
> ACPI things look good
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ARM only so ARM tree?

Sure, I can take it through target-arm.


r~

Re: [PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b
Posted by Eric Auger 2 years, 6 months ago
Hi,

On 10/14/21 1:56 PM, Eric Auger wrote:
> This series upgrades the ACPI IORT table up to the E.b
> specification revision. One of the goal of this upgrade
> is to allow the addition of RMR nodes along with the SMMUv3.

while I have sent a separate RFC to expose RMR nodes along with SMMUv3 I
must aknowledge this will take time to be upstreamed (SMMUv3 nested
stage thingy), if ever, and this anyway requires additional time to mature:
- there is one problem with the IORT spec which mandates 1 RMR node per
BDF and also
- there is the issue of the boot preserve_config which was known to
introduce some regressions and which is also mandated by the IORT spec.

So I wanted to emphasize that this IORT upgrade does not come at the
moment with any new feature. My understanding is old guests should work
fine with this new revision but if you feel that's a bad thing, please
raise your voice.

Thanks

Eric
>
> The latest IORT specification (ARM DEN 0049E.b) can be found at
> IO Remapping Table - Platform Design Document
> https://developer.arm.com/documentation/den0049/latest/
>
> This series can be found at
> https://github.com/eauger/qemu.git
> branch: iort_Eb_v3
>
> History:
> v2 -> v3:
> - comment on IORT node ID (Igor)
> - single mapping disabled comment
> - Added Jean and Igor's R-b
> - added diff to patvch 3/3
>
> v1 -> v2:
> - fix Revision value in ITS and SMMUv3 nodes (Phil)
> - Increment an identifier (Phil)
>
> Eric Auger (3):
>   tests/acpi: Get prepared for IORT E.b revision upgrade
>   hw/arm/virt-acpi-build: IORT upgrade up to revision E.b
>   tests/acpi: Generate reference blob for IORT rev E.b
>
>  hw/arm/virt-acpi-build.c          |  48 ++++++++++++++++++------------
>  tests/data/acpi/virt/IORT         | Bin 124 -> 128 bytes
>  tests/data/acpi/virt/IORT.memhp   | Bin 124 -> 128 bytes
>  tests/data/acpi/virt/IORT.numamem | Bin 124 -> 128 bytes
>  tests/data/acpi/virt/IORT.pxb     | Bin 124 -> 128 bytes
>  5 files changed, 29 insertions(+), 19 deletions(-)
>


Re: [PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b
Posted by Richard Henderson 2 years, 6 months ago
On 10/14/21 4:56 AM, Eric Auger wrote:
> This series upgrades the ACPI IORT table up to the E.b
> specification revision. One of the goal of this upgrade
> is to allow the addition of RMR nodes along with the SMMUv3.
> 
> The latest IORT specification (ARM DEN 0049E.b) can be found at
> IO Remapping Table - Platform Design Document
> https://developer.arm.com/documentation/den0049/latest/
> 
> This series can be found at
> https://github.com/eauger/qemu.git
> branch: iort_Eb_v3

Queued for target-arm.


r~