[PATCH for-6.2 v2 0/2] target/ppc: Fix vector registers access in gdbstub for little-endian

matheus.ferst@eldorado.org.br posted 2 patches 2 years, 8 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210818110656.1993090-1-matheus.ferst@eldorado.org.br
Maintainers: David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>
There is a newer version of this series
include/qemu/int128.h | 15 +++++++++++++++
target/ppc/gdbstub.c  | 32 +++++++-------------------------
2 files changed, 22 insertions(+), 25 deletions(-)
[PATCH for-6.2 v2 0/2] target/ppc: Fix vector registers access in gdbstub for little-endian
Posted by matheus.ferst@eldorado.org.br 2 years, 8 months ago
From: Matheus Ferst <matheus.ferst@eldorado.org.br>

PPC gdbstub code has two possible swaps of the 64-bit elements of AVR
registers: in gdb_get_avr_reg/gdb_set_avr_reg (based on msr_le) and in
gdb_get_reg128/ldq_p (based on TARGET_WORDS_BIGENDIAN).

In softmmu, only the first is done, because TARGET_WORDS_BIGENDIAN is
always true. In user mode, both are being done, resulting in swapped
high and low doublewords of AVR registers in little-endian binaries.

We fix this by moving the first swap to ppc_maybe_bswap_register, which
already handles the endianness swap of each element's value in softmmu
and does nothing in user mode.

Matheus Ferst (2):
  include/qemu/int128.h: introduce bswap128s
  target/ppc: fix vector registers access in gdbstub for little-endian

 include/qemu/int128.h | 15 +++++++++++++++
 target/ppc/gdbstub.c  | 32 +++++++-------------------------
 2 files changed, 22 insertions(+), 25 deletions(-)

-- 
2.25.1