target/mips: Housekeeping in gen_helper() macros

[PATCH 0/8] target/mips: Housekeeping in gen_helper() macros

Philippe Mathieu-Daudé posted 8 patches 4 years, 5 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210816205107.2051495-1-f4bug@amsat.org

Maintainers: Aurelien Jarno <aurelien@aurel32.net>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

target/mips/tcg/translate.h | 12 +++++++
target/mips/tcg/translate.c | 69 ++++---------------------------------
2 files changed, 19 insertions(+), 62 deletions(-)

Expand all Fold all

[PATCH 0/8] target/mips: Housekeeping in gen_helper() macros

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

Trivial patches:
- Remove unused macros
- Use tcg_constant_i32()
- Inline the macros when few uses
- Move macro definitions in translate.h

Philippe Mathieu-Daudé (8):
  target/mips: Remove gen_helper_0e3i()
  target/mips: Remove gen_helper_1e2i()
  target/mips: Use tcg_constant_i32() in gen_helper_0e2i()
  target/mips: Simplify gen_helper() macros by using tcg_constant_i32()
  target/mips: Inline gen_helper_1e1i() call in op_ld_INSN() macros
  target/mips: Inline gen_helper_0e0i()
  target/mips: Use tcg_constant_i32() in generate_exception_err()
  target/mips: Define gen_helper() macros in translate.h

 target/mips/tcg/translate.h | 12 +++++++
 target/mips/tcg/translate.c | 69 ++++---------------------------------
 2 files changed, 19 insertions(+), 62 deletions(-)

-- 
2.31.1

Re: [PATCH 0/8] target/mips: Housekeeping in gen_helper() macros

Posted by Richard Henderson 4 years, 5 months ago

On 8/16/21 10:50 AM, Philippe Mathieu-Daudé wrote:
> Trivial patches:
> - Remove unused macros
> - Use tcg_constant_i32()
> - Inline the macros when few uses
> - Move macro definitions in translate.h
> 
> Philippe Mathieu-Daudé (8):
>    target/mips: Remove gen_helper_0e3i()
>    target/mips: Remove gen_helper_1e2i()
>    target/mips: Use tcg_constant_i32() in gen_helper_0e2i()
>    target/mips: Simplify gen_helper() macros by using tcg_constant_i32()
>    target/mips: Inline gen_helper_1e1i() call in op_ld_INSN() macros
>    target/mips: Inline gen_helper_0e0i()
>    target/mips: Use tcg_constant_i32() in generate_exception_err()
>    target/mips: Define gen_helper() macros in translate.h

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH 0/8] target/mips: Housekeeping in gen_helper() macros

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

On 8/17/21 4:52 PM, Richard Henderson wrote:
> On 8/16/21 10:50 AM, Philippe Mathieu-Daudé wrote:
>> Trivial patches:
>> - Remove unused macros
>> - Use tcg_constant_i32()
>> - Inline the macros when few uses
>> - Move macro definitions in translate.h
>>
>> Philippe Mathieu-Daudé (8):
>>    target/mips: Remove gen_helper_0e3i()
>>    target/mips: Remove gen_helper_1e2i()
>>    target/mips: Use tcg_constant_i32() in gen_helper_0e2i()
>>    target/mips: Simplify gen_helper() macros by using tcg_constant_i32()
>>    target/mips: Inline gen_helper_1e1i() call in op_ld_INSN() macros
>>    target/mips: Inline gen_helper_0e0i()
>>    target/mips: Use tcg_constant_i32() in generate_exception_err()
>>    target/mips: Define gen_helper() macros in translate.h
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks, series applied to mips-next.