From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) client-ip=209.85.221.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147077; cv=none; d=zohomail.com; s=zohoarc; b=X6SvxM9S41czU1gdr6FIzwEGJvjXyqxi1xKCUpKzkGFAx5RjqwvE9leELnP/tmUR4RA9UwPcFnRJ2D1/R9yjqZ40Mef+f8eAqAOXFz2o4WrUyFlabuYUdZTDXIVwuAm2YC332t5PgmonhCh1GftN79Kg5zEC13mkeX9zxaOI0oM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147077; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=guPfsm+TdDEggxYauLResM2Qs6zxvhc5Miqakb7nXb4=; b=Tq9lOZ7ZrwHDsK8XtGwi12P1JMx3YeAxEuVM9UHNqMmmxuiuIHdJabQzR++ZfKeF9tn6ivbe11lvJdT9rfsdnBipZCvEQDW6w3qdnMAgae3PEamRmZqw/BAgZ860WqVLflmhFADMUg2k+s0VYgD82ApP6aPt1BcamIwCJ5FfQY8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.zohomail.com with SMTPS id 16291470776861013.2690535672266; Mon, 16 Aug 2021 13:51:17 -0700 (PDT) Received: by mail-wr1-f49.google.com with SMTP id k29so25386923wrd.7 for ; Mon, 16 Aug 2021 13:51:17 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id p18sm335560wrt.13.2021.08.16.13.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=guPfsm+TdDEggxYauLResM2Qs6zxvhc5Miqakb7nXb4=; b=W6TT/wnZp+2ZUhb3pM4GknHB0LbF86q7+ziSXfeaAjL87gOcB+XYNFT/NmZeB8AH7P lmLOamsNrzibtmbdjBefpoVHrhkcjtb5xnCzm7rpBqTjLzOBaXpYMhfmMduzDSa8eRXt hhhnw3xiunPe3Fo/tHmGpKpdFtYkdLatCJB7WKEwKZvF9gWbt0SFXE+ooQL10x6pLtrV i/M5csLvwwoAkBeK1T1fARiHBiwcPV9VYv1FYZ6Y7XyOWfqoeQwaYjcFjXtu67/ADUsY x/eA2WUmqKKGjQS9eiCrEARlddAjqfN1Nk574D4Yjy7kYBRsAPxKduxlLrMOhsIGfGRZ TOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=guPfsm+TdDEggxYauLResM2Qs6zxvhc5Miqakb7nXb4=; b=feudSzUK6XyhTbgpRg0UKDG8xHt/1amRM3EkZ8JgTnaFT2QRwpdQje7W01MuIYuvIe 3MdMON2zCmiBZkMlXRZaZeA17Ma+3XN7jn1mj0jjq5bpNY/UAAG4AQhwdAgOBoe5MBNi u1J/9GBr1BOyiLiywDMwAYFV4Qk9xKxIVA6tfRKs/vzeTQfR4LKcgr/6ShxiAJJNfGIE 1AgRf2pJ9cyhKMadbwWfGlMGGGX+Lcse3zx8EOZKyYd89UXUq9/HgQJ51acC4NjYd+3/ WbQzEi4AwxbGy6aa9FHW9JSkJ2z8zdOEPB/exuG4/Uu9cBojJnBp07ecxVo/uNR2rtqM a8dA== X-Gm-Message-State: AOAM533nRLGSA/9WTZyyeBvXClLlwF8pQ50XVAcmNIxjj1C2ePQBojjG VOpCtKZCiX6dVdg/8zvlQ3w= X-Google-Smtp-Source: ABdhPJyKo/uR9AhqBzYTy7zwvxPP2M0fV5Ug/rxt30eXXKz4qv94GzWHGZTkJsWz9tKer9LC9UOfXw== X-Received: by 2002:a5d:45c9:: with SMTP id b9mr321875wrs.395.1629147075982; Mon, 16 Aug 2021 13:51:15 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 1/8] target/mips: Remove gen_helper_0e3i() Date: Mon, 16 Aug 2021 22:51:00 +0200 Message-Id: <20210816205107.2051495-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147078343100001 gen_helper_0e3i() is unused since commit 895c2d04359 ("target-mips: switch to AREG0 free mode"), remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index a58d50e40e2..c0f8a04b472 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1249,12 +1249,6 @@ TCGv_i64 fpu_f64[32]; tcg_temp_free_i32(helper_tmp); \ } while (0) =20 -#define gen_helper_0e3i(name, arg1, arg2, arg3, arg4) do { \ - TCGv_i32 helper_tmp =3D tcg_const_i32(arg4); \ - gen_helper_##name(cpu_env, arg1, arg2, arg3, helper_tmp); \ - tcg_temp_free_i32(helper_tmp); \ - } while (0) - #define DISAS_STOP DISAS_TARGET_0 #define DISAS_EXIT DISAS_TARGET_1 =20 --=20 2.31.1 From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147083; cv=none; d=zohomail.com; s=zohoarc; b=n2ADoFWzPz+7fUdb6sInobMonRqX9ByBGhg1y3bn0PkhDJv46qdg3B4fvJSgsOVuaKcayhlBpgl1mwEOFDCZPxTMwwSJ3b48ujn99uNFUC5sM3PekxNgkcESppIy5jDwmTRmOrCzFCePVChTAFy+Uy/Ut2uXo2cI1/SLK82u/cU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147083; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OxEJXC7lL6JkeE88O86XD/Gz40sjVZOycwNQPdJyF4g=; b=AqBpXK3X6UQmkFJ4+yAemCHXsqGaSo4nNjB3IEcVtC5YEdh8MqK/11gf+1Zo8NUySe+fA0t5DfElXBZpMC1/n+8ZF4E+aZnb2QGiM9rtaV//cw0UfgnN1NcOZEdazIi07dXpfOah/B1pxY1YExdd9d7SecWJk863LNaEMZOEzLc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1629147083017845.1541314820406; Mon, 16 Aug 2021 13:51:23 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id f5so25344481wrm.13 for ; Mon, 16 Aug 2021 13:51:22 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id t1sm256821wma.25.2021.08.16.13.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OxEJXC7lL6JkeE88O86XD/Gz40sjVZOycwNQPdJyF4g=; b=i1l5hgEQaq9V4Y5y7/bSnpgr3qvoP/wo+WS+TV/3DgKZiTP2bRMY+voiUoe7i4md9F HBaO2+pifvW/UnHJyekRpcTdte9T+Z7n0vMd1uv1iaBxynAcbqwTqLLMnRxlwpEcdOZt /KWZJg0DA0FwHCoC8WAA7uDTFGtVh0Zxx62Z1FCfv7NonYFkUnza994oLmfS0zBe0GFr Hsdp00TZ+LAiJ927plojPQMwK9/Uz50VNm//v8JGHypvGtHkQ7qdHsc8gVfmvxe/ZAfY f4ee9xwnUJI9Sw/LhCI7SytJZIj9spIx1bIsmE0teo8O5DlXp6TjwJq2gf81Wxz8esem UmhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OxEJXC7lL6JkeE88O86XD/Gz40sjVZOycwNQPdJyF4g=; b=jGb6IOodI5sPqgFHrs8H/gPhvWlcTu0/u0iJOoJ/XOQ+lbrAoQ2GXczr57DWnJWv4N DmHaUTPjhJSyIRgzZ8zK5tyHp7q1gxiwsQGY/piszmgDGzajZN+ibBFvOUSlm0ZvrLfp WuorKMX5XBdCKEJjhjLjqjq1KRQnaW0//ZaMb/RhhmtNrUasNtrCyOo5X0r1lp6jUr1D OReBEcxlOCK8DsAmTD7iYE19TwMEuWfRqsxU4TNiKCflK2QqpQlZVv/fYA2Mz93hoiON ODkh44nQE1ogUq4tFPbDK59aa+2UdXED9w+CqQ6zoTWSHRjYJBIjmATNJlGmzJxr/cBC P12w== X-Gm-Message-State: AOAM5318q/86RugYi27kJbCZRvKCYBB3I1JhF7kqwQx3reyldVBnwyo0 4u6h4NA4+ujKN7DZOjZNRtw= X-Google-Smtp-Source: ABdhPJz/IZTOHsjLIQeLVsNCQ4Tl/MVfrQ1bIRMEHMWb8RPSXNpgO76mxduu9IErhioD+xIhSVn0sA== X-Received: by 2002:adf:eb4c:: with SMTP id u12mr352581wrn.111.1629147081252; Mon, 16 Aug 2021 13:51:21 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 2/8] target/mips: Remove gen_helper_1e2i() Date: Mon, 16 Aug 2021 22:51:01 +0200 Message-Id: <20210816205107.2051495-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147084297100001 gen_helper_1e2i() is unused since commit 33a07fa2db6 ("target/mips: reimplement SC instruction emulation and use cmpxchg"), remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index c0f8a04b472..4b689a54abb 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1243,12 +1243,6 @@ TCGv_i64 fpu_f64[32]; tcg_temp_free_i32(helper_tmp); \ } while (0) =20 -#define gen_helper_1e2i(name, ret, arg1, arg2, arg3) do { \ - TCGv_i32 helper_tmp =3D tcg_const_i32(arg3); \ - gen_helper_##name(ret, cpu_env, arg1, arg2, helper_tmp); \ - tcg_temp_free_i32(helper_tmp); \ - } while (0) - #define DISAS_STOP DISAS_TARGET_0 #define DISAS_EXIT DISAS_TARGET_1 =20 --=20 2.31.1 From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147088; cv=none; d=zohomail.com; s=zohoarc; b=M1gSuq0SLySJL+28RD1+2xvu8t5oP+peyMRNnIGhjh4I0Rnw0+AzLgmMR+jzENlSstmr+CnDhbw8HBzAJDjZBHGRGsBO7VZm/VeRiWuA41FWPUo7FpB2iALTT5aupF4fQsT/eG8Ri4evumluTvak76NFQfQW75AtE/BB4Uk+9ZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147088; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GtKKMYiZbBb9B3CylCfPpnK/bsEC2eXZoeUds5kPPEs=; b=id3oAWnU7ZwznayZDz322t69se6dQeTO8CJKV3Pf8gQnXeAEXe1idzJZiTziUTonp9TpVskTRVByNKN8nO0NjpAEbhZq7tbgOLM9GExq1FmdsoTpKf007f0wxKPMalndkdZyLmP7n1L8w81MdI/shnUsbdrQCHbZTbsidKWUTr8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1629147088380672.2405167049526; Mon, 16 Aug 2021 13:51:28 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id i10-20020a05600c354ab029025a0f317abfso322019wmq.3 for ; Mon, 16 Aug 2021 13:51:27 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id u23sm248143wmc.24.2021.08.16.13.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GtKKMYiZbBb9B3CylCfPpnK/bsEC2eXZoeUds5kPPEs=; b=mdj5qPW1/dEQUec6bVB0rjczF78LNA/K07l7+/Nqf9SaeMNAJyj9wxBXcuDQfw9VJC sem2FN2hkINWqy6Ya3JIS5W7Pqfjn45EqCX6sfdkRsvYrGx/Q4s+OFu3YXUZhybfZnWK WhfohftUuVovNnXSouhS0Yjz7Zusdy2oyZKIZZ7mWCoxPpfjfQl5L9f3AxIRbGrsvtMQ mp+IunZARl1H4d3ojuyQKcaMSB1wj40JnWtXV13KnntVSwpbX6D4L7x28OerLw/F72kd Mb94DagYGVomTX25A6WYorn2q3IZPdKOfxD1yO/6XJUoN2Jw6dcnWauPGaf3PKtJpldo UTlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GtKKMYiZbBb9B3CylCfPpnK/bsEC2eXZoeUds5kPPEs=; b=jnQlqZ1JSXC3gOFhwftdgVGPjrVg3Ncj9V71myVmSYNqXsNlHoq14jd7e0+HRODT0p rd98oEIrFx19jIS/VPwMXgeYYctSMk5Pa6T4EX84DUMuh/HHwii/RUGVkLCDw1zqXNnJ 36vPsz+TzSM7D+mI4lIel2Fis3u+/q740dZBXfIuYDGOe9aw0KmZbnUxOISwmL8+Nwrn 8g2JhAbya2U2aKiHGkYNvTqenZTKGwIVGqyonIjFJ2cRuZAy7P/QI4lipLkOa6dgfEnT bheM36ZPwSrceSlXmThwofNCAcxSNEeIBudJuVpGfU+wwTqAR9hzT4jlFxawsoWIglhO a7Jg== X-Gm-Message-State: AOAM533KQqb9WzFMFsBZfP751mZMBkqjU6ROKl13ro6xD5x9Qtu0hPfc Uyn3yEd8dxnodqrbrJwD4eY= X-Google-Smtp-Source: ABdhPJzR3pC6gm6J0esrQx1eKv7x1As0QoJkpsH+H49Rh0EEblmMWBpECglh6JTQRHVFLE0T/safZA== X-Received: by 2002:a7b:ce8b:: with SMTP id q11mr116452wmj.30.1629147086646; Mon, 16 Aug 2021 13:51:26 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 3/8] target/mips: Use tcg_constant_i32() in gen_helper_0e2i() Date: Mon, 16 Aug 2021 22:51:02 +0200 Message-Id: <20210816205107.2051495-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147088721100001 $rt register is used read-only, so we can replace tcg_const_i32() temporary by tcg_constant_i32(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 4b689a54abb..a6df9beb670 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -9072,12 +9072,7 @@ static void gen_mttr(CPUMIPSState *env, DisasContext= *ctx, int rd, int rt, break; case 3: /* XXX: For now we support only a single FPU context. */ - { - TCGv_i32 fs_tmp =3D tcg_const_i32(rd); - - gen_helper_0e2i(ctc1, t0, fs_tmp, rt); - tcg_temp_free_i32(fs_tmp); - } + gen_helper_0e2i(ctc1, t0, tcg_constant_i32(rd), rt); /* Stop translation as we may have changed hflags */ ctx->base.is_jmp =3D DISAS_STOP; break; @@ -9694,12 +9689,7 @@ static void gen_cp1(DisasContext *ctx, uint32_t opc,= int rt, int fs) case OPC_CTC1: gen_load_gpr(t0, rt); save_cpu_state(ctx, 0); - { - TCGv_i32 fs_tmp =3D tcg_const_i32(fs); - - gen_helper_0e2i(ctc1, t0, fs_tmp, rt); - tcg_temp_free_i32(fs_tmp); - } + gen_helper_0e2i(ctc1, t0, tcg_constant_i32(fs), rt); /* Stop translation as we may have changed hflags */ ctx->base.is_jmp =3D DISAS_STOP; break; --=20 2.31.1 From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) client-ip=209.85.128.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147097; cv=none; d=zohomail.com; s=zohoarc; b=bomuEqGJbkLn8dmLXJNMtoO8MElyGNablZf+cYKheijdvMOurYo/tCbrQuFnv6o9gi6iJXJf8LZAcBtoXrhZVXFnHwu0mwoXW9EYiqeDuBRy2Ubb3KZMnQjt3Um0dt2HY/abc+pri600GaVVx9Xnuu/1AsR5LltIc8zJY3C/GwQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147097; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fOI0Xq/yRFXEojrjAhdK5X3UPqy2n/2RHJEemazAjlo=; b=krsK1liCoe1ie8GtLSId61tiXYIZ7W5v3rL7H15v/jjd5mirk2gfTuRBQ2Typ7TTVc/FaEmRGnhcmV4QGCXIzsWchnL33rtFnO9JwjDEFqUi/UyyYO+3O/9Au9kawK6c2vYeO29D5CTsx95pORCQ6xuaMbHLpjkFaCrX9Be9A2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.zohomail.com with SMTPS id 1629147097137577.715452460639; Mon, 16 Aug 2021 13:51:37 -0700 (PDT) Received: by mail-wm1-f47.google.com with SMTP id k5-20020a05600c1c85b02902e699a4d20cso762472wms.2 for ; Mon, 16 Aug 2021 13:51:36 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id d8sm357996wrv.20.2021.08.16.13.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fOI0Xq/yRFXEojrjAhdK5X3UPqy2n/2RHJEemazAjlo=; b=I/TZCly8B9D4v8JLkUYNqDn7e6rMgW4/LWc2oYrOKZaJmwfPzJhKyzg9umsDNMyc9V tAo0WdGWyxDYagtzKwdlvuSyrKAbHqFRX1MNTHKT2lZ+eqKnBom+4cxPXEuzyoQACIqc 2BjH81uwyQbfcVyJ4YBJDzFPHnC6VMFm+U93lyy3XsZZmrPxEDuoVADWlPf0jLV00/8k YtRwcD9RKuWgnanReFZhm5Xwj5yTCshhcWxT5+pVXol8SSHvc0j6gf7W6maPJWrXaeFt tCUt8j6GllYXXSpnbOTNmP8GKW6KzGlry27HJjAl7fqUWDDov6BMjRYcslj4FbKRJHs3 UNiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fOI0Xq/yRFXEojrjAhdK5X3UPqy2n/2RHJEemazAjlo=; b=c4UK1NW9tiueC1qRa8w1IndowRJmir4hShHYzfc/DAv0v/4wwYcjM6pnS9QVP9pCBp CnTUSb2OLFaTuNxRuuxNs1ytTGyfMs69mQmgY1zgNuErpcni9KkXXwRWYZIr/kxv1jQz yVm8+HjtFVhEwAqGHnt5zzzvvg5ILJh/FhbqsM+4YzipH6ZyEPJ3l+95u5w8K33Yp3vR FKv1RpVHUaW2SwidVjsg5JHKiLWOQRcqOmVLkXtJA0KQeMDKr0NeadnQx5k/Faw7ioA4 UKfCxMOcqNJU2HJLTOBp6Yt1kMIWhDeXPm3mw4+PwojYbcbd+YOGX4GmfvHN2i/yTmQQ N/9Q== X-Gm-Message-State: AOAM532jyHLIM7ga6XOcHjWQQTOAt4aqUWsSNq+TPIG2aH32T4IuDtJV la9ZiO6RjNW4UhBTdvJd1lo= X-Google-Smtp-Source: ABdhPJyMONWKjI1Qphje7irLm5DgISEG2liC2xcU2WvLCTYgdcKJmTjqZWabsaSa3TSeAPkwepYc6w== X-Received: by 2002:a7b:ce04:: with SMTP id m4mr103708wmc.110.1629147095223; Mon, 16 Aug 2021 13:51:35 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 4/8] target/mips: Simplify gen_helper() macros by using tcg_constant_i32() Date: Mon, 16 Aug 2021 22:51:03 +0200 Message-Id: <20210816205107.2051495-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147097438100001 In all call sites the last argument is always used as a read-only value, so we can replace tcg_const_i32() temporary by tcg_constant_i32(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index a6df9beb670..3417fc433ff 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1214,33 +1214,23 @@ TCGv_i64 fpu_f64[32]; #include "exec/gen-icount.h" =20 #define gen_helper_0e0i(name, arg) do { \ - TCGv_i32 helper_tmp =3D tcg_const_i32(arg); \ - gen_helper_##name(cpu_env, helper_tmp); \ - tcg_temp_free_i32(helper_tmp); \ + gen_helper_##name(cpu_env, tcg_constant_i32(arg)); \ } while (0) =20 #define gen_helper_0e1i(name, arg1, arg2) do { \ - TCGv_i32 helper_tmp =3D tcg_const_i32(arg2); \ - gen_helper_##name(cpu_env, arg1, helper_tmp); \ - tcg_temp_free_i32(helper_tmp); \ + gen_helper_##name(cpu_env, arg1, tcg_constant_i32(arg2)); \ } while (0) =20 #define gen_helper_1e0i(name, ret, arg1) do { \ - TCGv_i32 helper_tmp =3D tcg_const_i32(arg1); \ - gen_helper_##name(ret, cpu_env, helper_tmp); \ - tcg_temp_free_i32(helper_tmp); \ + gen_helper_##name(ret, cpu_env, tcg_constant_i32(arg1)); \ } while (0) =20 #define gen_helper_1e1i(name, ret, arg1, arg2) do { \ - TCGv_i32 helper_tmp =3D tcg_const_i32(arg2); \ - gen_helper_##name(ret, cpu_env, arg1, helper_tmp); \ - tcg_temp_free_i32(helper_tmp); \ + gen_helper_##name(ret, cpu_env, arg1, tcg_constant_i32(arg2));\ } while (0) =20 #define gen_helper_0e2i(name, arg1, arg2, arg3) do { \ - TCGv_i32 helper_tmp =3D tcg_const_i32(arg3); \ - gen_helper_##name(cpu_env, arg1, arg2, helper_tmp); \ - tcg_temp_free_i32(helper_tmp); \ + gen_helper_##name(cpu_env, arg1, arg2, tcg_constant_i32(arg3));\ } while (0) =20 #define DISAS_STOP DISAS_TARGET_0 --=20 2.31.1 From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147102; cv=none; d=zohomail.com; s=zohoarc; b=mu7DLZdzNdd2JiD/hEvmIGl0VESPuuxtWRbPgtvGar6ITCD/uPno3hfKHflymlJL69zJKs8rzu0AX3YtUicpkorm/S14CX7dnLG0Rk5SM3nOCaibWXCBS+EoRj2Ap1+7Dwy7QbCrKn+ywPDrXEInX6RBK1+pzM2XZJRg95Zhq7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147102; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gav3+6zKBq62//SE6jKBrLCgBATlNlx3yZjFm4+Th44=; b=lYsHGmYf4lbN8wvK5hF/sMm7yDJejzWl6tSqpjuvTEukKsbVFjz0D1udXmgb9npouzY1dxJZcKspdXUwANGc3EpFrZP/UgnEB9A4LcHHlm4USISzaMy08LuAowCWf7ziKmoluPUygoiZV3c8/KK2xz6OlsQVWXoPy3RTdz6gE88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1629147102310865.3288083342408; Mon, 16 Aug 2021 13:51:42 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id g138so12329822wmg.4 for ; Mon, 16 Aug 2021 13:51:41 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id g12sm422846wri.18.2021.08.16.13.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gav3+6zKBq62//SE6jKBrLCgBATlNlx3yZjFm4+Th44=; b=SyeUYEhqgEANbmQ+9QmLF9I9eLPkOeUluvSbCbiglnVbhlXI6EyZYUZkVXy24j7hu5 9dq8NKQFSPhcttjzHkRZWuAFl9/Dr8d+t/lFfwxvB48UrQSfauRMQtJntxp4s+7fm3Zy 1lv+FqNWL7kw/JqJaFx7fHQD15J6FOJ003LQNON3jNo6az4isj33ewzrdsqsOkDqwqBY dntXh11B860g9fKrJZSrtfF4ZPcwkaHuQRjoZ24AvB7skTvj5zgu4D4o/GnMzxNQgBCK q8hFo31urQXGEXYyuNF2v0+g5XcFZltIbhhCofPyhDY3mkrUJYPKApNNFnER1Dhy+CSj qzcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gav3+6zKBq62//SE6jKBrLCgBATlNlx3yZjFm4+Th44=; b=FPGGTHcIJ7cdx4VA67XpTZSOT92NolT71mJo4jFRbLwkvPYbriDmt8jd2WyLo5Ubhz yckn0tnMIWKwFSWovjyYlNpxYeCdgG1xMTNPT77eGq2mpnY8N3QGgkb2gff4eGfB/bl3 HPeFbuxYPtPPtc+yqHIrnA7G/UHAAO4xBFf77NHSErTZqmW2Mi9DTHqMz5uCA4nk/+tr laThGt0yZ5Anxn0n0uiN+C0F0IS2X+FVnN/6hdmpmouUZ9wztx3CEwbCx9+bqFZ9DiHL 8Ck8hRIaXmaKcAiN2Xk1BKF91U1cXya2/M2ab7fXKgEEqI2ySoJMmuiVRkS9kveXH2RO /KBA== X-Gm-Message-State: AOAM533cFXWhxQkPX6JB75WcVZmXuzIGIRS9SgVbhDQGcngMNnKABTnF UMqn62wPUrk1Ui1EBNvbkyE= X-Google-Smtp-Source: ABdhPJwIKzilc2eUGqNGu8mVYkYXaY0NbHTw7tMIEl+/qxwdgQW9eWFAxeivrgoL3N8VfihJ9f5PSQ== X-Received: by 2002:a1c:6a18:: with SMTP id f24mr100248wmc.142.1629147100597; Mon, 16 Aug 2021 13:51:40 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 5/8] target/mips: Inline gen_helper_1e1i() call in op_ld_INSN() macros Date: Mon, 16 Aug 2021 22:51:04 +0200 Message-Id: <20210816205107.2051495-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147104217100001 gen_helper_1e1i() is one-line long and is used in one place: simply inline it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 3417fc433ff..db7fc75d937 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1225,10 +1225,6 @@ TCGv_i64 fpu_f64[32]; gen_helper_##name(ret, cpu_env, tcg_constant_i32(arg1)); \ } while (0) =20 -#define gen_helper_1e1i(name, ret, arg1, arg2) do { \ - gen_helper_##name(ret, cpu_env, arg1, tcg_constant_i32(arg2));\ - } while (0) - #define gen_helper_0e2i(name, arg1, arg2, arg3) do { \ gen_helper_##name(cpu_env, arg1, arg2, tcg_constant_i32(arg3));\ } while (0) @@ -1991,7 +1987,7 @@ static inline void op_ld_##insn(TCGv ret, TCGv arg1, = int mem_idx, \ static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, = \ DisasContext *ctx) = \ { = \ - gen_helper_1e1i(insn, ret, arg1, mem_idx); = \ + gen_helper_##insn(ret, cpu_env, arg1, tcg_constant_i32(mem_idx)); = \ } #endif OP_LD_ATOMIC(ll, ld32s); --=20 2.31.1 From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) client-ip=209.85.128.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147107; cv=none; d=zohomail.com; s=zohoarc; b=a5qAjzt9WiCowuQIYixjug1koI+o65Vne5+G0pRcl8R+kyhG5+stWDJ81nM5eAd9eRm/y/5R/O7EBqIwfJCFx9lBSJ44VGaMTTJZlxc4xffnK42joo1C6EWCXSrOwEwMXOq8r17t6aBRbjDlY9sW/RwsnUhDGXYJMV/0En/rQCA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147107; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pOcKeX6ZT7d2KDzm2dL41WJyOOGp0Wbhe9wsUhWszh8=; b=TgVhI8iFk03pYTc2EwWGoGzJ7E7kzCdMz6x4lBFagyV8WR9hhLLtlKoTHujO69wq5sfAJDso5s+cqF1Xmu2UEqPDzmC2Pc7ovuRr2Fr+aP+QmbnV9wJov5cURRfOAQC1s84MB1whLOAZjG4tJ5yx1kIDpMTUcb5azDJyt/V4Yig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.zohomail.com with SMTPS id 1629147107631277.37670847674565; Mon, 16 Aug 2021 13:51:47 -0700 (PDT) Received: by mail-wm1-f43.google.com with SMTP id a201-20020a1c7fd2000000b002e6d33447f9so631640wmd.0 for ; Mon, 16 Aug 2021 13:51:46 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id g21sm253625wmk.8.2021.08.16.13.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pOcKeX6ZT7d2KDzm2dL41WJyOOGp0Wbhe9wsUhWszh8=; b=uT0a0B9VwcpZ1sIkrkncDmlkCtDdWui9fUzPJUNtSQVpYCUZZp7xejJa0+GojDb4R+ 9EHINpy3ozObpWs3OYRBMLG2jRD1ag2KJ9BL5KJYLiLVpryit5boKgvpi8ErOy1T7ecx wTPsUXWvSpZPb6klul+VUd8tnz30l2bwSw8th/wA4zP3ptkvG9aJGkkTpCyIChMfUn2P qkxEYqFOctupYxvUJiFlZzgPLdNuj5JWfSV63m3YATvClQ53KhGKn9OWZWG4g9Frzuzv Dwcw/CBHKfpmoP7XtHZ2TH3HJyLrqa3PoH5fWau+fJneKQy62fYRwEFAN1XHKKbzQHx6 a0IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pOcKeX6ZT7d2KDzm2dL41WJyOOGp0Wbhe9wsUhWszh8=; b=QHulfIiXCa0QOpfrGWlscfP35yIWG3WtFt3SqOSne6hiiGnc3RIY8F+lm8FHiyPU2y Ecd2Mg/4i+Sl99bJDMLCqvOtFz3+/PHZUdXkSANyDw2Zk5JIqkzcEumD9SiHt3tg1TfV 0Q+1PbysGGLclNmlYK28H292rAzpr47D8B8Fyh9J9Yv5O72DYMuMrNxdhC7ZJg6Hsz2n YWubOAVR/FfI5ThBI318jyIxyZ2NEJUhQjqogRbpRKVEaWHadjB+he7AtlrIG1t/ipK2 cKa/1fR8J00uF7r/oyZJkB04Dj/j6UIX1OrfYbxn9YN/iQnHLMZkkLn+2jYwv+5XVpeI Y0Xw== X-Gm-Message-State: AOAM530FvskuKK9cpVyGB66iUvtX9qmaJd7jj2ZTd5D5FbQ24DnMFl1v 4IiB3C6S+rVHjA2PTHvpyZDtY4/Hp88= X-Google-Smtp-Source: ABdhPJyPsVqnOwJeHdtK7E4FmwgrEbxWQ8U2AqYwvA4/PyaUhJZ7a6nuiUapDS4Xi0x5XU+T3BB9FA== X-Received: by 2002:a05:600c:4fc6:: with SMTP id o6mr104610wmq.122.1629147105796; Mon, 16 Aug 2021 13:51:45 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 6/8] target/mips: Inline gen_helper_0e0i() Date: Mon, 16 Aug 2021 22:51:05 +0200 Message-Id: <20210816205107.2051495-7-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147108314100001 gen_helper_0e0i() is one-line long and is only used twice: simply inline it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index db7fc75d937..c515a337ebc 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1213,10 +1213,6 @@ TCGv_i64 fpu_f64[32]; =20 #include "exec/gen-icount.h" =20 -#define gen_helper_0e0i(name, arg) do { \ - gen_helper_##name(cpu_env, tcg_constant_i32(arg)); \ - } while (0) - #define gen_helper_0e1i(name, arg1, arg2) do { \ gen_helper_##name(cpu_env, arg1, tcg_constant_i32(arg2)); \ } while (0) @@ -1378,7 +1374,7 @@ void generate_exception_err(DisasContext *ctx, int ex= cp, int err) =20 void generate_exception(DisasContext *ctx, int excp) { - gen_helper_0e0i(raise_exception, excp); + gen_helper_raise_exception(cpu_env, tcg_constant_i32(excp)); } =20 void generate_exception_end(DisasContext *ctx, int excp) @@ -14188,7 +14184,7 @@ static void decode_opc_special(CPUMIPSState *env, D= isasContext *ctx) MIPS_INVAL("PMON / selsl"); gen_reserved_instruction(ctx); #else - gen_helper_0e0i(pmon, sa); + gen_helper_pmon(cpu_env, tcg_constant_i32(sa)); #endif break; case OPC_SYSCALL: --=20 2.31.1 From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147112; cv=none; d=zohomail.com; s=zohoarc; b=CcBhCY91qeEQD6HGKL3Vma/JHUS4hzADCaXZPpi9pvCmVIOmArJ8k98fqZaQvnz8wHA/U9d/zMW/+hRxCROXe7466IEbcxAehfUCYxBYuBSUJ5y+r3P2sYnhUb+aFckNVYwlz2Ai364AN2hq4mXguuWM1DvZmjIwlLGMBLRHXFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147112; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FKpak1M/4asc8KoNklCuXW/Sh+X7+tzXxt6gTH+Vi2g=; b=K61Gu1qETM9CJMD8O8IB2QVGWWSfhs1O/2WXE7RQq3H7paYYHrIu6AiRNAqW7JeRxu1CD+2pXG/+FQVtXZxBYRKh0oZrKKkdxoqZ4k3/fGhGLLduITzFGdBG9OpWfzIdnSiZR1+Ka2escp4OMlhiMW+j8/9qwqIDoWXkjYBvRsw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1629147112956912.9168408696677; Mon, 16 Aug 2021 13:51:52 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id r7so25505469wrs.0 for ; Mon, 16 Aug 2021 13:51:52 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id l38sm246659wmp.15.2021.08.16.13.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FKpak1M/4asc8KoNklCuXW/Sh+X7+tzXxt6gTH+Vi2g=; b=ZWmLG5ijxq0c8+Ou+tlOgIrNHs3JLCAw+cn0UYKtzWaR59c6BRmOa6bTc+SR9Xb3rH 6JCv+p0rhabHQPwJli1wg9o4OOjjgB+5m0T+ADaFs3m83Znv1TU16WIQIlYluYOfX8zG EzU9THfww/KQFxokzl9DgmDt9XQgCYVjdcETGCpzXWEK+z2+dggT729NEleMt0PMA8K0 FR7caZWAXXCko0YOeIFPvXFWlOzySd+UOY3CmSjoM9gyUJHnIWjVlrPRJ/XMyaHO0OFW CQOHzCc2W+O7W218N6gXbqJg39q7EPnDgUvHC8A9KgLOpvTJ867Iw7WucfceQAT6D81t P6Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=FKpak1M/4asc8KoNklCuXW/Sh+X7+tzXxt6gTH+Vi2g=; b=O4M3vtuKSDys4ZyddGojLpvHvPk13Ed2TcuiQ3ygdERbRJyw73hcqG0q/jErZ51RiZ WR0qKrxPHWLXL2vlQVmk51OwjCqbmSXa8ORhnVdmlFYMJeUvPkD3GIuPZtrNkrtms1xJ zQnxwbIc/JXTJt9nqusDWRujntvMHFv/kQmF/P5pk+Dd6ecv9RdSq32IZjOyclxlPYYt Gqk9jt6Tn8J7S/s/v41imFBMnm7J593+VPhtautsfxFyXuVM/zfCYYTUfrLOgNpfyDlV QKtSvyI3mHc5bBv+lPS5QDFMVO5bROXRN13vUaMGIznrKLMUZrFE3oJKZABOAwJB6DfP jsSA== X-Gm-Message-State: AOAM532g1oN1Xsud4HbCZoZzl4nITAklCG+wDnEz4O+MOYYVvQL6N8MZ FIkpLnNsQQSwgAswR98gbFs= X-Google-Smtp-Source: ABdhPJzrLWZ+yKuREZC//TGjlCxmxaBsyfpK6BDPV4RC/MVfZrmVBYR/ePyw5lQvhr8oo7Tq3A05cw== X-Received: by 2002:a5d:6108:: with SMTP id v8mr18317wrt.96.1629147111170; Mon, 16 Aug 2021 13:51:51 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 7/8] target/mips: Use tcg_constant_i32() in generate_exception_err() Date: Mon, 16 Aug 2021 22:51:06 +0200 Message-Id: <20210816205107.2051495-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147114801100001 excp/err are temporaries input, so we can replace tcg_const_i32() calls by tcg_constant_i32() equivalent. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index c515a337ebc..93b72c994f2 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1363,12 +1363,9 @@ static inline void restore_cpu_state(CPUMIPSState *e= nv, DisasContext *ctx) =20 void generate_exception_err(DisasContext *ctx, int excp, int err) { - TCGv_i32 texcp =3D tcg_const_i32(excp); - TCGv_i32 terr =3D tcg_const_i32(err); save_cpu_state(ctx, 1); - gen_helper_raise_exception_err(cpu_env, texcp, terr); - tcg_temp_free_i32(terr); - tcg_temp_free_i32(texcp); + gen_helper_raise_exception_err(cpu_env, tcg_constant_i32(excp), + tcg_constant_i32(err)); ctx->base.is_jmp =3D DISAS_NORETURN; } =20 --=20 2.31.1 From nobody Mon Feb 9 12:44:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629147118; cv=none; d=zohomail.com; s=zohoarc; b=D3MiP8nMP96ak9mcRdO+3RUmDq9DJ6mFfF+tYr9xweGJu/WvdC8oORxYPY1oEKmFZRFdNT+SaGA3I1Qd0hKXsRRUS88S+nLV63SC2o7Npsi45/NeTSvwf0A/uz7xteKXYo9jP+FOtkrrhx2Sst4r2cfcrxjWDhs+LP26aMk7Pvw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629147118; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wdZ5zuA1pHnV+y+AJTFvRv79XLVqHrg7+7oNpQDjPU8=; b=hXkqDqlVFbT+RzlcZ5OKmMRYk/8fXYACKjSMtPcOGW8zoYGHp7TlVAqfAvh2tIa/GajzLVR118/3VxOrxhTzrfxsehQRf7WDrSzBtgCZYDwisTaXFJOQgUD10IrK2l6rI0wBn6tQrtax6SK58roKCxgM610c6l29TcaBa2/ctJU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 1629147118784924.0519675541099; Mon, 16 Aug 2021 13:51:58 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id u15so12344676wmj.1 for ; Mon, 16 Aug 2021 13:51:58 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id o10sm309778wrq.51.2021.08.16.13.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 13:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wdZ5zuA1pHnV+y+AJTFvRv79XLVqHrg7+7oNpQDjPU8=; b=dLVVrnU0RBwYHrsaWDYR/vMLsV2l0s+w6Z7HN3tzyuCt2TtoFjPjAIYOXfNFvZ6pNx dRiXQ2eb9fdBXbPXgcaSBU15v7gTC+eSyJhoAH3lLlJbjG+uKVNS8PVJ13XDPQKveA0R n6yQoGJucuIWtZ3dGGiRWZF7dfIv5iuBy+Y/6FIb4GhDQ7+oluNu7RMVpUu09VUMwhMf U3UM/1AWH1ZxEsblmkhcfCFAPuZbgsCmt1wD+92tbgtePdBCXFO73atgVOPz3fGo7hhJ 6J27xeI8ExXkmZEI8QC07pzrapHtx2jTWYQxX9kthQ1/xcKJupVTWXxIDHZ4b5AQ1eEY fU7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wdZ5zuA1pHnV+y+AJTFvRv79XLVqHrg7+7oNpQDjPU8=; b=eaInHIrOCPIXuU6cihaW62WcJigqTqbt2eV/AHG6opMTBdzq5xGtYtruJ220bu2X/V yf2yos0rU5VI3f9nvx7Q1nu3/8JxccoiW+buU/UZKOY0+Z01uqU0CysQI5frJwTN7VHR zNHr/n13KzJg5ENYeXufqaomKUhbJ5lXjUyn9wQfcaWUoDyLf6lCrwllourRo/AreIFw cP1zXYI8BNz+FBwFKr8X4h/8yooNSBp7EekN2616Gaeh6PJCvS9GShkfcYWQc5pg2l3C FetolrYB7it7AIqkqnF721fZ4p36o72BF61Hrb+4hgxa2L5BPVnDm/nZzFm2MAEWs7FW 6sJg== X-Gm-Message-State: AOAM532mv5iTDphH5jULcw5r0615QLTDDkZUTKlS9/C09VJN1L2bhla6 W4VAcmlJEtXR0vBHzB+J2Xw= X-Google-Smtp-Source: ABdhPJy5wFMrItlBfs4yyjygWrGY5PcjRKtnfTdy5SZhHMmgipwdOph8Lh8uM60W5QyKf8zdbWDWMA== X-Received: by 2002:a05:600c:364b:: with SMTP id y11mr50057wmq.11.1629147116790; Mon, 16 Aug 2021 13:51:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson Subject: [PATCH 8/8] target/mips: Define gen_helper() macros in translate.h Date: Mon, 16 Aug 2021 22:51:07 +0200 Message-Id: <20210816205107.2051495-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210816205107.2051495-1-f4bug@amsat.org> References: <20210816205107.2051495-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629147119199100001 To be able to split some code calling the gen_helper() macros out of the huge translate.c, we need to define them in the 'translate.h' local header. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- Will be used in following series. Can resend there as first patch. --- target/mips/tcg/translate.h | 12 ++++++++++++ target/mips/tcg/translate.c | 12 ------------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/translate.h b/target/mips/tcg/translate.h index bb0a6b8d74f..eac01a81182 100644 --- a/target/mips/tcg/translate.h +++ b/target/mips/tcg/translate.h @@ -113,6 +113,18 @@ enum { OPC_BC1TANY4 =3D (0x01 << 16) | OPC_BC1ANY4, }; =20 +#define gen_helper_0e1i(name, arg1, arg2) do { \ + gen_helper_##name(cpu_env, arg1, tcg_constant_i32(arg2)); \ + } while (0) + +#define gen_helper_1e0i(name, ret, arg1) do { \ + gen_helper_##name(ret, cpu_env, tcg_constant_i32(arg1)); \ + } while (0) + +#define gen_helper_0e2i(name, arg1, arg2, arg3) do { \ + gen_helper_##name(cpu_env, arg1, arg2, tcg_constant_i32(arg3));\ + } while (0) + void generate_exception(DisasContext *ctx, int excp); void generate_exception_err(DisasContext *ctx, int excp, int err); void generate_exception_end(DisasContext *ctx, int excp); diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 93b72c994f2..40cb1fc9508 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1213,18 +1213,6 @@ TCGv_i64 fpu_f64[32]; =20 #include "exec/gen-icount.h" =20 -#define gen_helper_0e1i(name, arg1, arg2) do { \ - gen_helper_##name(cpu_env, arg1, tcg_constant_i32(arg2)); \ - } while (0) - -#define gen_helper_1e0i(name, ret, arg1) do { \ - gen_helper_##name(ret, cpu_env, tcg_constant_i32(arg1)); \ - } while (0) - -#define gen_helper_0e2i(name, arg1, arg2, arg3) do { \ - gen_helper_##name(cpu_env, arg1, arg2, tcg_constant_i32(arg3));\ - } while (0) - #define DISAS_STOP DISAS_TARGET_0 #define DISAS_EXIT DISAS_TARGET_1 =20 --=20 2.31.1