[v5] DEVICE_UNPLUG_ERROR QAPI event

[PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc

Daniel Henrique Barboza posted 7 patches 4 years, 7 months ago

Diff against v2 v3 v4 v6
Download mbox

Maintainers: Markus Armbruster <armbru@redhat.com>, Greg Kurz <groug@kaod.org>, "Michael S. Tsirkin" <mst@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eric Blake <eblake@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, David Gibson <david@gibson.dropbear.id.au>

There is a newer version of this series

Expand all Fold all

[PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc

Posted by Daniel Henrique Barboza 4 years, 7 months ago

Clarify that @device is optional and that 'path' is the device
path from QOM.

This change follows Markus' suggestion verbatim, provided in full
context here:

https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01891.html

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 qapi/qdev.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/qdev.json b/qapi/qdev.json
index b83178220b..d1d3681a50 100644
--- a/qapi/qdev.json
+++ b/qapi/qdev.json
@@ -108,9 +108,9 @@
 # At this point, it's safe to reuse the specified device ID. Device removal can
 # be initiated by the guest or by HMP/QMP commands.
 #
-# @device: device name
+# @device: the device's ID if it has one
 #
-# @path: device path
+# @path: the device's path within the object model
 #
 # Since: 1.5
 #
-- 
2.31.1

Re: [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc

Posted by Greg Kurz 4 years, 6 months ago

On Mon, 12 Jul 2021 16:43:36 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:

> Clarify that @device is optional and that 'path' is the device
> path from QOM.
> 
> This change follows Markus' suggestion verbatim, provided in full
> context here:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01891.html
> 
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---

Reviewed-by: Greg Kurz <groug@kaod.org>

>  qapi/qdev.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qapi/qdev.json b/qapi/qdev.json
> index b83178220b..d1d3681a50 100644
> --- a/qapi/qdev.json
> +++ b/qapi/qdev.json
> @@ -108,9 +108,9 @@
>  # At this point, it's safe to reuse the specified device ID. Device removal can
>  # be initiated by the guest or by HMP/QMP commands.
>  #
> -# @device: device name
> +# @device: the device's ID if it has one
>  #
> -# @path: device path
> +# @path: the device's path within the object model
>  #
>  # Since: 1.5
>  #