1. Patchew
  2. QEMU
  3. View series

[PATCH for-6.2 v6 0/7] DEVICE_UNPLUG_ERROR QAPI event

Daniel Henrique Barboza posted 7 patches 2 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210719200827.1507276-1-danielhb413@gmail.com
Maintainers: David Gibson <david@gibson.dropbear.id.au>, Markus Armbruster <armbru@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Greg Kurz <groug@kaod.org>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>
docs/about/deprecated.rst | 10 ++++++++++
hw/acpi/memory_hotplug.c  | 19 +++++++++++++++++--
hw/ppc/spapr.c            | 17 +++++++++++++----
hw/ppc/spapr_drc.c        | 21 +++++++++++++++------
qapi/machine.json         |  6 +++++-
qapi/qdev.json            | 34 +++++++++++++++++++++++++++++++---
stubs/qdev.c              |  7 +++++++
7 files changed, 98 insertions(+), 16 deletions(-)
[PATCH for-6.2 v6 0/7] DEVICE_UNPLUG_ERROR QAPI event
Posted by Daniel Henrique Barboza 2 years, 9 months ago 
Hi,

This version was rebased with QEMU master @ 7457b407edd6e8555e4b4 and
has a few simple changes based on Greg's review.

changes from v5:
- patch 1:
  * fixed function name in commit msg
-patch 6:
  * kept error message in a single line
- all patches:
  * added Greg's R-b
- v5 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg03239.html

changes from v4:
- patch 1 (new):
  * avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL in
memory_hotplug.c
- patch 2 (new):
  * avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL in
spapr.c
- patch 3 (new):
  * do not error_report() when drc->dev->id == NULL
- patch 4 (new):
  * update DEVICE_DELETED API docs
- patch 5 (former 1):
  * added 2 spaces after each sentence
  * appended "Some errors cannot be detected." in DEVICE_UNPLUG_ERROR
docs
  * changed release from 6.1 to 6.2 in docs
  * changed DEVICE_UNPLUG_ERROR API to behave more like device_deleted
- patches 6 and 7:
  * changed to use the new DEVICE_UNPLUG_ERROR API
- v4 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01355.html

changes from v3:
- patch 1:
  * fixed format
- all patches:
  * rebased with master
  * added David's R-b
- v3 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05842.html

changes from v2:
- patch 1:
  * moved DEVICE_UNPLUG_ERROR declaration to qapi/qdev.json
  * updated 'device_del' description
  * added 'deprecated' notice on MEM_UNPLUG_ERROR
  * added MEM_UNPLUG_ERROR 'deprecated' info in docs/system/deprecated.rst
- patch 2:
  * send both MEM_UNPLUG_ERROR and DEVICE_UNPLUG_ERROR
- patch 3 (new):
  * send DEVICE_UNPLUG_ERROR in acpi/memory_hotplug.c
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg01304.html

changes from v1:
- former patches 1 and 2: dropped
- patch 1 (former 3): changed the version to '6.1'
- patch 2 (former 4): add a DEVICE_UNPLUG_ERROR event in the device
  unplug error path of CPUs and DIMMs
- v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04682.html


Daniel Henrique Barboza (7):
  hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is
    NULL
  spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL
  spapr_drc.c: do not error_report() when drc->dev->id == NULL
  qapi/qdev.json: fix DEVICE_DELETED parameters doc
  qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event
  spapr: use DEVICE_UNPLUG_ERROR to report unplug errors
  memory_hotplug.c: send DEVICE_UNPLUG_ERROR in
    acpi_memory_hotplug_write()

 docs/about/deprecated.rst | 10 ++++++++++
 hw/acpi/memory_hotplug.c  | 19 +++++++++++++++++--
 hw/ppc/spapr.c            | 17 +++++++++++++----
 hw/ppc/spapr_drc.c        | 21 +++++++++++++++------
 qapi/machine.json         |  6 +++++-
 qapi/qdev.json            | 34 +++++++++++++++++++++++++++++++---
 stubs/qdev.c              |  7 +++++++
 7 files changed, 98 insertions(+), 16 deletions(-)

-- 
2.31.1
Re: [PATCH for-6.2 v6 0/7] DEVICE_UNPLUG_ERROR QAPI event
Posted by David Gibson 2 years, 9 months ago 
On Mon, Jul 19, 2021 at 05:08:20PM -0300, Daniel Henrique Barboza wrote:
> Hi,
> 
> This version was rebased with QEMU master @ 7457b407edd6e8555e4b4 and
> has a few simple changes based on Greg's review.

Tentatively applied to ppc-for-6.2.
> 
> changes from v5:
> - patch 1:
>   * fixed function name in commit msg
> -patch 6:
>   * kept error message in a single line
> - all patches:
>   * added Greg's R-b
> - v5 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg03239.html
> 
> changes from v4:
> - patch 1 (new):
>   * avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL in
> memory_hotplug.c
> - patch 2 (new):
>   * avoid emitting MEM_UNPLUG_ERROR when dev->id == NULL in
> spapr.c
> - patch 3 (new):
>   * do not error_report() when drc->dev->id == NULL
> - patch 4 (new):
>   * update DEVICE_DELETED API docs
> - patch 5 (former 1):
>   * added 2 spaces after each sentence
>   * appended "Some errors cannot be detected." in DEVICE_UNPLUG_ERROR
> docs
>   * changed release from 6.1 to 6.2 in docs
>   * changed DEVICE_UNPLUG_ERROR API to behave more like device_deleted
> - patches 6 and 7:
>   * changed to use the new DEVICE_UNPLUG_ERROR API
> - v4 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01355.html
> 
> changes from v3:
> - patch 1:
>   * fixed format
> - all patches:
>   * rebased with master
>   * added David's R-b
> - v3 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05842.html
> 
> changes from v2:
> - patch 1:
>   * moved DEVICE_UNPLUG_ERROR declaration to qapi/qdev.json
>   * updated 'device_del' description
>   * added 'deprecated' notice on MEM_UNPLUG_ERROR
>   * added MEM_UNPLUG_ERROR 'deprecated' info in docs/system/deprecated.rst
> - patch 2:
>   * send both MEM_UNPLUG_ERROR and DEVICE_UNPLUG_ERROR
> - patch 3 (new):
>   * send DEVICE_UNPLUG_ERROR in acpi/memory_hotplug.c
> - v2 link: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg01304.html
> 
> changes from v1:
> - former patches 1 and 2: dropped
> - patch 1 (former 3): changed the version to '6.1'
> - patch 2 (former 4): add a DEVICE_UNPLUG_ERROR event in the device
>   unplug error path of CPUs and DIMMs
> - v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04682.html
> 
> 
> Daniel Henrique Barboza (7):
>   hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is
>     NULL
>   spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL
>   spapr_drc.c: do not error_report() when drc->dev->id == NULL
>   qapi/qdev.json: fix DEVICE_DELETED parameters doc
>   qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event
>   spapr: use DEVICE_UNPLUG_ERROR to report unplug errors
>   memory_hotplug.c: send DEVICE_UNPLUG_ERROR in
>     acpi_memory_hotplug_write()
> 
>  docs/about/deprecated.rst | 10 ++++++++++
>  hw/acpi/memory_hotplug.c  | 19 +++++++++++++++++--
>  hw/ppc/spapr.c            | 17 +++++++++++++----
>  hw/ppc/spapr_drc.c        | 21 +++++++++++++++------
>  qapi/machine.json         |  6 +++++-
>  qapi/qdev.json            | 34 +++++++++++++++++++++++++++++++---
>  stubs/qdev.c              |  7 +++++++
>  7 files changed, 98 insertions(+), 16 deletions(-)
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.