target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()

[PATCH 0/2] target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()

Greg Kurz posted 2 patches 2 years, 10 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210622140926.677618-1-groug@kaod.org

Maintainers: David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>

target/ppc/cpu-qom.h     |  1 -
target/ppc/cpu.h         | 15 +++++++++++++++
target/ppc/arch_dump.c   |  8 +++-----
target/ppc/cpu_init.c    | 17 -----------------
target/ppc/excp_helper.c |  3 +--
5 files changed, 19 insertions(+), 25 deletions(-)

Expand all Fold all

[PATCH 0/2] target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()

Posted by Greg Kurz 2 years, 10 months ago

Class method is overkill and cause code duplication in CPU setup functions.
Switch to a more lightweight solution with a unique inline helper.

Greg Kurz (2):
  target/ppc: Introduce ppc_interrupts_little_endian()
  target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()

 target/ppc/cpu-qom.h     |  1 -
 target/ppc/cpu.h         | 15 +++++++++++++++
 target/ppc/arch_dump.c   |  8 +++-----
 target/ppc/cpu_init.c    | 17 -----------------
 target/ppc/excp_helper.c |  3 +--
 5 files changed, 19 insertions(+), 25 deletions(-)

-- 
2.31.1

Re: [PATCH 0/2] target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()

Posted by David Gibson 2 years, 10 months ago

On Tue, Jun 22, 2021 at 04:09:24PM +0200, Greg Kurz wrote:
> Class method is overkill and cause code duplication in CPU setup functions.
> Switch to a more lightweight solution with a unique inline helper.

LGTM, applied to ppc-for-6.1, thanks.

> 
> Greg Kurz (2):
>   target/ppc: Introduce ppc_interrupts_little_endian()
>   target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()
> 
>  target/ppc/cpu-qom.h     |  1 -
>  target/ppc/cpu.h         | 15 +++++++++++++++
>  target/ppc/arch_dump.c   |  8 +++-----
>  target/ppc/cpu_init.c    | 17 -----------------
>  target/ppc/excp_helper.c |  3 +--
>  5 files changed, 19 insertions(+), 25 deletions(-)
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson