[PATCH v2 0/2] DEVICE_UNPLUG_ERROR QAPI event

Daniel Henrique Barboza posted 2 patches 2 years, 11 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210604200353.1206897-1-danielhb413@gmail.com
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Greg Kurz <groug@kaod.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, David Gibson <david@gibson.dropbear.id.au>
There is a newer version of this series
hw/ppc/spapr.c     |  2 +-
hw/ppc/spapr_drc.c | 15 +++++++++------
qapi/machine.json  | 23 +++++++++++++++++++++++
3 files changed, 33 insertions(+), 7 deletions(-)
[PATCH v2 0/2] DEVICE_UNPLUG_ERROR QAPI event
Posted by Daniel Henrique Barboza 2 years, 11 months ago
Hi,

This is the v2 of a series that started with 2 events,
DEVICE_UNPLUG_ERROR and DEVICE_NOT_DELETED [1]. After discussions in v1
we reached the conclussion that the DEVICE_NOT_DELETED wasn't doing much
of anything. It was an event that was trying to say 'I think something
happen, but I'm not sure', forcing the QAPI listener to inspect the
guest itself to see what went wrong, or just wait for some sort of
internal timeout (as Libvirt will do) and fail the operation regardless.

During this period between v1 and this v2 the PowerPC kernel was changed
to add a reliable error report mechanism in the device_removal path of
CPUs, which in turn gave QEMU the opportunity to do the same. This made
the DEVICE_UNPLUG_ERROR more relevant because now we can report CPU and
DIMM hotunplug errors.


changes from v1:
- former patches 1 and 2: dropped
- patch 1 (former 3): changed the version to '6.1'
- patch 2 (former 4): add a DEVICE_UNPLUG_ERROR event in the device
  unplug error path of CPUs and DIMMs

[1] v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04682.html



Daniel Henrique Barboza (2):
  qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event
  spapr: use DEVICE_UNPLUG_ERROR to report unplug errors

 hw/ppc/spapr.c     |  2 +-
 hw/ppc/spapr_drc.c | 15 +++++++++------
 qapi/machine.json  | 23 +++++++++++++++++++++++
 3 files changed, 33 insertions(+), 7 deletions(-)

-- 
2.31.1