[v3] qcow2 check: check some reserved bits and subcluster bitmaps

[PATCH v3 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

Posted by Vladimir Sementsov-Ogievskiy 2 years, 11 months ago

Hi all!

Here are some good refactorings and new (qemu-img check) checks for
qcow2.

v3: add r-b mark by Alberto and t-b marks by Kirill
 07, 09: add missed "\n"

Vladimir Sementsov-Ogievskiy (10):
  qcow2-refcount: improve style of check_refcounts_l2()
  qcow2: compressed read: simplify cluster descriptor passing
  qcow2: introduce qcow2_parse_compressed_l2_entry() helper
  qcow2-refcount: introduce fix_l2_entry_by_zero()
  qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap
  qcow2-refcount: check_refcounts_l2(): check l2_bitmap
  qcow2-refcount: check_refcounts_l2(): check reserved bits
  qcow2-refcount: improve style of check_refcounts_l1()
  qcow2-refcount: check_refcounts_l1(): check reserved bits
  qcow2-refcount: check_refblocks(): add separate message for reserved

 block/qcow2.h          |   7 +-
 block/qcow2-cluster.c  |  20 ++-
 block/qcow2-refcount.c | 328 ++++++++++++++++++++++++++---------------
 block/qcow2.c          |  13 +-
 4 files changed, 240 insertions(+), 128 deletions(-)

-- 
2.29.2

Re: [PATCH v3 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

Posted by Vladimir Sementsov-Ogievskiy 2 years, 10 months ago

Ping :)

This still applies to master with no conflicts. All patches reviewed except for 08.


24.05.2021 17:20, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> Here are some good refactorings and new (qemu-img check) checks for
> qcow2.
> 
> v3: add r-b mark by Alberto and t-b marks by Kirill
>   07, 09: add missed "\n"
> 
> Vladimir Sementsov-Ogievskiy (10):
>    qcow2-refcount: improve style of check_refcounts_l2()
>    qcow2: compressed read: simplify cluster descriptor passing
>    qcow2: introduce qcow2_parse_compressed_l2_entry() helper
>    qcow2-refcount: introduce fix_l2_entry_by_zero()
>    qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap
>    qcow2-refcount: check_refcounts_l2(): check l2_bitmap
>    qcow2-refcount: check_refcounts_l2(): check reserved bits
>    qcow2-refcount: improve style of check_refcounts_l1()
>    qcow2-refcount: check_refcounts_l1(): check reserved bits
>    qcow2-refcount: check_refblocks(): add separate message for reserved
> 
>   block/qcow2.h          |   7 +-
>   block/qcow2-cluster.c  |  20 ++-
>   block/qcow2-refcount.c | 328 ++++++++++++++++++++++++++---------------
>   block/qcow2.c          |  13 +-
>   4 files changed, 240 insertions(+), 128 deletions(-)
> 


-- 
Best regards,
Vladimir

Re: [PATCH v3 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

Posted by Vladimir Sementsov-Ogievskiy 2 years, 8 months ago

Ping again:)

Nothing changed: patches applies to master, 08 doesn't have r-b.

03.07.2021 14:17, Vladimir Sementsov-Ogievskiy wrote:
> Ping :)
> 
> This still applies to master with no conflicts. All patches reviewed except for 08.
> 
> 
> 24.05.2021 17:20, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here are some good refactorings and new (qemu-img check) checks for
>> qcow2.
>>
>> v3: add r-b mark by Alberto and t-b marks by Kirill
>>   07, 09: add missed "\n"
>>
>> Vladimir Sementsov-Ogievskiy (10):
>>    qcow2-refcount: improve style of check_refcounts_l2()
>>    qcow2: compressed read: simplify cluster descriptor passing
>>    qcow2: introduce qcow2_parse_compressed_l2_entry() helper
>>    qcow2-refcount: introduce fix_l2_entry_by_zero()
>>    qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap
>>    qcow2-refcount: check_refcounts_l2(): check l2_bitmap
>>    qcow2-refcount: check_refcounts_l2(): check reserved bits
>>    qcow2-refcount: improve style of check_refcounts_l1()
>>    qcow2-refcount: check_refcounts_l1(): check reserved bits
>>    qcow2-refcount: check_refblocks(): add separate message for reserved
>>
>>   block/qcow2.h          |   7 +-
>>   block/qcow2-cluster.c  |  20 ++-
>>   block/qcow2-refcount.c | 328 ++++++++++++++++++++++++++---------------
>>   block/qcow2.c          |  13 +-
>>   4 files changed, 240 insertions(+), 128 deletions(-)
>>
> 
> 


-- 
Best regards,
Vladimir