[v4] qcow2 check: check some reserved bits and subcluster bitmaps

[PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

Vladimir Sementsov-Ogievskiy posted 10 patches 2 years, 7 months ago

Diff against v1 v2 v3
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210914122454.141075-1-vsementsov@virtuozzo.com

Maintainers: Hanna Reitz <hreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block/qcow2.h          |   7 +-
block/qcow2-cluster.c  |  20 ++-
block/qcow2-refcount.c | 324 ++++++++++++++++++++++++++---------------
block/qcow2.c          |  13 +-
4 files changed, 236 insertions(+), 128 deletions(-)

Expand all Fold all

[PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

Posted by Vladimir Sementsov-Ogievskiy 2 years, 7 months ago

Hi all!

Here are some good refactorings and new (qemu-img check) checks for
qcow2.

06  qcow2-refcount: check_refcounts_l2(): check l2_bitmap
      don't fix unallocated cluster with allocated subclusters (no strong opinion how to do it correctly)
      drop Eric's r-b
      keep Kirill's t-b (I believe it still applies, my original task didn't include error fixing)
      define l2_bitmap near l2_entry
      add separate assertion and "break;" for QCOW2_CLUSTER_ZERO_PLAIN
others: add r-b: Hanna


Vladimir Sementsov-Ogievskiy (10):
  qcow2-refcount: improve style of check_refcounts_l2()
  qcow2: compressed read: simplify cluster descriptor passing
  qcow2: introduce qcow2_parse_compressed_l2_entry() helper
  qcow2-refcount: introduce fix_l2_entry_by_zero()
  qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap
  qcow2-refcount: check_refcounts_l2(): check l2_bitmap
  qcow2-refcount: check_refcounts_l2(): check reserved bits
  qcow2-refcount: improve style of check_refcounts_l1()
  qcow2-refcount: check_refcounts_l1(): check reserved bits
  qcow2-refcount: check_refblocks(): add separate message for reserved

 block/qcow2.h          |   7 +-
 block/qcow2-cluster.c  |  20 ++-
 block/qcow2-refcount.c | 324 ++++++++++++++++++++++++++---------------
 block/qcow2.c          |  13 +-
 4 files changed, 236 insertions(+), 128 deletions(-)

-- 
2.29.2

Re: [PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

Posted by Hanna Reitz 2 years, 7 months ago

On 14.09.21 14:24, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Here are some good refactorings and new (qemu-img check) checks for
> qcow2.

Thanks, applied to my block branch:

https://gitlab.com/hreitz/qemu/-/commits/block/

(Patch 6 is here: 
https://gitlab.com/hreitz/qemu/-/commit/93c40e7dab205047245028e97f7470d89c3a7ef3 
– just to confirm the resolution fits what you had in mind)

Hanna

Re: [PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

Posted by Vladimir Sementsov-Ogievskiy 2 years, 7 months ago

15.09.2021 13:26, Hanna Reitz wrote:
> On 14.09.21 14:24, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here are some good refactorings and new (qemu-img check) checks for
>> qcow2.
> 
> Thanks, applied to my block branch:
> 
> https://gitlab.com/hreitz/qemu/-/commits/block/
> 
> (Patch 6 is here: https://gitlab.com/hreitz/qemu/-/commit/93c40e7dab205047245028e97f7470d89c3a7ef3 – just to confirm the resolution fits what you had in mind)
> 

It's OK, thanks!


-- 
Best regards,
Vladimir