[PATCH v2 00/12] hw: Various Kconfig fixes

Philippe Mathieu-Daudé posted 12 patches 2 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210515173716.358295-1-philmd@redhat.com
Test checkpatch passed
default-configs/devices/ppc-softmmu.mak   | 1 -
default-configs/devices/ppc64-softmmu.mak | 1 -
hw/arm/Kconfig                            | 4 +++-
hw/char/Kconfig                           | 1 +
hw/i386/Kconfig                           | 1 +
hw/ide/Kconfig                            | 2 +-
hw/isa/Kconfig                            | 4 ++++
hw/mem/Kconfig                            | 2 --
hw/pci-host/Kconfig                       | 1 +
hw/ppc/Kconfig                            | 3 +++
hw/riscv/Kconfig                          | 5 +++++
hw/riscv/meson.build                      | 2 +-
12 files changed, 20 insertions(+), 7 deletions(-)
[PATCH v2 00/12] hw: Various Kconfig fixes
Posted by Philippe Mathieu-Daudé 2 years, 11 months ago
Various Kconfig fixes when building stand-alone machine binaries.

Since v1:
- Fixed Pegasos2 machine
- Removed SEMIHOSTING related patches (will repost them later)

Philippe Mathieu-Daudé (12):
  hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
  hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV
  hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS
  hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board
  hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25
  hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL
  hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines
  hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC
  hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259
  hw/isa/vt82c686: Add missing Kconfig dependencies (build error)
  hw/isa/vt82c686: Add missing Kconfig dependency (runtime error)
  hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA

 default-configs/devices/ppc-softmmu.mak   | 1 -
 default-configs/devices/ppc64-softmmu.mak | 1 -
 hw/arm/Kconfig                            | 4 +++-
 hw/char/Kconfig                           | 1 +
 hw/i386/Kconfig                           | 1 +
 hw/ide/Kconfig                            | 2 +-
 hw/isa/Kconfig                            | 4 ++++
 hw/mem/Kconfig                            | 2 --
 hw/pci-host/Kconfig                       | 1 +
 hw/ppc/Kconfig                            | 3 +++
 hw/riscv/Kconfig                          | 5 +++++
 hw/riscv/meson.build                      | 2 +-
 12 files changed, 20 insertions(+), 7 deletions(-)

-- 
2.26.3


Re: [PATCH v2 00/12] hw: Various Kconfig fixes
Posted by Eduardo Habkost 2 years, 11 months ago
CCing Build system architecture maintainer (Daniel).

On Sat, May 15, 2021 at 07:37:04PM +0200, Philippe Mathieu-Daudé wrote:
> Various Kconfig fixes when building stand-alone machine binaries.

Who should merge this once it's ready?

> 
> Since v1:
> - Fixed Pegasos2 machine
> - Removed SEMIHOSTING related patches (will repost them later)
> 
> Philippe Mathieu-Daudé (12):
>   hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
>   hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV
>   hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS
>   hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board
>   hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25
>   hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL
>   hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines
>   hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC
>   hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259
>   hw/isa/vt82c686: Add missing Kconfig dependencies (build error)
>   hw/isa/vt82c686: Add missing Kconfig dependency (runtime error)
>   hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA
> 
>  default-configs/devices/ppc-softmmu.mak   | 1 -
>  default-configs/devices/ppc64-softmmu.mak | 1 -
>  hw/arm/Kconfig                            | 4 +++-
>  hw/char/Kconfig                           | 1 +
>  hw/i386/Kconfig                           | 1 +
>  hw/ide/Kconfig                            | 2 +-
>  hw/isa/Kconfig                            | 4 ++++
>  hw/mem/Kconfig                            | 2 --
>  hw/pci-host/Kconfig                       | 1 +
>  hw/ppc/Kconfig                            | 3 +++
>  hw/riscv/Kconfig                          | 5 +++++
>  hw/riscv/meson.build                      | 2 +-
>  12 files changed, 20 insertions(+), 7 deletions(-)
> 
> -- 
> 2.26.3
> 
> 
> 

-- 
Eduardo


Re: [PATCH v2 00/12] hw: Various Kconfig fixes
Posted by Eduardo Habkost 2 years, 11 months ago
On Mon, May 17, 2021 at 03:18:56PM -0400, Eduardo Habkost wrote:
> CCing Build system architecture maintainer (Daniel).

Oops, I was misled by the subsection title.  Daniel is
responsible only for the build system documentation.

Do we have any volunteers willing to be listed as reviewers for
build system changes in MAINTAINERS?  meson.build has a
non-trivial amount of code and no maintainers or reviewers at
all.

> 
> On Sat, May 15, 2021 at 07:37:04PM +0200, Philippe Mathieu-Daudé wrote:
> > Various Kconfig fixes when building stand-alone machine binaries.
> 
> Who should merge this once it's ready?
> 
> > 
> > Since v1:
> > - Fixed Pegasos2 machine
> > - Removed SEMIHOSTING related patches (will repost them later)
> > 
> > Philippe Mathieu-Daudé (12):
> >   hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
> >   hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV
> >   hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS
> >   hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board
> >   hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25
> >   hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL
> >   hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines
> >   hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC
> >   hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259
> >   hw/isa/vt82c686: Add missing Kconfig dependencies (build error)
> >   hw/isa/vt82c686: Add missing Kconfig dependency (runtime error)
> >   hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA
> > 
> >  default-configs/devices/ppc-softmmu.mak   | 1 -
> >  default-configs/devices/ppc64-softmmu.mak | 1 -
> >  hw/arm/Kconfig                            | 4 +++-
> >  hw/char/Kconfig                           | 1 +
> >  hw/i386/Kconfig                           | 1 +
> >  hw/ide/Kconfig                            | 2 +-
> >  hw/isa/Kconfig                            | 4 ++++
> >  hw/mem/Kconfig                            | 2 --
> >  hw/pci-host/Kconfig                       | 1 +
> >  hw/ppc/Kconfig                            | 3 +++
> >  hw/riscv/Kconfig                          | 5 +++++
> >  hw/riscv/meson.build                      | 2 +-
> >  12 files changed, 20 insertions(+), 7 deletions(-)
> > 
> > -- 
> > 2.26.3
> > 
> > 
> > 
> 
> -- 
> Eduardo
> 
> 

-- 
Eduardo


Re: [PATCH v2 00/12] hw: Various Kconfig fixes
Posted by Philippe Mathieu-Daudé 2 years, 11 months ago
On 5/17/21 10:04 PM, Eduardo Habkost wrote:
> On Mon, May 17, 2021 at 03:18:56PM -0400, Eduardo Habkost wrote:
>> CCing Build system architecture maintainer (Daniel).
> 
> Oops, I was misled by the subsection title.  Daniel is
> responsible only for the build system documentation.
> 
> Do we have any volunteers willing to be listed as reviewers for
> build system changes in MAINTAINERS?  meson.build has a
> non-trivial amount of code and no maintainers or reviewers at
> all.

Hmmm OK I can add an entry. Ideally with Paolo/Thomas but I don't
think they want to be listed in any new section ;)

>> On Sat, May 15, 2021 at 07:37:04PM +0200, Philippe Mathieu-Daudé wrote:
>>> Various Kconfig fixes when building stand-alone machine binaries.
>>
>> Who should merge this once it's ready?

Paolo said in v1 that I can send the pull request myself :))

I will do it in the next 48h~.

Thanks,

Phil.


Re: [PATCH v2 00/12] hw: Various Kconfig fixes
Posted by Alex Bennée 2 years, 10 months ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 5/17/21 10:04 PM, Eduardo Habkost wrote:
>> On Mon, May 17, 2021 at 03:18:56PM -0400, Eduardo Habkost wrote:
>>> CCing Build system architecture maintainer (Daniel).
>> 
>> Oops, I was misled by the subsection title.  Daniel is
>> responsible only for the build system documentation.
>> 
>> Do we have any volunteers willing to be listed as reviewers for
>> build system changes in MAINTAINERS?  meson.build has a
>> non-trivial amount of code and no maintainers or reviewers at
>> all.
>
> Hmmm OK I can add an entry. Ideally with Paolo/Thomas but I don't
> think they want to be listed in any new section ;)
>
>>> On Sat, May 15, 2021 at 07:37:04PM +0200, Philippe Mathieu-Daudé wrote:
>>>> Various Kconfig fixes when building stand-alone machine binaries.
>>>
>>> Who should merge this once it's ready?
>
> Paolo said in v1 that I can send the pull request myself :))
>
> I will do it in the next 48h~.

Did this happen? I tried to apply the series but it conflicted straight
away. 

-- 
Alex Bennée