From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100247; cv=none; d=zohomail.com; s=zohoarc; b=Lbz8tNaNV7fbANKBqmO9cIp+yRnPs9TIV3grzfKhkh7vetSmoRh2m0+CX4wyVhOZYnx/t/6nq4HM/1tJxPAh6OV8/lTu88FdXbUbXnFnNsOhaDKcvjOYZKgv9ecEtMRfl6EVp1mJAqz5JpeG+zbN6U6c2ZUK2d3MO0McFXO6yDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100247; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wRNuc1gJMH1hkdyUyCI+kE/vTfEuz1keBAJWrXytcEA=; b=aQ323HfBB4DYnsKHFN2ZLQSPQn0o+9ZtSgrR4nuE7kpbzhZIZQrsDAzkIarEWTyY3PwF5CatM4gJsnuC8Qx4jUCGYb3X8rYLywNmLXZOUWbkGPoZKqpus3qBqEKeMRfwtnK88hgJOXSyFJvS7+yBwODob3l0NogkoD6QU4l/Vn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100247745955.3449859878714; Sat, 15 May 2021 10:37:27 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-9n41hozANe-GthGn41lJ_w-1; Sat, 15 May 2021 13:37:24 -0400 Received: by mail-wm1-f69.google.com with SMTP id 12-20020a1c010c0000b0290176491efde9so100058wmb.4 for ; Sat, 15 May 2021 10:37:24 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id a17sm2052985wrt.53.2021.05.15.10.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wRNuc1gJMH1hkdyUyCI+kE/vTfEuz1keBAJWrXytcEA=; b=d6lHMr2j3oIQOsSwOy+mdnThkPLAzy02UaCx3GNgfYG4XNHWUX+G3wwme3Zt9hEucC4XkA XTpa0AtnL9olpvAhbhHbNx4jreU2lfdEpTefdhHE2TawZi7oT5HShluPnrIAv1+8XzfRV5 z/GasMvTmd17joJzMPhiu0XZd/MRzqQ= X-MC-Unique: 9n41hozANe-GthGn41lJ_w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wRNuc1gJMH1hkdyUyCI+kE/vTfEuz1keBAJWrXytcEA=; b=Nyv8fmkJeVNwHqm3l6B3/3BPbEZfPNB1QabphgvGBMPgAvGk3PcuysSZTGppf3Hcf4 khCnkT+bNqU0DamutmcW9ouRZWPoLqTr30Zs0hZuacF8utG7/5W8plcFsdSGZNVvlw5E XaGCEnKXgfEgDj8jEUtxDBIABH9ug/cVsCTgSiAc46NtQD3ZGd0mH0LQJeajNy9zE4Ze JP9Zvg13cIHBrnEgCSL0lqbz8IyTTGMStbRKbCfWeUOXwzWgUPo7ISGSXnzoqNh+7K2K G1trATpFZc1EfdSuiR9ZumlLNTzgGRn1bwxWlXBfDLCKHBUMbG+ryroMLXebUiGoxXrp yrTw== X-Gm-Message-State: AOAM5302qsyC5cWS+ii3n3mRwfIE0CzSwnEJ5w6zHZhCGg1yFelXE+kw lcFEmZNVFnHgrujisa5Fvxc0UcDgf1o1+aHC9JuAMDXMnbGn1ZvMeY8z7FqA+V8zwzCc8n49nCn 6XjJ9BZJOdogt+A== X-Received: by 2002:a05:600c:4896:: with SMTP id j22mr14966967wmp.156.1621100243854; Sat, 15 May 2021 10:37:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz2Ad0xL16eEWXWXC6gvEGKc994vEjz53rI4Fm7kubWnLVp0RG1vMfoeBQ+BzwAG7JYbnrQA== X-Received: by 2002:a05:600c:4896:: with SMTP id j22mr14966953wmp.156.1621100243687; Sat, 15 May 2021 10:37:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , Igor Mammedov , Greg Kurz Subject: [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Date: Sat, 15 May 2021 19:37:05 +0200 Message-Id: <20210515173716.358295-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may not be started without it. This is the case with the NVDIMM device (it is certainly possible to start a machine without NVDIMM) , so use the 'imply' weak reverse dependency to select the symbol. Acked-by: Paolo Bonzini Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Bin Meng --- default-configs/devices/ppc64-softmmu.mak | 1 - hw/arm/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/mem/Kconfig | 2 -- hw/ppc/Kconfig | 1 + 5 files changed, 3 insertions(+), 3 deletions(-) diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/de= vices/ppc64-softmmu.mak index ae0841fa3a1..cca52665d90 100644 --- a/default-configs/devices/ppc64-softmmu.mak +++ b/default-configs/devices/ppc64-softmmu.mak @@ -8,4 +8,3 @@ CONFIG_POWERNV=3Dy =20 # For pSeries CONFIG_PSERIES=3Dy -CONFIG_NVDIMM=3Dy diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index b887f6a5b17..67723d9ea6a 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -6,6 +6,7 @@ config ARM_VIRT imply VFIO_PLATFORM imply VFIO_XGMAC imply TPM_TIS_SYSBUS + imply NVDIMM select ARM_GIC select ACPI select ARM_SMMUV3 diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 7f91f30877f..66838fa397b 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -23,6 +23,7 @@ config PC imply TPM_TIS_ISA imply VGA_PCI imply VIRTIO_VGA + imply NVDIMM select FDC select I8259 select I8254 diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig index a0ef2cf648e..8b19fdc49f1 100644 --- a/hw/mem/Kconfig +++ b/hw/mem/Kconfig @@ -7,6 +7,4 @@ config MEM_DEVICE =20 config NVDIMM bool - default y - depends on (PC || PSERIES || ARM_VIRT) select MEM_DEVICE diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index e51e0e5e5ac..66e0b15d9ef 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -3,6 +3,7 @@ config PSERIES imply PCI_DEVICES imply TEST_DEVICES imply VIRTIO_VGA + imply NVDIMM select DIMM select PCI select SPAPR_VSCSI --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100252; cv=none; d=zohomail.com; s=zohoarc; b=hyKgYH7+nXm8scBbIuxS4ttLPAEB5cZQWPokhQHbNpQt0CxKMqxlzsDhRSRvqhR/othT13TBZ9Gowou4zDRtSbXL8jOPtUGIFEK06PhOs5hhAABWc2E7ttoJTnPP4w61G8sjw4J6rTeiicYGwpg+4QRuMZX/Rs7rcECt/O/G1Gg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100252; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=k/10dvLOYecsAQmUGPkwxrFRTrjd5+JzocYSZHgeVfk=; b=UlqGBg0kcRc1iIQTmloZ/PKe6XkbEnnlqEoQ+WQEl+8rrNfdaEq09zOukyES0YTs3VRa5VDY5ZP/sqcbzQ0ff11bDU+HUczqKH+DmnsDtuSHTiXoo6UfrvQnO0AKCjV7xqAb9jWbSsjWwigv3FYmwM+RZ9e8hfst0SXqDGvMHig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16211002527141015.7979605323914; Sat, 15 May 2021 10:37:32 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-l41qwlrGN7CjiLhM0g826g-1; Sat, 15 May 2021 13:37:29 -0400 Received: by mail-wr1-f72.google.com with SMTP id f1-20020adf9f410000b029010e8048a0e3so1410339wrg.4 for ; Sat, 15 May 2021 10:37:29 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id q3sm8260103wrr.43.2021.05.15.10.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k/10dvLOYecsAQmUGPkwxrFRTrjd5+JzocYSZHgeVfk=; b=Ez/NEZ50nSNp3weLm451lazCKzrMGqFAyL2R27w61Q7JRBpqLa8LLAqBxSrScSt9hLgmKZ u00GK6iHKkrKmyVQa5uv4lKnJZZRLhPWEGgoNiY11YlkHXuc+OL6vjoCC5g/7ccWC6Igv+ 4vpTi7JZl4JYJJNfJfyD/IfYCB/jpp0= X-MC-Unique: l41qwlrGN7CjiLhM0g826g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k/10dvLOYecsAQmUGPkwxrFRTrjd5+JzocYSZHgeVfk=; b=NEJo+whda+3da5lT85bomCKWSH8xaG2VrWV7ZL2yGNvdCFxe1i1BDv8vMJOnyVpsQd ZWE3W5OyFqmLWHC3ScMbVviEZHdgb7pHKGMJe7ryUOkukliESPpS7An6/ERQWin0nGbj y6xd2vknwjPsn02Feh5QS67p0uf0YmX0LSGNgFU97JB/EJD51pYUfxOL2vmdpMDKRs2/ U07f2MLnKnl6r9X9JMnOfih/w2QZdgxO9sitXG3a/iuDIldQ04gaRJtjZn/86iKSnao4 rj9VPD7EJTFsT3LND9t9g5gsIU+/eWBRBrKieu6wbPBJpu1PrUvgTtbBZBoB+0QJ+Jgw +brg== X-Gm-Message-State: AOAM533m//iiLTRNsQginvz4kwRsNaaNOWpGxX4Iiy+4mQBwwhp8G0xf 1P3GnwT0LOY07tl/afMrRdCv+yLAuLRbiPLW7vks0ILGSY78apL5q2Jm2IUIsXrjEvFBtS7nx/K o9Oz0QigfV1DTnA== X-Received: by 2002:a05:600c:4eca:: with SMTP id g10mr15474334wmq.180.1621100248599; Sat, 15 May 2021 10:37:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBI/OGWHQJw95jKNSYxvduONqDOFNeiW3sAzEu0dZbev1126HPcjQkDuw1xmVEaAqMlhE2ew== X-Received: by 2002:a05:600c:4eca:: with SMTP id g10mr15474322wmq.180.1621100248461; Sat, 15 May 2021 10:37:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , John Snow , qemu-block@nongnu.org (open list:IDE) Subject: [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV Date: Sat, 15 May 2021 19:37:06 +0200 Message-Id: <20210515173716.358295-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd= _table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, Drive= Info *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int= unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_d= evs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: John Snow --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV =20 config IDE_ISA bool --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100257; cv=none; d=zohomail.com; s=zohoarc; b=eB9MkkJpE/WmwcznigqDNnr++OJw4R/BgXk6EcaHKvHGoU6RcSbp9/AyRnw5sDDwHO2AYDL9g5w1i5BAO6v0dvVZMkMZ1ZG9H4MFJO9x7dbbXUosh6vVq3Ohd13ZGVAa2Oo+G+7jin8/B/dWTYlEw+v8ALlRuXG5svFMTK5nrbA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100257; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=k59OgyztQggH2BswEalrOvHA2AZsGsT7XfWLcKTsjW4=; b=CPW9sfihvAk/7QP3rgxT/RhxwA2ZPf411LvxXL6WLm69jkvfYUc6ZBrFoFHbiOtCJwBNy15FrUK2tsPPN7vk0cipxxsSWMp1vYt+LE1n8R3N3K0RpZsoMs+lLVAUrVdlR/Vld7JEJ90J/8Yw1DizGlCexMp57VNNpIlhkcQYtwo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621100257227349.6617083399252; Sat, 15 May 2021 10:37:37 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-hUElbcx6M7m1N4E4keN4xA-1; Sat, 15 May 2021 13:37:34 -0400 Received: by mail-wm1-f71.google.com with SMTP id f8-20020a1c1f080000b0290169855914dfso1660107wmf.3 for ; Sat, 15 May 2021 10:37:34 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id b68sm2216685wmb.11.2021.05.15.10.37.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k59OgyztQggH2BswEalrOvHA2AZsGsT7XfWLcKTsjW4=; b=D9NedgT3VSrkPQwTYTtIsGlErAZpthfrfifzJp3kpuJrr0ySU0PVYl8CtU7iG+e2bjRhmQ PuhRWAIlLIWwGQEVgfVHas73SrpjqLQ0vc0ky4WdLNVQcnySd7EvsfYBVZQu0yqhgnxMeU oDmGrl8XoaAMJVpR9Dgddw/RfcFK184= X-MC-Unique: hUElbcx6M7m1N4E4keN4xA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k59OgyztQggH2BswEalrOvHA2AZsGsT7XfWLcKTsjW4=; b=WNWDgUtqRI5B5yIS3beoAQUgqRjKom5kvS2F6h0WWpl020GK3Klh/EyWp3K7G0SvDR AlnGbGwnVYshmqpCoDjMHVSJqmaEW/m6Lhu6p3b0KVkZPklyLA9Dxo/vkgsdVGJAprpb TGw6RIBrkcYGW6BONffi9AHfD09tr7SSl3RRSuLYYRUdO8Wi1odrr8R9FhvnYAkUo4l8 ptgLkRu0UogCCy0mT9s+wTLoUgorgbsOBNT4L3luukHBrLps1UOu64hS8QuNd6FTPfLY n/K+4ojkrJfnxzuzo5nQheAjkhkmFOQ9ioqn7w/PdnSsaG5NUBxTe973i82Lc39L6smY qn0A== X-Gm-Message-State: AOAM531WJ9ZczxRZCDoAqsFgLL7VFq4mASeN57WhnK4CrAK0ilyu4Lvy 5mJXqkBYR8rPYzF7+1JWr2OHwByzO5L15E1zu1FCKiTB8zhx1sH8bwEdYbTMlM5qyZlEL1R4SKF 4fG2NdSqoD6negg== X-Received: by 2002:a1c:a446:: with SMTP id n67mr3743207wme.19.1621100253364; Sat, 15 May 2021 10:37:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY81/AM1k54bDXruKvRIomEErOv9vjg+vI2AQgtq4Ayz/+9KFltkQvriNz3cEMu45Ca/C/7Q== X-Received: by 2002:a1c:a446:: with SMTP id n67mr3743192wme.19.1621100253232; Sat, 15 May 2021 10:37:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hao Wu , Bin Meng , Peter Maydell Subject: [PATCH v2 03/12] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS Date: Sat, 15 May 2021 19:37:07 +0200 Message-Id: <20210515173716.358295-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but this isn't advertised with proper Kconfig symbol, leading to an early build failure when building NPCM7XX machines standalone: The following clauses were found for AT24C config AT24C depends on I2C select AT24C if NPCM7XX Fix by adding SMBUS to NPCM7XX. Fixes: 94e77879395 ("hw/i2c: Implement NPCM7XX SMBus Module Single Mode") Reviewed-by: Hao Wu Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 67723d9ea6a..85c6a1a088c 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -373,6 +373,7 @@ config NPCM7XX bool select A9MPCORE select ARM_GIC + select SMBUS select AT24C # EEPROM select PL310 # cache controller select SERIAL --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100261; cv=none; d=zohomail.com; s=zohoarc; b=YcQ2xL8qUzyV4dJBTMxrq8PzX/KXSa7Yrx/kuUY++0SdmvFQqU5VNw4eWoeXP74t8tYZU9pxt699cClfs/fTyOoxIIpgwEgYQcMetDo6tzacknFyhFPEjbQY7/zcDfLId6MazLjMtUhn0uyZPzadFsyzAmMe9QrbWBj/6OZd+sA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100261; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=lraw6SQ0lVBa6CL2zdvdg82NgOtgQKcG7wf/n9cOxMc=; b=dOZp8CbH0TU/+uH0cyqHRsxTI7a82b3o7Gho6vxWD2gQgod0HakR+++wXM715yl2zy0tBW/6loVg3FevpJBCz0Tyn38J6hMbalBfp4puk9hiw8CEQb6je6oak5QZGpPWCMi4V4u2FEVg+XMosboF/p1R395isZJOFkvuOpWelVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621100261775739.8290447704625; Sat, 15 May 2021 10:37:41 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-F9Cd82tGOLCT9O3mKtnPMQ-1; Sat, 15 May 2021 13:37:39 -0400 Received: by mail-wm1-f70.google.com with SMTP id o126-20020a1c28840000b0290149b8f27c99so183222wmo.2 for ; Sat, 15 May 2021 10:37:38 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id x11sm10019081wrl.13.2021.05.15.10.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lraw6SQ0lVBa6CL2zdvdg82NgOtgQKcG7wf/n9cOxMc=; b=YnyndHzT1F+5eL+YVZjVpRNRP/RBsz4Ad2K1OwanOX4SDX9fR5wfzqagTG/XtXr8pHEjf+ PTG1LOqfWZs/CTw3luCSjDhQGB9iDgGlZEn8bp9+LMAsihnEMLhD1DdWT1Jzjj0wy+xkwl P/huCsEFrY2vSaB/7KDTMWyU72FFjc4= X-MC-Unique: F9Cd82tGOLCT9O3mKtnPMQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lraw6SQ0lVBa6CL2zdvdg82NgOtgQKcG7wf/n9cOxMc=; b=YPdRmeY5HkVEXoKseSOE0q3siI2DBSX4w7D2MRudZFdzflVM5eN8ia/+eukmp2GPRD U4mFBmbkHxhBSFyrWyCMAFH4TSkMviUXihXTfeSRY+0lM+jcfgLijEusiK/osl4t3fmX FOpdou9Wl3nZNeG2sWnk/eJDG8RiaLd7l5a6bJ6+ONdbG8sALkS2RT94EuD4JQuftGSY /L1JtKPvxRq4kt52u0FKZb15uol1nLgDFNJPtZJy2plf2heFENd00++5rR0age82Ypzc mR6LGME6bVjLEPgTJNia9zYUnT0m9fpz0eltohxv8Teac6DJ120d6SvMRZyjlfl5lJU3 nZmg== X-Gm-Message-State: AOAM531pArQ2dR3/MvdvInSiPqPDJYAROdZ0VxoUqdn1O7hLz8iOViq6 ZFqCt7VARj24d5dcbS+2aFVz+J6QjP5/PjkeONxWECBp2bQJpPh8HySF+AgvuFJjIvMnBFu+j+G l+5coRjSIhY9erw== X-Received: by 2002:a1c:a3c3:: with SMTP id m186mr3770246wme.39.1621100258035; Sat, 15 May 2021 10:37:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyBs6Pteko4o0DW+BGZzQDrEJAvsFdZpZXCrww7Nd91irtzV2sFZ5IkQXQu4bTw46PafCWbw== X-Received: by 2002:a1c:a3c3:: with SMTP id m186mr3770224wme.39.1621100257888; Sat, 15 May 2021 10:37:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , Peter Maydell Subject: [PATCH v2 04/12] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board Date: Sat, 15 May 2021 19:37:08 +0200 Message-Id: <20210515173716.358295-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) In commit c4f00daa5b3 ("imx25-pdk: create ds1338 for qtest inside the test") we removed the DS1338 device from the i.MX25 machine but forgot to remove it in the machine Kconfig definitions, do it now. Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 85c6a1a088c..5827c092b28 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -386,7 +386,6 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 - select DS1338 =20 config FSL_IMX31 bool --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100266; cv=none; d=zohomail.com; s=zohoarc; b=RI4zOX/IGAUUNKvtT4tcJUVzqDBaRfLa3L7FekU9FNgrKsN2cGoiPHO+/iXD8rWZEqCgeSj7RluQEUEkm8mJ3JS+qBQzxXqnvBam26yOK7IFKbogc2oCkJ2JrKzfPlaFNXVHyx/Q2uD+lYXxL0bLxY8pSsljoknM/GUrlE/lqFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100266; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=S7IAZU3SpuyZA/TPUu84zMTCi1tlnlEn7V9DtnfwMAo=; b=nch6GkHwNKlT2G3ubg5L9H+L0+fVsKpU++Ekayjrbi7AAEqergxVcgcDKrhDhHHGV9iRxHBxkTluzZWPaGQdqB7ke3HtAK/oV7LJES7klOyFAGlL5pg0JAKyarSb7SUECd3zILTq12nGK/vfuqsX/i6TWsVOhF56ww27E9ssp4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100266725368.257822377289; Sat, 15 May 2021 10:37:46 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-XI7kAuiQMkSZjQpuiSEhrw-1; Sat, 15 May 2021 13:37:44 -0400 Received: by mail-wr1-f70.google.com with SMTP id d12-20020adfc3cc0000b029011166e2f1a7so474107wrg.19 for ; Sat, 15 May 2021 10:37:43 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id 61sm11021853wrm.52.2021.05.15.10.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S7IAZU3SpuyZA/TPUu84zMTCi1tlnlEn7V9DtnfwMAo=; b=Ell3OPsw7Ha4+uLsDSZ7o9ci5iFgjKzT/Ed89+WGbjSSr0ERKldxfp+264RLw83alutUPZ Tzb0h7gQ0fi1bnBf1rV/Ly+OKNp88a1WAK8ZHy5wwg1lORsc3Ss0MgUIoyyz9zFzRg9+r+ JyN06zYyiPOynlZK7T6IMZKquEWlmh8= X-MC-Unique: XI7kAuiQMkSZjQpuiSEhrw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S7IAZU3SpuyZA/TPUu84zMTCi1tlnlEn7V9DtnfwMAo=; b=VaN22F4Ng5TllKpupk/Q/uIbPyb1fredh5gSLg8zvjPW668mz2ZltoqixIRZNltp2k +yhC3tn98H37+XN7Euei+dTpRZyTnzeQP3BLby2u3d2K5g1MF/Cd0kD7wRz5eueJXwjj xOgZJTuxF+hWGnSW7eiSt0qXT97yC2ZiqoP+Ef8K9BgpK9j3JF4+Udf70xUKvqC5XOQ3 im9Hs2QEfjsCUa0DVJUViVyXr7hjUbWJuP+cXQz9Jsu1SgDMi4BmXPuk0/Wya1AQNIlH 63U0og33ehAWYJFnklL1fgUuI4nV5G2BrV7B1+fWGeFZnqn2JchazHmmkhN0KEIc+MPQ UBqw== X-Gm-Message-State: AOAM533KmoHyacLUkm1ZCH/arKYoivZULdtcViUdkfR1kR2zEcKCXM3L EpVOcEvgwqUgeoslye9YvpTYmYejjvZZfPZDwxD2OLAjhoa4jdPS3aafnUM/z6aUDLbBdmZqfiY QComdX7t3Lb5d3w== X-Received: by 2002:a7b:ce87:: with SMTP id q7mr17484728wmj.77.1621100262898; Sat, 15 May 2021 10:37:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGVOh7pkMkDvwyl4op4hAAMWNNYbI6Usln0UJOegBSdd5y4Gs1f92XifVNt+WjkNOmwRwmog== X-Received: by 2002:a7b:ce87:: with SMTP id q7mr17484711wmj.77.1621100262785; Sat, 15 May 2021 10:37:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , Guenter Roeck , Peter Maydell Subject: [PATCH v2 05/12] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25 Date: Sat, 15 May 2021 19:37:09 +0200 Message-Id: <20210515173716.358295-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Commit bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") added a dependency on the TYPE_IMX_USDHC model, but forgot to add the Kconfig selector. Fix that to solve when built stand-alone: $ qemu-system-arm -M imx25-pdk qemu-system-arm: missing object type 'imx-usdhc' Aborted (core dumped) Fixes: bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Guenter Roeck --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 5827c092b28..6bb34926bb5 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -386,6 +386,7 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 + select SDHCI =20 config FSL_IMX31 bool --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100273; cv=none; d=zohomail.com; s=zohoarc; b=BnBaG62yfMMcwgUpcZlAwRyvhOYJYDbua/dFbjdUrq+aoSpkGW+g4UvgggEHb3m3AugkKfCq2NFmHiiksV1eLLkZW2yn2dTkwTPXb1rBhT6cSruk4ndCpGpcS6P7YaPW0tpRi+ZW0Z9SHSkZ6CwlBQ/yPnFsHuRTYdfr0ylRrUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100273; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=oapXbLTqf6jmlB2c8yI8R/Rxrd0PQpmzXNP57+j3KT8=; b=IR4LnaOa3MtDv7ZFhkg+4Rd62kimX12dIszzpJmw+hKnEz6NFABHp5eAqOOCNB8IZBzcfOlhKOsAhZ7GYreilodpckvkmTO6O5BGehKW2HUX80krsOD1edY53p9bvKNwZ7lUHZsNpJUbkk1o9wOI1OdvC9zt1J16VffRGZB0ex4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621100273644526.0041128173566; Sat, 15 May 2021 10:37:53 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-6-x3d090Ogya7VMsZx6-Eg-1; Sat, 15 May 2021 13:37:48 -0400 Received: by mail-wm1-f69.google.com with SMTP id j128-20020a1c55860000b02901384b712094so1666414wmb.2 for ; Sat, 15 May 2021 10:37:48 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id d9sm10234096wrp.47.2021.05.15.10.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oapXbLTqf6jmlB2c8yI8R/Rxrd0PQpmzXNP57+j3KT8=; b=Y8qSBUf2v2eH0ubsYFqBX6VDUZd8CjzGKPxcKhIeddGU7XJyjS//22N/1lFzjBqmOaeVXh hjxwsx3/ojXRmOWCkl18OAhyt5bVTMFcbve0/IbDgbx7wQPNUzbNUu3LPk+GIZFlOqts0o H/r8ezvxuPucKId1G5p+0/nZwGZO5aY= X-MC-Unique: 6-x3d090Ogya7VMsZx6-Eg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oapXbLTqf6jmlB2c8yI8R/Rxrd0PQpmzXNP57+j3KT8=; b=V5bfi6pwOwN4iuQB7w/G/rVwo52Ncoy4xqDQj9miRzqYzSliSXFwVKvqPfgNs5yKKH zzVyQX9FjAMBwE6/RhtzYvh1XWeMtxbo+y9rvOPAL42k3CuoZU6yVKZgo/ATvcqv10VU XXWnpZ4T7oIvTA/36xMmu6Icn3iM4EoLqZucJKjK6xHMBcMI7Mqa/0CqVumTflGtCoQJ LJp3eX/k+RrY5fp0hIYsxxSYfNFqVv6X+TpL2LUEPhM7EMkHJvyWxf2bSZffildC9M9x PrmGapIqxRSc4C2igXprylBRB/xyH8KbDC12gihf/E+otHOIQ8E4lMDZNkRYHSzaytVF d3TQ== X-Gm-Message-State: AOAM532Oj9Yi5DanyNDhJFXSWHVoZJ5aEttLwwq79tNa8uLXHhAc1MMw 4dCHAVONTEkeuR0iSwAWc0ba7bNLRNK1zejKhCYNa2fld1FDkGSnr/r/BURbXdBJIWGv8Yw7GFV HZHUjTuWLPSSbXA== X-Received: by 2002:a5d:6d88:: with SMTP id l8mr23733770wrs.185.1621100267676; Sat, 15 May 2021 10:37:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzF4bawh4kel9iuIamVbm1PNlABSKwFlGKejs+jqDOchip+fxGFi0iYCbS25sCIV5UINTj1Hg== X-Received: by 2002:a5d:6d88:: with SMTP id l8mr23733747wrs.185.1621100267514; Sat, 15 May 2021 10:37:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v2 06/12] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL Date: Sat, 15 May 2021 19:37:10 +0200 Message-Id: <20210515173716.358295-7-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") added a dependency on the SERIAL model, but forgot to add the Kconfig selector. Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when building the MICROCHIP_PFSOC machine stand-alone: /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `m= chp_pfsoc_mmuart_create': hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init' Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") Acked-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Bin Meng --- Cc: Bin Meng Cc: Alistair Francis --- hw/char/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/Kconfig b/hw/char/Kconfig index 4cf36ac637b..2e4f620b13e 100644 --- a/hw/char/Kconfig +++ b/hw/char/Kconfig @@ -61,6 +61,7 @@ config AVR_USART =20 config MCHP_PFSOC_MMUART bool + select SERIAL =20 config SIFIVE_UART bool --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100277; cv=none; d=zohomail.com; s=zohoarc; b=QU6fbRn3FOQWnx1SCkcQb3fjXsxFhPBvbk+4rV4AyMo2KFhk6IaJUiyqF1JpgV+Xkl0UZB05Z5NB8u7xfn6x4hjlJB4HREFsJtFtWX7nnd1F0bseKnRut/lmz5KGLwOdilbnHWvrmtYgsXE4VXeChgDLSLgF5DcVLDGurjK4l7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100277; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=j4+TVOwKdNAqEwx0iSQEx6F6DQNpYYiD4MSDoIPJ8ns=; b=gCwF1HyQuY1iKLWJn1BQHTibFZe+UhhTB3Uf50s5Yrv4t5in0z/oHwctF2sgbfdKy1VBaU1xmaNUkXcR97iANdIH7z5ykx1fMzUwmsAgOtPecT9VSh8q7au+5MwMZi744BYVqfeQMXhsyDc8KbwAYcZFl/LXDo7JgC6sXrLKe4c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100277312947.3910449610363; Sat, 15 May 2021 10:37:57 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-I4KKNc46PzaqRpdEYGTXBQ-1; Sat, 15 May 2021 13:37:54 -0400 Received: by mail-wm1-f72.google.com with SMTP id j128-20020a1c55860000b02901384b712094so1666491wmb.2 for ; Sat, 15 May 2021 10:37:54 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id x16sm10269543wrp.6.2021.05.15.10.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j4+TVOwKdNAqEwx0iSQEx6F6DQNpYYiD4MSDoIPJ8ns=; b=C1y5DnAt2Jit4pcFE1rQFAK+D5SmsB7CrEXGZZKR3Nta2vx0NBsM1G75YArD+G/FOk4d1u Jqyh7LmZ9E3r66s+OqL4ERQiIKAmxusqEpAXt95tj4CbV+83WLdHu9BJDCEcm313D5v1l2 ngX/jHGdXiPk5eN3QhhsbDzr0IbQBM0= X-MC-Unique: I4KKNc46PzaqRpdEYGTXBQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j4+TVOwKdNAqEwx0iSQEx6F6DQNpYYiD4MSDoIPJ8ns=; b=sPlJsYNre18z1JLnfMos2HTrWnRMeoJwLChkAa9LDWg7/1w3OpEvbnUkNjjDYoGoSs E0DSqpnc2bKVzTKPazC1MKBkvKbG5RfQLN/jA04L5r4e00h0EeADmH+tXfB+4cQr0xJP Z3uZROLyWmDkFi4AuTXMC1EbPxHjSX+2FupPHoM0KATi9CMKjN9sa6fGvwHjlBVhP8fu nZgt+lyeSzfHA2lZ/+tqCDmslWZefelSv1c/fvVTo5Db4qbyJDwI8MmG2AfCaC53VkUU r4ZxVoHeJgsniQJikbUfSL8vPiEG10sJoXoc4VP5bzkHJ/5CCMJuzVPuRrQM3g3aScpD c7KQ== X-Gm-Message-State: AOAM532T3YIgeHUtpHxBv2ukVfLo65COeOzNaSYOnzB5M74Ap24nLWq+ XzzHI/AilfjaB1zUjmqljdn0OkjzdH0LqXSj8JVrZw4MRDiZxc0iywDQDACORIlokizTMyphNRS vajJhTu+Aqf7q/Q== X-Received: by 2002:a05:6000:508:: with SMTP id a8mr65107215wrf.315.1621100272297; Sat, 15 May 2021 10:37:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoFnLeRbk63Gsa5dVBOmEyZbu2HTopi5mLBkLvvTphYvDhVQD1hqnm/7wQOXQ6OyOFZn0rTw== X-Received: by 2002:a05:6000:508:: with SMTP id a8mr65107196wrf.315.1621100272196; Sat, 15 May 2021 10:37:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , Palmer Dabbelt Subject: [PATCH v2 07/12] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines Date: Sat, 15 May 2021 19:37:11 +0200 Message-Id: <20210515173716.358295-8-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Only the Virt and Spike machines use NUMA. Add a RISCV_NUMA Kconfig symbol and only have these machines select it. Adapt the Meson file to only built it if required. Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/riscv/Kconfig | 5 +++++ hw/riscv/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index 86957ec7b06..0590f443fdf 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -1,3 +1,6 @@ +config RISCV_NUMA + bool + config IBEX bool =20 @@ -34,6 +37,7 @@ config RISCV_VIRT imply PCI_DEVICES imply VIRTIO_VGA imply TEST_DEVICES + select RISCV_NUMA select GOLDFISH_RTC select MSI_NONBROKEN select PCI @@ -74,6 +78,7 @@ config SIFIVE_U =20 config SPIKE bool + select RISCV_NUMA select HTIF select MSI_NONBROKEN select SIFIVE_CLINT diff --git a/hw/riscv/meson.build b/hw/riscv/meson.build index a97454661c0..ab6cae57eae 100644 --- a/hw/riscv/meson.build +++ b/hw/riscv/meson.build @@ -1,6 +1,6 @@ riscv_ss =3D ss.source_set() riscv_ss.add(files('boot.c'), fdt) -riscv_ss.add(files('numa.c')) +riscv_ss.add(when: 'CONFIG_RISCV_NUMA', if_true: files('numa.c')) riscv_ss.add(files('riscv_hart.c')) riscv_ss.add(when: 'CONFIG_OPENTITAN', if_true: files('opentitan.c')) riscv_ss.add(when: 'CONFIG_RISCV_VIRT', if_true: files('virt.c')) --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100280; cv=none; d=zohomail.com; s=zohoarc; b=DuVNzIS0bj3kLRe4EK+MrCDBoPEophD6J1//YcILdUvhXp4+bW8HUYlkDLOznOEI8f2CufFQ7Ptvxt01W+7Z9+4190CPoqXQ6LGfdy0C4n+e/09p9jCHGMUiTWRSfGgSJx1frx2TI5V4VZthS7fhYGx72B4r10yrDw+iRaN5GI0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100280; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=RV1lQVu+Z0RzwUnAORV2pR221f9eeMJn1YWrVW88UbY=; b=l1+n8XDviyOodWhD2E+0JqP1HDUvSu0yUlxDtASboStF9XdwLt/K0ejzRgtcLxZ6Qwtmxq3/iVVMbvmmNtWrci5WnXP13h4Jm9AGZYDzTcgfca041pCusawsevD0V2Hyp6zBmABEwwkyLSNwKf9qJ55fLwY6vq7FCHyCOaPgcNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 162110028095999.56894523575829; Sat, 15 May 2021 10:38:00 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-Wwn8HVMFOfew0gTvVfnBrQ-1; Sat, 15 May 2021 13:37:58 -0400 Received: by mail-wm1-f69.google.com with SMTP id o18-20020a1ca5120000b02901333a56d46eso1652650wme.8 for ; Sat, 15 May 2021 10:37:58 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id c206sm3495060wmf.12.2021.05.15.10.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RV1lQVu+Z0RzwUnAORV2pR221f9eeMJn1YWrVW88UbY=; b=BoOXzhht5sk/LyL60CmbHxij6vC5wMIBR4TfUw0ygEZq8MdRCAkdbBAjwZ+vGDy1+967XU wYX+koUZGp1qBUsbPGOWX6dKFzO4pfUYTAPGXnU/DHGgGZSwrHTxdZl+K+UasLcPgUEzsm D5OQK+IqsKP2rwAWwjkyeJxGRZO8ANM= X-MC-Unique: Wwn8HVMFOfew0gTvVfnBrQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RV1lQVu+Z0RzwUnAORV2pR221f9eeMJn1YWrVW88UbY=; b=UWkSYRdiMFr4U4ifPsz0Vh+3A11GuxH/MWRf+/OW5DNJkf5IQh584ixw+sLseb+KwM yREswOzeprYvR3fg0hCkcJ8EFH6SkRU2niPcr1/hj5SAmnCLhRsvx3gUKp7f6MI8OZSE fdDBkQoJ9L1of9gA61VuWUI5MRxrzzfE2wSkgEFDX71hIw51u/AGp8n1wVdjt1bumJ9n t+/K8e/sZoP0nfbkJOm12U9Tqh/BCKKmezMACNl454wzrxUuAeX4gAzIaceOz/2Nr/l2 iSjFYBQTqwqJi2maAjR0RlkTH8cfa8ajo8KUlAQOwmaGq8KYDRLl+v2627Dy4LjP1igU 8qxw== X-Gm-Message-State: AOAM531twi6pfgL1jDEHn6v/Ru2qq2H1Kvm9CjbfsvtaAIbmjFsTLQLl LMU7HXT/3yg4ErEft1tisFHwyHsCHBNlG2X68YmAoBj7AEICdgsjpx5o5h1RzGsq2XITz12A65T 50rR1LHE1cVV8XQ== X-Received: by 2002:a5d:4cce:: with SMTP id c14mr67329376wrt.29.1621100277258; Sat, 15 May 2021 10:37:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZ5d81gqNTqrDXPeRo6Xnm+gpF+7UbrE+plkceXU1QyAbiT09oDT/OoiwpyrXTKJOCVC29lg== X-Received: by 2002:a5d:4cce:: with SMTP id c14mr67329371wrt.29.1621100277148; Sat, 15 May 2021 10:37:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , Greg Kurz Subject: [PATCH v2 08/12] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC Date: Sat, 15 May 2021 19:37:12 +0200 Message-Id: <20210515173716.358295-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338 CONFIG_DS1338=3Dy config DS1338 depends on I2C Fix by selecting the DS1338 symbol in the single machine requiring it, the E500. Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC wi= th it") Acked-by: Paolo Bonzini Acked-by: David Gibson Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- default-configs/devices/ppc-softmmu.mak | 1 - hw/ppc/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/devices/ppc-softmmu.mak b/default-configs/devi= ces/ppc-softmmu.mak index c2d41198cde..5a7f99d1e45 100644 --- a/default-configs/devices/ppc-softmmu.mak +++ b/default-configs/devices/ppc-softmmu.mak @@ -1,7 +1,6 @@ # Default configuration for ppc-softmmu =20 # For embedded PPCs: -CONFIG_DS1338=3Dy CONFIG_E500=3Dy CONFIG_PPC405=3Dy CONFIG_PPC440=3Dy diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 66e0b15d9ef..2e4c56eb770 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -128,6 +128,7 @@ config E500 select SERIAL select MPC_I2C select FDT_PPC + select DS1338 =20 config VIRTEX bool --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100285; cv=none; d=zohomail.com; s=zohoarc; b=S3iUjHiKrkmuFBwTek/Q98EApb7A0yLBnFGeAIS2e1ZMJ4deF8moEVE3d5RZ2Dv8It7TNdtjN0REvUxxrd0rEnEBlmRCgbM5PrgXfTffbHLmjKuZHoPngLMUC+k1JL+lzq0PgwamYXhHykHThaygGOx5z+RhD/Np0ZAY0TxzW7c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100285; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yMKbvRHD0VVgAl/shSsvEL3fFV0zSLsEZF6v1iEj1U8=; b=g2eQ+8v8G/YReQGzBU6q0SRZHuovkJe1VQ9XX/8JRcdEReBVkjSDeQ+av88f0HfPnpJx5hQbWpeR6et6HeS6P4y5Ze9+MEL8Fhiq/+gc+dhjqTRRkzpG5vLYN1FeCfL/bvlqzyH4/FLEkyar1lAFcI4QAG3nLWNvqe47rZ4m78s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100285804993.6918827245881; Sat, 15 May 2021 10:38:05 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-Nq-U2C9sO7a8LULJOwtuog-1; Sat, 15 May 2021 13:38:02 -0400 Received: by mail-wm1-f72.google.com with SMTP id 12-20020a1c010c0000b0290176491efde9so100683wmb.4 for ; Sat, 15 May 2021 10:38:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id k6sm14457835wmi.42.2021.05.15.10.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yMKbvRHD0VVgAl/shSsvEL3fFV0zSLsEZF6v1iEj1U8=; b=GecnskS1W4y3lxaZnmGbTFOL6jTM6nh82s3mCtmZdDsqUbd2gITQWaCVDGBGkTbPs9AJ8U 24ag4/DDxk5i7LByYgArbYJVRAAQrJFXWkhgG/r8atH6D8KvlNOaWwAXnhO7BxN45DQFgx qrtHygs8gP5i7QPvMaDnttY37YUFYHE= X-MC-Unique: Nq-U2C9sO7a8LULJOwtuog-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yMKbvRHD0VVgAl/shSsvEL3fFV0zSLsEZF6v1iEj1U8=; b=qFpE9uB5CQzyHue/ybIPIE/aZ2hsqQ4L7hBI3hGAwn8Y3cCyJNrUkhO02dCZ97TAmj ynACWeo6mNj0RK+aM7qgqGm7Qa1BCJUjGxKCzKJjJUXRFxsnvZO1YHSO1oTSCPN6GRTU b+0HpTietO06pAk1g+2Irw3nz0XOx1XSwcdamKDycfIbR0uwTGmBDbMjambeVf76urz+ RkCyOVNiKf3JGbyIDp3c+0ljnPe+Zn9XWqO4orJmVkU8eSM9hof3Ufl8c22UknxBxx7X uTy83WxXPz/IltO4nkQLh62LFuKAYGE3aU45OkukLEUSorz0UquhwNOSt64Ozevc5/nK SwEg== X-Gm-Message-State: AOAM531SaKyLrYFugvdwGGPlBXHeGPN3wiYG/U29IoZ3o+rQyPiXZdlN 3dihqB598/8DP1cSTdvRo1lGG3pxBNOqFC7uqExI10CqlhqEpeJoDyPrk3R8kyl3HZwWiD+b24d QHIjAZ6tVdMXZtw== X-Received: by 2002:a05:600c:4ca1:: with SMTP id g33mr19751669wmp.7.1621100281681; Sat, 15 May 2021 10:38:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzdkdaJKsqQvEMuw/in8yhkYSzmz4ZUGj7uT9+EgpNyG/uYj5c6KEaDv2tlbB8+jf6n0nPnw== X-Received: by 2002:a05:600c:4ca1:: with SMTP id g33mr19751656wmp.7.1621100281560; Sat, 15 May 2021 10:38:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259 Date: Sat, 15 May 2021 19:37:13 +0200 Message-Id: <20210515173716.358295-10-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Looking at the MV64340 model source, there is a dependency on the 8259 interrupt controller: 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG: 524 /* FIXME: Should this be sent via the PCI bus somehow? */ 525 if (s->gpp_int_level && (s->gpp_value & BIT(31))) { 526 ret =3D pic_read_irq(isa_pic); 527 } 528 break; Add it to Kconfig to avoid the following build failure: /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function `mv64361= _read': hw/pci-host/mv64361.c:526: undefined reference to `isa_pic' /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_= irq' Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC syst= em controller") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng --- hw/pci-host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig index 79c20bf28bb..9dc0d761815 100644 --- a/hw/pci-host/Kconfig +++ b/hw/pci-host/Kconfig @@ -76,3 +76,4 @@ config SH_PCI config MV64361 bool select PCI + select I8259 --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100291; cv=none; d=zohomail.com; s=zohoarc; b=dtoOG7kMSdu62Z6PAs1JYbN8ndwDUZfQqyq+hNdXoexo50uqrBVh6FGXB9FCEHjYG635NYt2FpqKMddfh2XGgivP4xyCKY19hc/SCbBjR7duvWVRtW0ATwC65OvboCiw+FaAHPyR9KIO+epbwjIz3hpP9SrTEBXdVri5RWocxzg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100291; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=1x0uvyxiT8wyEBGvclqUmai2RCxtpbNXg1x32V8Mlyo=; b=WOlIEQfVw9ORGzMq+jU7FpvLXv/sv7R5gTTqIBkGzeNXr41rLuQp8Ogn/VJnIaKahsqbsDBc+Yppuns+4rbQJ9XkLHLGz7bJFsSkXKazoQNxW338cSpSzEOTypC3KTPcn3oi7ZivqDvPkdc5ACBlTV3uS0OJ1ixnu5VucrGXkN4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100291513590.1166923766257; Sat, 15 May 2021 10:38:11 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-xFFBKGL8M-u81W-AyPDI6w-1; Sat, 15 May 2021 13:38:09 -0400 Received: by mail-wm1-f72.google.com with SMTP id h129-20020a1c21870000b02901743c9f70b9so444428wmh.6 for ; Sat, 15 May 2021 10:38:08 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id j14sm10847304wmj.19.2021.05.15.10.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1x0uvyxiT8wyEBGvclqUmai2RCxtpbNXg1x32V8Mlyo=; b=aObJ1AsFSPI8jNeVaaXQBjDgxGil1HxigG6Px0uv7w1pUXRDU0xh5uJuc9pv+Z1CjxjYdu hNX1eRBRiXp/XsjkMEQGayHgPNkfS4wxvqk6GMiTv1p+o3f8hAjuMk8H/FwZbJxE6G+MRc TZRl1ghRocMb4kmIS1CG4bjf0reqJZE= X-MC-Unique: xFFBKGL8M-u81W-AyPDI6w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1x0uvyxiT8wyEBGvclqUmai2RCxtpbNXg1x32V8Mlyo=; b=ixDVRLLPcJCLfD4fYPf2pMIEpjcvdkWGX1mxdKvonz37PGFWB9NJ3xcuUTwnWLnUm3 s0e9Tj1pVJrBiM7zFxqkXO2Mt+CCZXI7axGfNsraRVFtbwg5h9xUdFaBtw0GP085kqLR HCvKBdX0msxksBLF9YNktAVipVygW09dJYSzHxWEJlDmCNVlk6FOqb0zdR74rx9MzliV XEZURF2VsGYhlWSFnPQrYD5pAoO3JKZg8UDPbH3nCWv+6xvvli12rmXl8nQ5sOyTNNwA Qpc9/FhKQYYEhHm9ddG0QRQLOqTjud83HbiM9XT40QQaTFJWdL+BHWbwSXalk1vsW9ai +ySQ== X-Gm-Message-State: AOAM531sit1kAdirQzT+JrTNenPueMs5MrzdCbwd4Eah3FLtS6hP3aKl omUvKACOap0Hg1Lol04V1UR0fIBS/eRn/Ux6y/toDg4A9iociylVKtJ8cBl6JlMUWaz95BBvMp2 E1GzJeWoRRIsCdQ== X-Received: by 2002:a1c:27c5:: with SMTP id n188mr8049125wmn.34.1621100286154; Sat, 15 May 2021 10:38:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMTrQfpdVRUBxDdDTshuD8xC/K1JOLeK8ZGZcE4rK22H2ZM89m7JZ4Xv21inLYBWjycqc9PA== X-Received: by 2002:a1c:27c5:: with SMTP id n188mr8049108wmn.34.1621100286043; Sat, 15 May 2021 10:38:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 10/12] hw/isa/vt82c686: Add missing Kconfig dependencies (build error) Date: Sat, 15 May 2021 19:37:14 +0200 Message-Id: <20210515173716.358295-11-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 The VT82C686 device model misses various dependencies: /usr/bin/ld: libcommon.fa.p/hw_isa_vt82c686.c.o: in function `vt82c686b_r= ealize': hw/isa/vt82c686.c:622: undefined reference to `i8259_init' /usr/bin/ld: hw/isa/vt82c686.c:624: undefined reference to `i8257_dma_ini= t' /usr/bin/ld: hw/isa/vt82c686.c:627: undefined reference to `mc146818_rtc_= init' Add them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng --- hw/isa/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 55e0003ce40..0703512209a 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -49,6 +49,9 @@ config VT82C686 select FDC select USB_UHCI select APM + select I8257 + select I8259 + select MC146818RTC =20 config SMC37C669 bool --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100297; cv=none; d=zohomail.com; s=zohoarc; b=fK8+5gqcR8uULyD+zcYIPes7ROrOwCVIM7H2Ehi7sdcMPeDGbHsACMOpVEoLjK25Ny4DUGY4cMfhgpkET2YW1h0bYzmM/vKuCjCsuaRS6HL0cciZ6Eh+WfsvdzZzlXZMS6Cz3muwOxDkJVMy8Wz9NITVbOAUM7qs/05zH2/vqhM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100297; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=zPLTr9/lf9Tjbqx5BLE7l6ti3Lxwf/eMPMqzxJa5Wn8=; b=mgmOxCp8X3DxFdfqqeQcr/L9TQiOU45lF6N6QPYy+GsL3b8VkvxOYa82BntweBhMpvfNrLDPpcz2ZjT/5iAPYeYsfIoD7VjPYau6sELsYKnRR/I0+963RlNbolDYv4xoMIVLlnyQvtl29EeJ+AXz7HLPo+i0y9Lu5Qr33/t6ee0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621100297080334.4122472921341; Sat, 15 May 2021 10:38:17 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-IfB8JPBPM72N6w5qq-b6OQ-1; Sat, 15 May 2021 13:38:12 -0400 Received: by mail-wm1-f72.google.com with SMTP id r15-20020a05600c35cfb029017373d9f318so446764wmq.4 for ; Sat, 15 May 2021 10:38:12 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id k7sm10529562wro.8.2021.05.15.10.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zPLTr9/lf9Tjbqx5BLE7l6ti3Lxwf/eMPMqzxJa5Wn8=; b=QCMNB/KbJrWpzWXXcliWhY+bwdNTvUGPqAdBua9L7xHY0Z18J6ACe6QmLq2TEaJlavFHlk vAcp9UGQo0D7qVvWPCsRGU9VEBWsKTFM0XDVo/h94GFjqZlUxk7IhONYuKTH6qvnrBqksP IUBJL+wWIkhDV6UXzuAEmrevKOprHu4= X-MC-Unique: IfB8JPBPM72N6w5qq-b6OQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zPLTr9/lf9Tjbqx5BLE7l6ti3Lxwf/eMPMqzxJa5Wn8=; b=DvDVo8cVhqUu89nKni+0ziLm2jhxRz3czHDdyC7BusZwsWPiLb2gQfA2ObooXKSmTw RENgoYb2cnMQhCJIzN7WDU4I76H7HmIC8sYTPdCL8euqQWx47onaVXG8stMITmipWlSL 1NLDTCom4cQszneZkvLCRf1KHcWDAVYGvpVdN8Vn2OLKsJk09oJVJEI+SroaMnuUeDB9 hK1MIOgVDJ558csDEaxxfjjMrkxhEMw27LZen5DDrvv2cSBzAWdjCgfPsicjkzAn1+Zv WKFq0uGzMMeMv+6s2HC7Pe03lShRkhUU2Ml7mmYm5V/rzjVPFc1nrUZEcKVANfO3CkFG StRA== X-Gm-Message-State: AOAM531zo52KwJJA+rAlbsTFariNU/mwEOwky9ylcd/I48mW4w3jcvbI l6BC+zUILLfulc1xrehDU/BNK8Rl9PoJOYy0eYAQnY1+FFfhg7DA2S8Me+YSibFck3465wArIeR /WoFLThYnZl5/ng== X-Received: by 2002:a05:600c:4e86:: with SMTP id f6mr17699063wmq.63.1621100290701; Sat, 15 May 2021 10:38:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzii0Xl0VixUiqyqFHFGIsEHeMGPXKtofe5AKg67YPxW4QJJQNwlVEfch8ScK0g6JbQfJiAGw== X-Received: by 2002:a05:600c:4e86:: with SMTP id f6mr17699051wmq.63.1621100290564; Sat, 15 May 2021 10:38:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 11/12] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error) Date: Sat, 15 May 2021 19:37:15 +0200 Message-Id: <20210515173716.358295-12-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 When building the Pegasos2 machine stand-alone we get: $ qemu-system-ppc -M pegasos2 -bios pegasos2.rom ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type !=3D= NULL) Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: = (type !=3D NULL) Looking at the backtrace: Thread 1 "qemu-system-ppc" received signal SIGABRT, Aborted. (gdb) bt #0 0x00007ffff53877d5 in raise () at /lib64/libc.so.6 #1 0x00007ffff5370895 in abort () at /lib64/libc.so.6 #2 0x00007ffff6dc4b6c in g_assertion_message_expr.cold () at /lib64/libg= lib-2.0.so.0 #3 0x00007ffff6e229ff in g_assertion_message_expr () at /lib64/libglib-2= .0.so.0 #4 0x0000555555a0c8f4 in object_new_with_type (type=3D0x0) at qom/object= .c:714 #5 0x0000555555a0c9d5 in object_new (typename=3D0x555555c7afe4 "isa-pit"= ) at qom/object.c:747 #6 0x0000555555a053b8 in qdev_new (name=3D0x555555c7afe4 "isa-pit") at h= w/core/qdev.c:153 #7 0x00005555557cdd05 in isa_new (name=3D0x555555c7afe4 "isa-pit") at hw= /isa/isa-bus.c:160 #8 0x00005555557cf518 in i8254_pit_init (bus=3D0x55555603d140, base=3D64= , isa_irq=3D0, alt_irq=3D0x0) at include/hw/timer/i8254.h:54 #9 0x00005555557d12f9 in vt8231_realize (d=3D0x5555563d9770, errp=3D0x7f= ffffffcc28) at hw/isa/vt82c686.c:704 #10 0x00005555557e1340 in pci_qdev_realize (qdev=3D0x5555563d9770, errp= =3D0x7fffffffcca0) at hw/pci/pci.c:2116 #11 0x0000555555a06a84 in device_set_realized (obj=3D0x5555563d9770, valu= e=3Dtrue, errp=3D0x7fffffffcda8) at hw/core/qdev.c:761 #12 0x0000555555a0ff9e in property_set_bool (obj=3D0x5555563d9770, v=3D0x= 5555563da090, name=3D0x555555cd7881 "realized", opaque=3D0x5555560acf80, er= rp=3D0x7fffffffcda8) at qom/object.c:2257 #13 0x0000555555a0e098 in object_property_set (obj=3D0x5555563d9770, name= =3D0x555555cd7881 "realized", v=3D0x5555563da090, errp=3D0x555555fc3fa0 ) at qom/object.c:1402 #14 0x0000555555a12271 in object_property_set_qobject (obj=3D0x5555563d97= 70, name=3D0x555555cd7881 "realized", value=3D0x5555563cf0a0, errp=3D0x5555= 55fc3fa0 ) at qom/qom-qobject.c:28 #15 0x0000555555a0e3fb in object_property_set_bool (obj=3D0x5555563d9770,= name=3D0x555555cd7881 "realized", value=3Dtrue, errp=3D0x555555fc3fa0 ) at qom/object.c:1472 #16 0x0000555555a05b15 in qdev_realize (dev=3D0x5555563d9770, bus=3D0x555= 5563d32b0, errp=3D0x555555fc3fa0 ) at hw/core/qdev.c:389 #17 0x0000555555a05b42 in qdev_realize_and_unref (dev=3D0x5555563d9770, b= us=3D0x5555563d32b0, errp=3D0x555555fc3fa0 ) at hw/core/qdev.c= :396 #18 0x00005555557e160f in pci_realize_and_unref (dev=3D0x5555563d9770, bu= s=3D0x5555563d32b0, errp=3D0x555555fc3fa0 ) at hw/pci/pci.c:21= 81 #19 0x00005555557e165b in pci_create_simple_multifunction (bus=3D0x555556= 3d32b0, devfn=3D96, multifunction=3Dtrue, name=3D0x555555c9b63b "vt8231-isa= ") at hw/pci/pci.c:2189 #20 0x0000555555867730 in pegasos2_init (machine=3D0x5555560427a0) at hw/= ppc/pegasos2.c:105 The "isa-pit" type (TYPE_I8254) is missing. Add it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 0703512209a..9822a90ce95 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -49,6 +49,7 @@ config VT82C686 select FDC select USB_UHCI select APM + select I8254 select I8257 select I8259 select MC146818RTC --=20 2.26.3 From nobody Mon May 13 19:22:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100298; cv=none; d=zohomail.com; s=zohoarc; b=RQcAc3Lv2q3lKDQC9q9/vGQLRYOwe2EAuOr3IwSTg3FpJEm2pRfFI91jrkL/PeCVX0OQFQhOhubTNlYq49xAdIVUgft08hiToLAfgi+kf8I+CRtWdvbq9ofHRXVdvyTCP5WJxJBNhAlgw8rFotzvKHLE+AZskrNw1FielNT28cA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100298; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=hGHwK2BS4Tjt7sYTruLWMJBHTB2i72gwei4DqcaqGkk=; b=ntOJEGsTv+8djGOvKPz6zBFoFY6luGfV2U6bvr4Veo1bKQ7DhMltP6wtYaxymFibISgZgT0uhar+79Pbh2fd05Wb1+CGYFtLCGxlXsoHdDFSxCpBfaIYXzxn1uIZ388JfwlkH8SawCkT45CdTxFzRKIY+n2XEvjjh9WaFoi7QGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100298882177.69731369996418; Sat, 15 May 2021 10:38:18 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-601-uueSwVnQO1qf7tu1IKCZaQ-1; Sat, 15 May 2021 13:38:16 -0400 Received: by mail-wm1-f71.google.com with SMTP id u203-20020a1cddd40000b029016dbb86d796so1679673wmg.0 for ; Sat, 15 May 2021 10:38:16 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id c65sm1856551wme.47.2021.05.15.10.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hGHwK2BS4Tjt7sYTruLWMJBHTB2i72gwei4DqcaqGkk=; b=KLMlI859MsrgmBfuYjpLR6pv5fr5W7VFXKOyNrw8Y45ZTkjfVxsDVeJER+Uh5zo+1Slzr7 19PLegE24Qyf/VhNcLVuDzZ8uoG5nxi8x1iTQ8d0R34c39sAZ295uAVRYjdAm1288wkx8D Rs3WWQGSToigszQozohs1hf5lMulhNs= X-MC-Unique: uueSwVnQO1qf7tu1IKCZaQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hGHwK2BS4Tjt7sYTruLWMJBHTB2i72gwei4DqcaqGkk=; b=M6Vh30MAvjjagY4Xigvt8eEZHCWQmxtHcE6PaPNwH63+NTTxiAObsGgJ3VQAJe/veQ ZPAlG7FE+lDCJ5qeh9hj3qi1HepaMLF+84f7brk8XktfLcqFA9LYZ+mYuwBDN4iQAfbt Vf5FVTdcY+9cUwXsFf+7l7WDozvfKszD+XYv/bDpDSXRPbKjd1Pk8ON2ulzdmuVqTIdu 4QF54hOv30bvRnahF7uGxwsubgcLse2xSBxVfucQOZbHnF/C9vt6FaSxjZ7kfPkOYxwK SHjJZc1dGA3rbFfypIoJMyK5ze0xpPrX7btcC3GMnnsOdREEfmqHsGqx6bEEMeU9/5LU Ww4Q== X-Gm-Message-State: AOAM532ntqJld0MhNIwhFWBe+at4mPL3V3x+dzQ6pH2w5xc4gAIHDAdu RPX15ieFr9/uo6rgCtdR1HQrQXj1nF+28ywWKxkYU+JSrfWDh7x+Qi4kMm1lsZz36UoXlhLIOk2 tkXYjomH7/X+5rQ== X-Received: by 2002:a5d:6291:: with SMTP id k17mr67310864wru.247.1621100295154; Sat, 15 May 2021 10:38:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziUdH0gQaG56xw1W0ltobq2jlmlmrXQ0vKqRadi5wNLYD7c6p1gpn9keAKYuORV89RZuLUbA== X-Received: by 2002:a5d:6291:: with SMTP id k17mr67310848wru.247.1621100294991; Sat, 15 May 2021 10:38:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Greg Kurz Subject: [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA Date: Sat, 15 May 2021 19:37:16 +0200 Message-Id: <20210515173716.358295-13-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 While the ATI VGA device isn't a requisite (no crash without it): $ qemu-system-ppc -M pegasos2 qemu-system-ppc: standard VGA not available it is useful to have it with the Pegasos2 machine: $ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device ati-vg= a,romfile=3D qemu-system-ppc: -device ati-vga,romfile=3D: 'ati-vga' is not a valid dev= ice model name Add it as an implicit Kconfig dependency. Fixes: ba7e5ac18e7 ("hw/ppc: Add emulation of Genesi/bPlan Pegasos II") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: BALATON Zoltan Acked-by: David Gibson Reviewed-by: Bin Meng --- hw/ppc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 2e4c56eb770..e36db08665a 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -77,6 +77,7 @@ config PEGASOS2 select SMBUS_EEPROM # This should come with VT82C686 select ACPI_X86 + imply ATI_VGA =20 config PREP bool --=20 2.26.3